Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54640/?format=api
{ "id": 54640, "url": "https://patches.dpdk.org/api/patches/54640/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190611084934.2993-1-iryzhov@nfware.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190611084934.2993-1-iryzhov@nfware.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190611084934.2993-1-iryzhov@nfware.com", "date": "2019-06-11T08:49:34", "name": "[v2] kernel/linux: fix modules install path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "79f505dc89d48e200095eef0e9c5069e061f39ef", "submitter": { "id": 175, "url": "https://patches.dpdk.org/api/people/175/?format=api", "name": "Igor Ryzhov", "email": "iryzhov@nfware.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190611084934.2993-1-iryzhov@nfware.com/mbox/", "series": [ { "id": 4976, "url": "https://patches.dpdk.org/api/series/4976/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4976", "date": "2019-06-11T08:49:34", "name": "[v2] kernel/linux: fix modules install path", "version": 2, "mbox": "https://patches.dpdk.org/series/4976/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/54640/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/54640/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 78FD01C2BC;\n\tTue, 11 Jun 2019 10:49:40 +0200 (CEST)", "from mail-lj1-f193.google.com (mail-lj1-f193.google.com\n\t[209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 588E01C2BA\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 10:49:39 +0200 (CEST)", "by mail-lj1-f193.google.com with SMTP id 131so10769320ljf.4\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 01:49:39 -0700 (PDT)", "from localhost.localdomain ([212.48.63.198])\n\tby smtp.gmail.com with ESMTPSA id\n\tb18sm2390262lfi.30.2019.06.11.01.49.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 11 Jun 2019 01:49:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=nfware-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=PTk3T+zITYqQqayH2xroG+RwDUefaNWcJsBW5et3TWg=;\n\tb=SvOjcgL1bqY8yLfAeFKc9pldNW0BvHfj+CW5HDIoQgm5SJoWXRNCD/o/5bYUOmAqVW\n\tJveXb8CEIEWSyEWLx9NzNuixKrxZfSrfZjfiTXqQLoFXulkMdrlI2UniT15g+Q0nw27C\n\tuzHgqXRj3Bmd2qf9ieUFZZM+kCwjpARUKddWxFN98xbNK/2uUlrinLBGhlzmvJFEiO1P\n\tZpfSInu4/+qM9JqW5cPulF3HKWYg2MEdJtQ0ErRAISndrdWsvgA1pcszpZeQgmodzAOE\n\tBeFBiujNbfdZvqFW4Uylm4UCcfsLmmA/zT+PM8fc9yrz+nGJupRsgF6UXqhEy1p5oLYT\n\tBOkA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=PTk3T+zITYqQqayH2xroG+RwDUefaNWcJsBW5et3TWg=;\n\tb=uQL+4UfGdEy1OvoVO7mIP3ZbVymvqbFxz8ZDNBv2Zym9cRx4DGXTO4EGYKA8zdcMjE\n\tEkZImEYmd2vtkCViC0IP6iOUs52mjzN4Oj0mTBSXnF6ru0u6yzwER6YwYufDHjK85Ilf\n\tJsiya34Ktpywsu5saK3BGGLOuJsX3Le1kI9ochySi/vOifSIe4M+Wo52K7YNCCSzSgbJ\n\tZjLnxWijYzARkEINxvM1F44c/Lxi+Oy5aEYOiQuP2Lh4RvCWuytofHsRvpXGmYihVw1P\n\tHgiAGmWnrCksLWG0TulL8Zhv46YJMMMXUApMG+Wm6/xOZz+lWepQM304CO3QeHokG1pL\n\tOXNA==", "X-Gm-Message-State": "APjAAAWNDXT6rw/oIQI78DpuZaJUuCbeWVcvqNNJ9tcWzniTxYsnuuZJ\n\tKnpr2EFGm5y8yNPb4nVDLjHNf4Y3C3I=", "X-Google-Smtp-Source": "APXvYqy1dVXJJNE5x6PC3LVbLk6LHCwVm/Zy+ao6rTeRyw9JYVA4AKtXCvHurOuFaewqBGRXNkcaPQ==", "X-Received": "by 2002:a2e:b0f0:: with SMTP id\n\th16mr15292991ljl.21.1560242978498; \n\tTue, 11 Jun 2019 01:49:38 -0700 (PDT)", "From": "Igor Ryzhov <iryzhov@nfware.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com", "Date": "Tue, 11 Jun 2019 11:49:34 +0300", "Message-Id": "<20190611084934.2993-1-iryzhov@nfware.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190610082552.79083-1-iryzhov@nfware.com>", "References": "<20190610082552.79083-1-iryzhov@nfware.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] kernel/linux: fix modules install path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently kernel modules are installed into /usr/src instead of\n/lib/modules when meson build system is used. This patch fixes that.\n\nSigned-off-by: Igor Ryzhov <iryzhov@nfware.com>\n---\nv2 - don't change kernel_dir to kernel_version\n\n kernel/linux/igb_uio/meson.build | 4 ++--\n kernel/linux/kni/meson.build | 4 ++--\n kernel/linux/meson.build | 4 ++--\n meson_options.txt | 2 +-\n 4 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/kernel/linux/igb_uio/meson.build b/kernel/linux/igb_uio/meson.build\nindex f5a9d5ccf..fac404f07 100644\n--- a/kernel/linux/igb_uio/meson.build\n+++ b/kernel/linux/igb_uio/meson.build\n@@ -8,7 +8,7 @@ mkfile = custom_target('igb_uio_makefile',\n custom_target('igb_uio',\n \tinput: ['igb_uio.c', 'Kbuild'],\n \toutput: 'igb_uio.ko',\n-\tcommand: ['make', '-C', kernel_dir,\n+\tcommand: ['make', '-C', kernel_dir + '/build',\n \t\t'M=' + meson.current_build_dir(),\n \t\t'src=' + meson.current_source_dir(),\n \t\t'EXTRA_CFLAGS=-I' + meson.current_source_dir() +\n@@ -16,5 +16,5 @@ custom_target('igb_uio',\n \t\t'modules'],\n \tdepends: mkfile,\n \tinstall: true,\n-\tinstall_dir: kernel_dir + '/../extra/dpdk',\n+\tinstall_dir: kernel_dir + '/extra/dpdk',\n \tbuild_by_default: get_option('enable_kmods'))\ndiff --git a/kernel/linux/kni/meson.build b/kernel/linux/kni/meson.build\nindex a9f48b0e6..955eec949 100644\n--- a/kernel/linux/kni/meson.build\n+++ b/kernel/linux/kni/meson.build\n@@ -13,7 +13,7 @@ kni_sources = files(\n custom_target('rte_kni',\n \tinput: kni_sources,\n \toutput: 'rte_kni.ko',\n-\tcommand: ['make', '-j4', '-C', kernel_dir,\n+\tcommand: ['make', '-j4', '-C', kernel_dir + '/build',\n \t\t'M=' + meson.current_build_dir(),\n \t\t'src=' + meson.current_source_dir(),\n \t\t'MODULE_CFLAGS=-include ' + meson.source_root() + '/config/rte_config.h' +\n@@ -25,5 +25,5 @@ custom_target('rte_kni',\n \tdepends: kni_mkfile,\n \tconsole: true,\n \tinstall: true,\n-\tinstall_dir: kernel_dir + '/../extra/dpdk',\n+\tinstall_dir: kernel_dir + '/extra/dpdk',\n \tbuild_by_default: get_option('enable_kmods'))\ndiff --git a/kernel/linux/meson.build b/kernel/linux/meson.build\nindex a37c95752..1796cc686 100644\n--- a/kernel/linux/meson.build\n+++ b/kernel/linux/meson.build\n@@ -13,11 +13,11 @@ kernel_dir = get_option('kernel_dir')\n if kernel_dir == ''\n \t# use default path for native builds\n \tkernel_version = run_command('uname', '-r').stdout().strip()\n-\tkernel_dir = '/lib/modules/' + kernel_version + '/build'\n+\tkernel_dir = '/lib/modules/' + kernel_version\n endif\n \n # test running make in kernel directory, using \"make kernelversion\"\n-make_returncode = run_command('make', '-sC', kernel_dir,\n+make_returncode = run_command('make', '-sC', kernel_dir + '/build',\n \t\t'kernelversion').returncode()\n if make_returncode != 0\n \twarning('Cannot compile kernel modules as requested - are kernel headers installed?')\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 16d9f92c6..5302b9c68 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -15,7 +15,7 @@ option('ibverbs_link', type: 'combo', choices : ['shared', 'dlopen'], value: 'sh\n option('include_subdir_arch', type: 'string', value: '',\n \tdescription: 'subdirectory where to install arch-dependent headers')\n option('kernel_dir', type: 'string', value: '',\n-\tdescription: 'path to the kernel for building kernel modules, they will be installed in $DEST_DIR/$kernel_dir/../extra/dpdk')\n+\tdescription: 'Path to the kernel for building kernel modules. Headers must be in $kernel_dir/build. Modules will be installed in $DEST_DIR/$kernel_dir/extra/dpdk.')\n option('lib_musdk_dir', type: 'string', value: '',\n \tdescription: 'path to the MUSDK library installation directory')\n option('machine', type: 'string', value: 'native',\n", "prefixes": [ "v2" ] }