Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 54501,
    "url": "https://patches.dpdk.org/api/patches/54501/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190606145054.39995-1-jerinj@marvell.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190606145054.39995-1-jerinj@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190606145054.39995-1-jerinj@marvell.com",
    "date": "2019-06-06T14:50:54",
    "name": "acl: fix build issue with some arm64 compiler",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e7b7bfed3cf3c7dbbc89d2d820ebab53d9413548",
    "submitter": {
        "id": 1188,
        "url": "https://patches.dpdk.org/api/people/1188/?format=api",
        "name": "Jerin Jacob Kollanukkaran",
        "email": "jerinj@marvell.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190606145054.39995-1-jerinj@marvell.com/mbox/",
    "series": [
        {
            "id": 4933,
            "url": "https://patches.dpdk.org/api/series/4933/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4933",
            "date": "2019-06-06T14:50:54",
            "name": "acl: fix build issue with some arm64 compiler",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/4933/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/54501/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/54501/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CFCBA1B95B;\n\tThu,  6 Jun 2019 16:51:03 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 256F71B959;\n\tThu,  6 Jun 2019 16:51:02 +0200 (CEST)",
            "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx56Ea4rs026892; Thu, 6 Jun 2019 07:50:56 -0700",
            "from sc-exch03.marvell.com ([199.233.58.183])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2sxthej9q1-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tThu, 06 Jun 2019 07:50:55 -0700",
            "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tThu, 6 Jun 2019 07:50:54 -0700",
            "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Thu, 6 Jun 2019 07:50:54 -0700",
            "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n\tby maili.marvell.com (Postfix) with ESMTP id 50E3F3F703F;\n\tThu,  6 Jun 2019 07:50:52 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : mime-version :\n\tcontent-transfer-encoding : content-type; s=pfpt0818;\n\tbh=Xq2TY42gFuVSkock1r17n0PQukmtkZX8d60QllqHfpw=; \n\tb=fj8UdAFH56Xektaw7caISwsy0ozev6tE1ofPbErcg8bLXV+B58fgJQss9GvhJxjIkMFS\n\teK6TuupD9/PmEtu/OKO1n6toodUy7VomNl3+iPx4IPSIo2gk67ueQDmfp9TzQtRFlx9n\n\tNW/4VjuD+8uJUQ0o+z5HjYvdlmTSeTGKWLK50bQlOjILGLsrJzAUfa5x64v+L0Sx0PY3\n\tUunYEqUZt8N6K09DJuxSJhsblWcxs9vbKPjJUUnJRIizUKbULy2iCkNFT6Ay3Mg4ZJR6\n\tR4XQxPPbvVA480ZdbVQ9v+XSgRYjOAZXsrC/9QZvbZLuvpurlSs7dnD/hlJiMgnJwCTQ\n\tvg== ",
        "From": "<jerinj@marvell.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<thomas@monjalon.net>, <gavin.hu@arm.com>, <honnappa.nagarahalli@arm.com>,\n\t<msantana@redhat.com>, <aconole@redhat.com>, Jerin Jacob\n\t<jerinj@marvell.com>, <stable@dpdk.org>",
        "Date": "Thu, 6 Jun 2019 20:20:54 +0530",
        "Message-ID": "<20190606145054.39995-1-jerinj@marvell.com>",
        "X-Mailer": "git-send-email 2.21.0",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-06-06_11:, , signatures=0",
        "Subject": "[dpdk-dev]  [PATCH] acl: fix build issue with some arm64 compiler",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nSome compilers reporting the following error, though the existing\ncode doesn't have any uninitialized variable case.\nJust to make compiler happy, initialize the int32x4_t variable\none shot in C language.\n\n../lib/librte_acl/acl_run_neon.h: In function 'search_neon_4'\n../lib/librte_acl/acl_run_neon.h:230:12: error: 'input' may be\nused uninitialized in this function [-Werror=maybe-uninitialized]\n  int32x4_t input;\n\nFixes: 34fa6c27c156 (\"acl: add NEON optimization for ARMv8\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n lib/librte_acl/acl_run_neon.h | 29 ++++++++++++-----------------\n 1 file changed, 12 insertions(+), 17 deletions(-)",
    "diff": "diff --git a/lib/librte_acl/acl_run_neon.h b/lib/librte_acl/acl_run_neon.h\nindex 01b9766d8..dc9e9efe9 100644\n--- a/lib/librte_acl/acl_run_neon.h\n+++ b/lib/librte_acl/acl_run_neon.h\n@@ -165,7 +165,6 @@ search_neon_8(const struct rte_acl_ctx *ctx, const uint8_t **data,\n \tuint64_t index_array[8];\n \tstruct completion cmplt[8];\n \tstruct parms parms[8];\n-\tint32x4_t input0, input1;\n \n \tacl_set_flow(&flows, cmplt, RTE_DIM(cmplt), data, results,\n \t\t     total_packets, categories, ctx->trans_table);\n@@ -181,17 +180,14 @@ search_neon_8(const struct rte_acl_ctx *ctx, const uint8_t **data,\n \n \twhile (flows.started > 0) {\n \t\t/* Gather 4 bytes of input data for each stream. */\n-\t\tinput0 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 0), input0, 0);\n-\t\tinput1 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 4), input1, 0);\n-\n-\t\tinput0 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 1), input0, 1);\n-\t\tinput1 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 5), input1, 1);\n-\n-\t\tinput0 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 2), input0, 2);\n-\t\tinput1 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 6), input1, 2);\n-\n-\t\tinput0 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 3), input0, 3);\n-\t\tinput1 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 7), input1, 3);\n+\t\tint32x4_t input0 = {GET_NEXT_4BYTES(parms, 0),\n+\t\t\t\t    GET_NEXT_4BYTES(parms, 1),\n+\t\t\t\t    GET_NEXT_4BYTES(parms, 2),\n+\t\t\t\t    GET_NEXT_4BYTES(parms, 3)};\n+\t\tint32x4_t input1 = {GET_NEXT_4BYTES(parms, 4),\n+\t\t\t\t    GET_NEXT_4BYTES(parms, 5),\n+\t\t\t\t    GET_NEXT_4BYTES(parms, 6),\n+\t\t\t\t    GET_NEXT_4BYTES(parms, 7)};\n \n \t\t/* Process the 4 bytes of input on each stream. */\n \n@@ -227,7 +223,6 @@ search_neon_4(const struct rte_acl_ctx *ctx, const uint8_t **data,\n \tuint64_t index_array[4];\n \tstruct completion cmplt[4];\n \tstruct parms parms[4];\n-\tint32x4_t input;\n \n \tacl_set_flow(&flows, cmplt, RTE_DIM(cmplt), data, results,\n \t\t     total_packets, categories, ctx->trans_table);\n@@ -242,10 +237,10 @@ search_neon_4(const struct rte_acl_ctx *ctx, const uint8_t **data,\n \n \twhile (flows.started > 0) {\n \t\t/* Gather 4 bytes of input data for each stream. */\n-\t\tinput = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 0), input, 0);\n-\t\tinput = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 1), input, 1);\n-\t\tinput = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 2), input, 2);\n-\t\tinput = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 3), input, 3);\n+\t\tint32x4_t input = {GET_NEXT_4BYTES(parms, 0),\n+\t\t\t\t   GET_NEXT_4BYTES(parms, 1),\n+\t\t\t\t   GET_NEXT_4BYTES(parms, 2),\n+\t\t\t\t   GET_NEXT_4BYTES(parms, 3)};\n \n \t\t/* Process the 4 bytes of input on each stream. */\n \t\tinput = transition4(input, flows.trans, index_array);\n",
    "prefixes": []
}