Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54500/?format=api
{ "id": 54500, "url": "https://patches.dpdk.org/api/patches/54500/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1559831132-176061-1-git-send-email-asafp@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559831132-176061-1-git-send-email-asafp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559831132-176061-1-git-send-email-asafp@mellanox.com", "date": "2019-06-06T14:25:46", "name": "net/mlx5: fix check for rte calloc return value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "936feaaff864de175d402f70312372a4bafb076e", "submitter": { "id": 1175, "url": "https://patches.dpdk.org/api/people/1175/?format=api", "name": "Asaf Penso", "email": "asafp@mellanox.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1559831132-176061-1-git-send-email-asafp@mellanox.com/mbox/", "series": [ { "id": 4932, "url": "https://patches.dpdk.org/api/series/4932/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4932", "date": "2019-06-06T14:25:46", "name": "net/mlx5: fix check for rte calloc return value", "version": 1, "mbox": "https://patches.dpdk.org/series/4932/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/54500/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/54500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4DD541B95B;\n\tThu, 6 Jun 2019 16:25:49 +0200 (CEST)", "from EUR03-DB5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr40040.outbound.protection.outlook.com [40.107.4.40])\n\tby dpdk.org (Postfix) with ESMTP id A24A21B951;\n\tThu, 6 Jun 2019 16:25:47 +0200 (CEST)", "from AM6PR05MB5736.eurprd05.prod.outlook.com (20.178.93.21) by\n\tAM6PR05MB6295.eurprd05.prod.outlook.com (20.179.4.210) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1965.14; Thu, 6 Jun 2019 14:25:46 +0000", "from AM6PR05MB5736.eurprd05.prod.outlook.com\n\t([fe80::6445:10f6:796c:e1d9]) by\n\tAM6PR05MB5736.eurprd05.prod.outlook.com\n\t([fe80::6445:10f6:796c:e1d9%7]) with mapi id 15.20.1965.011;\n\tThu, 6 Jun 2019 14:25:46 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=+k3MldWbB8muFZJFhIGkxcldep4Zgv4UK/Irg+NaKUs=;\n\tb=LSqYHsjI6FI4gggC4GPOFN3tzsS2i7jkOq8tVx1o8+MbllfB6J8+0wbmTYAS+Yh/fdhXm1N+J64pMlWNmd63VHfqGK3dAC4321/Y4EmcaROqROEPeLHJ7B5fbTZHK4lMEL/Y80EwdoP4qxyFDaGZ2e1NuB/xXQ9zzK2t2UjqA/Y=", "From": "Asaf Penso <asafp@mellanox.com>", "To": "Yongseok Koh <yskoh@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Ori Kam <orika@mellanox.com>, Asaf Penso\n\t<asafp@mellanox.com>, \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH] net/mlx5: fix check for rte calloc return value", "Thread-Index": "AQHVHHO6p9IWZP9al06wASG60HMRsQ==", "Date": "Thu, 6 Jun 2019 14:25:46 +0000", "Message-ID": "<1559831132-176061-1-git-send-email-asafp@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "LO2P265CA0297.GBRP265.PROD.OUTLOOK.COM\n\t(2603:10a6:600:a5::21) To AM6PR05MB5736.eurprd05.prod.outlook.com\n\t(2603:10a6:20b:95::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=asafp@mellanox.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 1.8.3.1", "x-originating-ip": "[37.142.13.130]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "289c6c4f-e3a9-45ec-a10a-08d6ea8add3e", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);\n\tSRVR:AM6PR05MB6295; ", "x-ms-traffictypediagnostic": "AM6PR05MB6295:", "x-microsoft-antispam-prvs": "<AM6PR05MB629575B10E689307754F7ACAC0170@AM6PR05MB6295.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:4502;", "x-forefront-prvs": "00603B7EEF", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(39860400002)(376002)(346002)(136003)(366004)(189003)(199004)(8936002)(54906003)(186003)(81166006)(81156014)(8676002)(50226002)(6506007)(386003)(14444005)(6486002)(4720700003)(5660300002)(316002)(6636002)(52116002)(68736007)(86362001)(99286004)(110136005)(53936002)(478600001)(2906002)(26005)(85306007)(71200400001)(36756003)(73956011)(66946007)(66476007)(6512007)(66556008)(6436002)(66446008)(7736002)(64756008)(305945005)(476003)(14454004)(450100002)(2616005)(486006)(256004)(71190400001)(6116002)(3846002)(4326008)(102836004)(66066001)(25786009);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6295;\n\tH:AM6PR05MB5736.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "N0eggkpef5JBzjV4dsodF+J3PHk/a9nYfqO8pfmQ3Ofg5qbCPQpWz9+V+XLMuaC3bLlc42qyMGfq+HZ2vJc/Tno/tZqBopQgXWzZwhnhw8XtmkF7gSIo41RwOf9MQa6tloIK3/TB7ADARl9PuL8fWzRZSSNpZOr95QOF+umVK33yLzFBDncgctM1LWyDPESjXb7owz5bdTGRA1T/lpZck0/6jSsBT67Ipn5o518VvA8nhF3wQyc23uhEe2dg+FYfwoWavMzcnIpubx4qCSGD2IiY/uuElsN/Jx/bjiMRUTDPKYLxAH+zWT2fZVM6vGj74K58ss0leD70lfuPFH8sNor9vY/weEuyqNQh6eO6lug9yLliMiYS+MncqD6O9XviiTq4qiIUY4FkqNy5U9tP5JP7z1LEifgwxRkBusaAQgk=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "289c6c4f-e3a9-45ec-a10a-08d6ea8add3e", "X-MS-Exchange-CrossTenant-originalarrivaltime": "06 Jun 2019 14:25:46.0957\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "asafp@mellanox.com", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM6PR05MB6295", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_calloc functions returns a non-null pointer in case of\nsuccess and null pointer in case of failure.\n\nThe return value should be checked and the function flow\nshould take that into consideration.\n\nThis patch adds a check for rte_calloc return value in function\nflow_list_create.\n\nFixes: 84c406e7 (\"net/mlx5: add flow translate function\")\nCc: stable@dpdk.org\n\nSigned-off-by: Asaf Penso <asafp@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\r\nindex 9887018..a5821e5 100644\r\n--- a/drivers/net/mlx5/mlx5_flow.c\r\n+++ b/drivers/net/mlx5/mlx5_flow.c\r\n@@ -2092,6 +2092,10 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\r\n \telse\r\n \t\tflow_size += RTE_ALIGN_CEIL(sizeof(uint16_t), sizeof(void *));\r\n \tflow = rte_calloc(__func__, 1, flow_size, 0);\r\n+\tif (!flow) {\r\n+\t\trte_errno = ENOMEM;\r\n+\t\treturn NULL;\r\n+\t}\r\n \tflow->drv_type = flow_get_drv_type(dev, attr);\r\n \tflow->ingress = attr->ingress;\r\n \tflow->transfer = attr->transfer;\r\n", "prefixes": [] }