Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/5439/?format=api
{ "id": 5439, "url": "https://patches.dpdk.org/api/patches/5439/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/6A0DE07E22DDAD4C9103DF62FEBC0909CF33B1@shsmsx102.ccr.corp.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<6A0DE07E22DDAD4C9103DF62FEBC0909CF33B1@shsmsx102.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/6A0DE07E22DDAD4C9103DF62FEBC0909CF33B1@shsmsx102.ccr.corp.intel.com", "date": "2015-06-16T01:36:26", "name": "[dpdk-dev] e1000: enable allmulticast support for VF", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "262891aadaa836d3ba64abfd7a40c87a1d0d7167", "submitter": { "id": 258, "url": "https://patches.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/6A0DE07E22DDAD4C9103DF62FEBC0909CF33B1@shsmsx102.ccr.corp.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/5439/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/5439/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D40C25A87;\n\tTue, 16 Jun 2015 03:36:32 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id AF3D49E7\n\tfor <dev@dpdk.org>; Tue, 16 Jun 2015 03:36:31 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga101.jf.intel.com with ESMTP; 15 Jun 2015 18:36:30 -0700", "from kmsmsx153.gar.corp.intel.com ([172.21.73.88])\n\tby fmsmga002.fm.intel.com with ESMTP; 15 Jun 2015 18:36:29 -0700", "from shsmsx103.ccr.corp.intel.com (10.239.110.14) by\n\tKMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP\n\tServer (TLS) id 14.3.224.2; Tue, 16 Jun 2015 09:36:29 +0800", "from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by\n\tSHSMSX103.ccr.corp.intel.com ([169.254.4.46]) with mapi id\n\t14.03.0224.002; Tue, 16 Jun 2015 09:36:27 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,622,1427785200\"; d=\"scan'208\";a=\"744056587\"", "From": "\"Lu, Wenzhuo\" <wenzhuo.lu@intel.com>", "To": "\"Kylulin, Yury\" <yury.kylulin@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] e1000: enable allmulticast support for VF", "Thread-Index": "AQHQmVU0VFHdAGPCtUmrdBlMSeBSrJ2uddow", "Date": "Tue, 16 Jun 2015 01:36:26 +0000", "Message-ID": "<6A0DE07E22DDAD4C9103DF62FEBC0909CF33B1@shsmsx102.ccr.corp.intel.com>", "References": "<1432824407-11415-1-git-send-email-yury.kylulin@intel.com>", "In-Reply-To": "<1432824407-11415-1-git-send-email-yury.kylulin@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] e1000: enable allmulticast support for VF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Hi Yury,\nI have comments. I think the function name \" igbvf_allmulticast_disable\" is a little misleading. Because this function will disable not only multicast but also unicast, right?\nThanks.\n\n-----Original Message-----\nFrom: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yury Kylulin\nSent: Thursday, May 28, 2015 10:47 PM\nTo: dev@dpdk.org\nSubject: [dpdk-dev] [PATCH] e1000: enable allmulticast support for VF\n\nAdd support to enable and disable reception of all multicast packets by the VF using standard API rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable().\n\nSigned-off-by: Yury Kylulin <yury.kylulin@intel.com>\n---\n drivers/net/e1000/igb_ethdev.c | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)\n\n \t.stats_reset = eth_igbvf_stats_reset,\n@@ -2272,6 +2276,22 @@ igbvf_dev_close(struct rte_eth_dev *dev)\n \tigbvf_dev_stop(dev);\n }\n \n+static void\n+igbvf_allmulticast_enable(struct rte_eth_dev *dev) {\n+\tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\n+\te1000_promisc_set_vf(hw, e1000_promisc_multicast); }\n+\n+static void\n+igbvf_allmulticast_disable(struct rte_eth_dev *dev) {\n+\tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\n+\te1000_promisc_set_vf(hw, e1000_promisc_disabled); }\n+\n static int igbvf_set_vfta(struct e1000_hw *hw, uint16_t vid, bool on) {\n \tstruct e1000_mbx_info *mbx = &hw->mbx;\n--\n1.7.9.5", "diff": "diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index e4b370d..5196bd5 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -135,6 +135,8 @@ static int igbvf_dev_configure(struct rte_eth_dev *dev); static int igbvf_dev_start(struct rte_eth_dev *dev); static void igbvf_dev_stop(struct rte_eth_dev *dev); static void igbvf_dev_close(struct rte_eth_dev *dev);\n+static void igbvf_allmulticast_enable(struct rte_eth_dev *dev); static \n+void igbvf_allmulticast_disable(struct rte_eth_dev *dev);\n static int eth_igbvf_link_update(struct e1000_hw *hw); static void eth_igbvf_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats); static void eth_igbvf_stats_reset(struct rte_eth_dev *dev); @@ -280,6 +282,8 @@ static const struct eth_dev_ops igbvf_eth_dev_ops = {\n \t.dev_start = igbvf_dev_start,\n \t.dev_stop = igbvf_dev_stop,\n \t.dev_close = igbvf_dev_close,\n+\t.allmulticast_enable = igbvf_allmulticast_enable,\n+\t.allmulticast_disable = igbvf_allmulticast_disable,\n \t.link_update = eth_igb_link_update,\n \t.stats_get = eth_igbvf_stats_get,\n", "prefixes": [ "dpdk-dev" ] }