Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54366/?format=api
{ "id": 54366, "url": "https://patches.dpdk.org/api/patches/54366/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190604185352.28629-5-shshaikh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190604185352.28629-5-shshaikh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190604185352.28629-5-shshaikh@marvell.com", "date": "2019-06-04T18:53:52", "name": "[5/5] net/bnx2x: fix supported max Rx and Tx descriptor count", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "41fb138e7c38ef853550649dab0362a6c521904d", "submitter": { "id": 1210, "url": "https://patches.dpdk.org/api/people/1210/?format=api", "name": "Shahed Shaikh", "email": "shshaikh@marvell.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190604185352.28629-5-shshaikh@marvell.com/mbox/", "series": [ { "id": 4894, "url": "https://patches.dpdk.org/api/series/4894/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4894", "date": "2019-06-04T18:53:49", "name": "[1/5] net/bnx2x: fix packet drop", "version": 1, "mbox": "https://patches.dpdk.org/series/4894/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/54366/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/54366/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E24031B9C4;\n\tTue, 4 Jun 2019 20:55:15 +0200 (CEST)", "from NAM03-BY2-obe.outbound.protection.outlook.com\n\t(mail-eopbgr780078.outbound.protection.outlook.com [40.107.78.78])\n\tby dpdk.org (Postfix) with ESMTP id 58C521B9B2;\n\tTue, 4 Jun 2019 20:55:13 +0200 (CEST)", "from DM5PR07CA0073.namprd07.prod.outlook.com (2603:10b6:4:ad::38)\n\tby\n\tSN6PR07MB4670.namprd07.prod.outlook.com (2603:10b6:805:3a::29) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1943.22; Tue, 4 Jun 2019 18:55:12 +0000", "from BY2NAM05FT042.eop-nam05.prod.protection.outlook.com\n\t(2a01:111:f400:7e52::202) by DM5PR07CA0073.outlook.office365.com\n\t(2603:10b6:4:ad::38) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1943.18 via\n\tFrontend Transport; Tue, 4 Jun 2019 18:55:12 +0000", "from CAEXCH02.caveonetworks.com (199.233.58.38) by\n\tBY2NAM05FT042.mail.protection.outlook.com (10.152.100.179) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id\n\t15.20.1965.10 via Frontend Transport; Tue, 4 Jun 2019 18:55:11 +0000", "from dut1171.mv.qlogic.com (10.112.88.18) by\n\tCAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server\n\t(TLS) id 14.2.347.0; Tue, 4 Jun 2019 11:54:01 -0700", "from dut1171.mv.qlogic.com (localhost [127.0.0.1])\tby\n\tdut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x54Is7ef028682;\n\tTue, 4 Jun 2019 11:54:07 -0700", "(from root@localhost)\tby dut1171.mv.qlogic.com\n\t(8.14.7/8.14.7/Submit) id x54Is7sK028681;\n\tTue, 4 Jun 2019 11:54:07 -0700" ], "Authentication-Results": "spf=fail (sender IP is 199.233.58.38)\n\tsmtp.mailfrom=marvell.com; dpdk.org; dkim=none (message not signed)\n\theader.d=none; dpdk.org;\n\tdmarc=fail action=none header.from=marvell.com; ", "Received-SPF": "Fail (protection.outlook.com: domain of marvell.com does not\n\tdesignate 199.233.58.38 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com;", "From": "Shahed Shaikh <shshaikh@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<rmody@marvell.com>, <ferruh.yigit@intel.com>,\n\t<GR-Everest-DPDK-Dev@marvell.com>, <stable@dpdk.org>", "Date": "Tue, 4 Jun 2019 11:53:52 -0700", "Message-ID": "<20190604185352.28629-5-shshaikh@marvell.com>", "X-Mailer": "git-send-email 2.12.0", "In-Reply-To": "<20190604185352.28629-1-shshaikh@marvell.com>", "References": "<20190604185352.28629-1-shshaikh@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-Matching-Connectors": "132041481116846527;\n\t(abac79dc-c90b-41ba-8033-08d666125e47);\n\t(abac79dc-c90b-41ba-8033-08d666125e47)", "X-Forefront-Antispam-Report": "CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(136003)(376002)(39850400004)(396003)(346002)(2980300002)(1110001)(339900001)(189003)(199004)(6666004)(356004)(85426001)(2906002)(76176011)(53936002)(51416003)(486006)(54906003)(1076003)(5660300002)(81156014)(70586007)(76130400001)(50226002)(16586007)(8676002)(70206006)(8936002)(81166006)(305945005)(80596001)(87636003)(2351001)(26826003)(316002)(69596002)(36906005)(105606002)(498600001)(14444005)(476003)(450100002)(11346002)(126002)(2616005)(36756003)(6916009)(4326008)(50466002)(48376002)(68736007)(47776003)(446003)(42186006)(26005)(86362001)(336012);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4670;\n\tH:CAEXCH02.caveonetworks.com; \n\tFPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; MX:1; A:1; ", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "5b557be1-7f8d-47b6-82ed-08d6e91e2c0b", "X-Microsoft-Antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(5600148)(711020)(4605104)(1401327)(2017052603328);\n\tSRVR:SN6PR07MB4670; ", "X-MS-TrafficTypeDiagnostic": "SN6PR07MB4670:", "X-Microsoft-Antispam-PRVS": "<SN6PR07MB467014A1C9B5982308A699FAD3150@SN6PR07MB4670.namprd07.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:6108;", "X-Forefront-PRVS": "0058ABBBC7", "X-Microsoft-Antispam-Message-Info": "D3kl3ojvLArgrFXvcx/cU5cy6CSRZex88JwJ5JKC6iV1G/pn/nyqEdi1lbQBxpIk28acB2p03gh6R91OmPNPf3A44IyzVd5qVzQBsGRJmz92EguP8BssYX72JDzDWGhwIkCr7j8KAFQ26BBfvlVjM9BU+gBrl8RjuNr8Kd2iM+5AX4Gtjovo6xEklDkMms3z9BZGsfb2Ivr51cSGtLRh2x08KUglbJUUSap1YwlKT7SgmO+kcGxdmmBiqn3dty32Swa2eSb1Hfo7cJGKlEeHpUkXjWqzn6vRePcVfgQ85BiXx3gTCx4PKJdpjSDi6UZRSazG9PgUKJyJem6sTh1oA/SyezrmbHQZ/MLoWaJWGBggUEYCJeYGVmQigzTou8fk4aLvntcreWBIJaK7FYyWg7AzxFEFLlRVkSdyUdePLao=", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Jun 2019 18:55:11.3984\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "5b557be1-7f8d-47b6-82ed-08d6e91e2c0b", "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[199.233.58.38]; \n\tHelo=[CAEXCH02.caveonetworks.com]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN6PR07MB4670", "Subject": "[dpdk-dev] [PATCH 5/5] net/bnx2x: fix supported max Rx and Tx\n\tdescriptor count", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Driver does not provide limit on number Rx and Tx descriptors per queue,\nthis may result in application configuring 64k descriptors (default set\nby rte_eth_dev_info_get()) and further result in issues in PMD and HW\nflows due to unsupported number.\n\nFixes: 540a211084a7 (\"bnx2x: driver core\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shahed Shaikh <shshaikh@marvell.com>\n---\n drivers/net/bnx2x/bnx2x.h | 10 ++++++++--\n drivers/net/bnx2x/bnx2x_ethdev.c | 5 +++++\n 2 files changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h\nindex ef1688ff3..e4b4ecf1e 100644\n--- a/drivers/net/bnx2x/bnx2x.h\n+++ b/drivers/net/bnx2x/bnx2x.h\n@@ -155,13 +155,14 @@ struct bnx2x_device_type {\n * Transmit Buffer Descriptor (tx_bd) definitions*\n */\n /* NUM_TX_PAGES must be a power of 2. */\n+#define NUM_TX_PAGES\t\t 16\n #define TOTAL_TX_BD_PER_PAGE (BNX2X_PAGE_SIZE / sizeof(union eth_tx_bd_types)) /* 256 */\n #define USABLE_TX_BD_PER_PAGE (TOTAL_TX_BD_PER_PAGE - 1) /* 255 */\n \n #define TOTAL_TX_BD(q) (TOTAL_TX_BD_PER_PAGE * q->nb_tx_pages) /* 512 */\n #define USABLE_TX_BD(q) (USABLE_TX_BD_PER_PAGE * q->nb_tx_pages) /* 510 */\n #define MAX_TX_BD(q) (TOTAL_TX_BD(q) - 1) /* 511 */\n-\n+#define MAX_TX_AVAIL\t\t (USABLE_TX_BD_PER_PAGE * NUM_TX_PAGES - 2)\n #define NEXT_TX_BD(x) \\\n \t((((x) & USABLE_TX_BD_PER_PAGE) == \\\n \t (USABLE_TX_BD_PER_PAGE - 1)) ? (x) + 2 : (x) + 1)\n@@ -182,13 +183,14 @@ struct bnx2x_device_type {\n /*\n * Receive Buffer Descriptor (rx_bd) definitions*\n */\n-//#define NUM_RX_PAGES 1\n+#define MAX_RX_PAGES 8\n #define TOTAL_RX_BD_PER_PAGE (BNX2X_PAGE_SIZE / sizeof(struct eth_rx_bd)) /* 512 */\n #define USABLE_RX_BD_PER_PAGE (TOTAL_RX_BD_PER_PAGE - 2) /* 510 */\n #define RX_BD_PER_PAGE_MASK (TOTAL_RX_BD_PER_PAGE - 1) /* 511 */\n #define TOTAL_RX_BD(q) (TOTAL_RX_BD_PER_PAGE * q->nb_rx_pages) /* 512 */\n #define USABLE_RX_BD(q) (USABLE_RX_BD_PER_PAGE * q->nb_rx_pages) /* 510 */\n #define MAX_RX_BD(q) (TOTAL_RX_BD(q) - 1) /* 511 */\n+#define MAX_RX_AVAIL\t\t(USABLE_RX_BD_PER_PAGE * MAX_RX_PAGES - 2)\n #define RX_BD_NEXT_PAGE_DESC_CNT 2\n \n #define NEXT_RX_BD(x) \\\n@@ -244,6 +246,10 @@ struct bnx2x_device_type {\n #define MIN_RX_AVAIL(sc)\t\t\t\t\\\n \t((sc)->dropless_fc ? BD_TH_HI(sc) + 128 : 128)\n \n+#define MIN_RX_SIZE_NONTPA_HW\tETH_MIN_RX_CQES_WITHOUT_TPA\n+#define MIN_RX_SIZE_NONTPA\t(RTE_MAX((uint32_t)MIN_RX_SIZE_NONTPA_HW,\\\n+\t\t\t\t\t(uint32_t)MIN_RX_AVAIL(sc)))\n+\n /*\n * dropless fc calculations for RCQs\n * Number of RCQs should be as number of buffers in BRB:\ndiff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c\nindex df5634fda..5be487765 100644\n--- a/drivers/net/bnx2x/bnx2x_ethdev.c\n+++ b/drivers/net/bnx2x/bnx2x_ethdev.c\n@@ -480,6 +480,7 @@ static void\n bnx2x_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n {\n \tstruct bnx2x_softc *sc = dev->data->dev_private;\n+\n \tdev_info->max_rx_queues = sc->max_rx_queues;\n \tdev_info->max_tx_queues = sc->max_tx_queues;\n \tdev_info->min_rx_bufsize = BNX2X_MIN_RX_BUF_SIZE;\n@@ -487,6 +488,10 @@ bnx2x_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tdev_info->max_mac_addrs = BNX2X_MAX_MAC_ADDRS;\n \tdev_info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_20G;\n \tdev_info->rx_offload_capa = DEV_RX_OFFLOAD_JUMBO_FRAME;\n+\n+\tdev_info->rx_desc_lim.nb_max = MAX_RX_AVAIL;\n+\tdev_info->rx_desc_lim.nb_min = MIN_RX_SIZE_NONTPA;\n+\tdev_info->tx_desc_lim.nb_max = MAX_TX_AVAIL;\n }\n \n static int\n", "prefixes": [ "5/5" ] }