Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54363/?format=api
{ "id": 54363, "url": "https://patches.dpdk.org/api/patches/54363/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190604185352.28629-1-shshaikh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190604185352.28629-1-shshaikh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190604185352.28629-1-shshaikh@marvell.com", "date": "2019-06-04T18:53:48", "name": "[1/5] net/bnx2x: fix packet drop", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d488a6731c58342a43d3ec0cdab41302f3dbd710", "submitter": { "id": 1210, "url": "https://patches.dpdk.org/api/people/1210/?format=api", "name": "Shahed Shaikh", "email": "shshaikh@marvell.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190604185352.28629-1-shshaikh@marvell.com/mbox/", "series": [ { "id": 4894, "url": "https://patches.dpdk.org/api/series/4894/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4894", "date": "2019-06-04T18:53:49", "name": "[1/5] net/bnx2x: fix packet drop", "version": 1, "mbox": "https://patches.dpdk.org/series/4894/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/54363/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/54363/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 25E6B1B95D;\n\tTue, 4 Jun 2019 20:55:07 +0200 (CEST)", "from NAM04-BN3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr680080.outbound.protection.outlook.com [40.107.68.80])\n\tby dpdk.org (Postfix) with ESMTP id 1DF592BEA;\n\tTue, 4 Jun 2019 20:55:04 +0200 (CEST)", "from SN4PR0701CA0004.namprd07.prod.outlook.com\n\t(2603:10b6:803:28::14) by DM5PR07MB2874.namprd07.prod.outlook.com\n\t(2603:10b6:3:8::12) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.12;\n\tTue, 4 Jun 2019 18:55:03 +0000", "from BY2NAM05FT033.eop-nam05.prod.protection.outlook.com\n\t(2a01:111:f400:7e52::209) by SN4PR0701CA0004.outlook.office365.com\n\t(2603:10b6:803:28::14) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1943.17 via\n\tFrontend Transport; Tue, 4 Jun 2019 18:55:02 +0000", "from CAEXCH02.caveonetworks.com (199.233.58.38) by\n\tBY2NAM05FT033.mail.protection.outlook.com (10.152.100.170) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id\n\t15.20.1965.10 via Frontend Transport; Tue, 4 Jun 2019 18:55:02 +0000", "from dut1171.mv.qlogic.com (10.112.88.18) by\n\tCAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server\n\t(TLS) id 14.2.347.0; Tue, 4 Jun 2019 11:53:48 -0700", "from dut1171.mv.qlogic.com (localhost [127.0.0.1])\tby\n\tdut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x54Irsrn028666;\n\tTue, 4 Jun 2019 11:53:54 -0700", "(from root@localhost)\tby dut1171.mv.qlogic.com\n\t(8.14.7/8.14.7/Submit) id x54IrsQU028665;\n\tTue, 4 Jun 2019 11:53:54 -0700" ], "Authentication-Results": "spf=fail (sender IP is 199.233.58.38)\n\tsmtp.mailfrom=marvell.com; dpdk.org; dkim=none (message not signed)\n\theader.d=none; dpdk.org;\n\tdmarc=fail action=none header.from=marvell.com; ", "Received-SPF": "Fail (protection.outlook.com: domain of marvell.com does not\n\tdesignate 199.233.58.38 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com;", "From": "Shahed Shaikh <shshaikh@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<rmody@marvell.com>, <ferruh.yigit@intel.com>,\n\t<GR-Everest-DPDK-Dev@marvell.com>, <stable@dpdk.org>", "Date": "Tue, 4 Jun 2019 11:53:48 -0700", "Message-ID": "<20190604185352.28629-1-shshaikh@marvell.com>", "X-Mailer": "git-send-email 2.12.0", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-Matching-Connectors": "132041481028234696;\n\t(abac79dc-c90b-41ba-8033-08d666125e47);\n\t(abac79dc-c90b-41ba-8033-08d666125e47)", "X-Forefront-Antispam-Report": "CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(396003)(376002)(136003)(39850400004)(346002)(2980300002)(1110001)(339900001)(199004)(189003)(16586007)(6666004)(54906003)(356004)(8936002)(68736007)(36756003)(305945005)(86362001)(81166006)(81156014)(450100002)(8676002)(126002)(50226002)(316002)(498600001)(76130400001)(70206006)(26826003)(70586007)(6916009)(1076003)(36906005)(87636003)(5660300002)(2616005)(476003)(486006)(53936002)(26005)(336012)(85426001)(69596002)(48376002)(42186006)(4326008)(2906002)(47776003)(80596001)(105606002)(50466002)(51416003)(2351001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB2874;\n\tH:CAEXCH02.caveonetworks.com; \n\tFPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; ", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "6d98f219-ff2d-489d-78b3-08d6e91e26c4", "X-Microsoft-Antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(5600148)(711020)(4605104)(1401327)(2017052603328);\n\tSRVR:DM5PR07MB2874; ", "X-MS-TrafficTypeDiagnostic": "DM5PR07MB2874:", "X-Microsoft-Antispam-PRVS": "<DM5PR07MB2874BA0D49331A72CFE8D609D3150@DM5PR07MB2874.namprd07.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:5516;", "X-Forefront-PRVS": "0058ABBBC7", "X-Microsoft-Antispam-Message-Info": "LOmCvAw0ImrfMw1+Iq9T6Nuk7m+jDG0eeJMRTlGRW7X7Tzl00t1fjKDAWd3mLchR0mI7merY616qebsCoEee5fB5kjCkF+iP612moLfe6HjjywN3qOFyR0g5sLdkajACAARB0R3nH2WsLKnwq9Uz27oATaCHZCxPPZpWQmtm+HKx9Wb1xkClTN09Cm8Na90YVjR0+dfptA3nI0CIcLm4WJXjT6r/DoHWDt1E7bxmIiN8BHr82bm9pOLDMkNZhPDNgPLSiXIL2a/SyFQp67P+JjdCJGvIFsCb/QWhx2cf9vz6xOcL4cBKoLAQ1hpZOIJKUcqADd53EKJTjF7xJAkksIYMX1F9DNgvValyOaQgJF1iDVo9L1ivSvjNcJ/DUuiIdbiVaTwOdZt2wvFlBh9V43zhQ8ACZAh82DizWYEkRTQ=", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Jun 2019 18:55:02.5682\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "6d98f219-ff2d-489d-78b3-08d6e91e26c4", "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[199.233.58.38]; \n\tHelo=[CAEXCH02.caveonetworks.com]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM5PR07MB2874", "Subject": "[dpdk-dev] [PATCH 1/5] net/bnx2x: fix packet drop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Patch \"8bd31421c593 (\"net/bnx2x: fix ramrod timeout\")\"\nintroduced a regression where sc->scan_fp flags is\nset for unexpectedly long time. So the slow path completion\nhandler flow is run unnecessarily which walks over receive\ndescriptor ring of fast path and drops the data packets while looking\nfor slow path completion descriptor out of fast path ring.\n\nThis issue is seen under heavy traffic with link events happening\nin background.\n\nFixes: 8bd31421c593 (\"net/bnx2x: fix ramrod timeout\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shahed Shaikh <shshaikh@marvell.com>\n---\n drivers/net/bnx2x/bnx2x.c | 2 ++\n drivers/net/bnx2x/ecore_sp.c | 4 ----\n 2 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c\nindex 3e705c7a1..0698b1a8a 100644\n--- a/drivers/net/bnx2x/bnx2x.c\n+++ b/drivers/net/bnx2x/bnx2x.c\n@@ -4572,6 +4572,8 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp)\n \t\t}\n \t}\n \n+\t/* Assuming we have completed slow path completion, clear the flag */\n+\trte_atomic32_set(&sc->scan_fp, 0);\n \tbnx2x_ack_sb(sc, fp->igu_sb_id, USTORM_ID,\n \t\t le16toh(fp->fp_hc_idx), IGU_INT_ENABLE, 1);\n }\ndiff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c\nindex 43194095b..5ac22e725 100644\n--- a/drivers/net/bnx2x/ecore_sp.c\n+++ b/drivers/net/bnx2x/ecore_sp.c\n@@ -291,10 +291,6 @@ static int ecore_state_wait(struct bnx2x_softc *sc, int state,\n \t\tcnt *= 20;\n \n \tECORE_MSG(sc, \"waiting for state to become %d\", state);\n-\t/* being over protective to remind bnx2x_intr_legacy() to\n-\t * process RAMROD\n-\t */\n-\trte_atomic32_set(&sc->scan_fp, 1);\n \n \tECORE_MIGHT_SLEEP();\n \twhile (cnt--) {\n", "prefixes": [ "1/5" ] }