Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54240/?format=api
{ "id": 54240, "url": "https://patches.dpdk.org/api/patches/54240/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1559583160-13944-17-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559583160-13944-17-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559583160-13944-17-git-send-email-anoobj@marvell.com", "date": "2019-06-03T17:32:16", "name": "[16/39] eventdev: add eventmode CL options framework", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "912caa7b0bfb97df99eb27f4e654f5d5b7de1e4b", "submitter": { "id": 1205, "url": "https://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1559583160-13944-17-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 4868, "url": "https://patches.dpdk.org/api/series/4868/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4868", "date": "2019-06-03T17:32:00", "name": "adding eventmode helper library", "version": 1, "mbox": "https://patches.dpdk.org/series/4868/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/54240/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/54240/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3FE8A1BAA7;\n\tMon, 3 Jun 2019 19:35:02 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 49D091BAA0\n\tfor <dev@dpdk.org>; Mon, 3 Jun 2019 19:35:00 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx53HKOnN027527; Mon, 3 Jun 2019 10:34:59 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2sw79pr6ux-2\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tMon, 03 Jun 2019 10:34:59 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com\n\t(10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tMon, 3 Jun 2019 10:34:55 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Mon, 3 Jun 2019 10:34:55 -0700", "from ajoseph83.caveonetworks.com.com (unknown [10.29.45.56])\n\tby maili.marvell.com (Postfix) with ESMTP id 3B2053F703F;\n\tMon, 3 Jun 2019 10:34:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=4HRHyjMzsx1+DFMZG0tWMj3qY+wvn1teMSYnK+IrPig=;\n\tb=YVgZYfHKFKPZ3y47gNIcA2QJzE0G7GH3t3egVPLwoitTi6eSBnX+2XmfNmdZYLq62qnA\n\tTbslvbrVUnkiIA8dGFMcfOei7/5PwG0DXNJnwZUkGbDoIWGl9VImiGDfAdo7bQUJI5qg\n\tp2WtsvjPrbkRXeiKZBMCPfrGhOkVp/QSHory4BfW+H82rsjQa/17w0JM2w9ajJxsupdz\n\tEAgy9yX8UQAUB0rC6mCdicmpPnwJf5yvrIi1XXaxJn3gK31HM7N1nd+rf35GG6LCR6qX\n\tRHR1ezFdHslrJkeuu+JyGM6zuPEm00GHkwUkxMcEzVgu2SoDPREaeh9DciIsEGrs9fbS\n\tGg== ", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Nikhil Rao <nikhil.rao@intel.com>,\n\t\"Erik Gabriel Carrillo\" <erik.g.carrillo@intel.com>, Abhinandan Gujjar\n\t<abhinandan.gujjar@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Narayana Prasad <pathreya@marvell.com>,\n\t<dev@dpdk.org>, Lukasz Bartosik <lbartosik@marvell.com>, Pavan Nikhilesh\n\t<pbhagavatula@marvell.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,\n\t\"Nipun Gupta\" <nipun.gupta@nxp.com>, Harry van Haaren\n\t<harry.van.haaren@intel.com>, =?utf-8?q?Mattias_R=C3=B6nnblom?=\n\t<mattias.ronnblom@ericsson.com>, Liang Ma <liang.j.ma@intel.com>", "Date": "Mon, 3 Jun 2019 23:02:16 +0530", "Message-ID": "<1559583160-13944-17-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1559583160-13944-1-git-send-email-anoobj@marvell.com>", "References": "<1559583160-13944-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-06-03_13:, , signatures=0", "Subject": "[dpdk-dev] [PATCH 16/39] eventdev: add eventmode CL options\n\tframework", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adding usage prints and CL parsing routines for eventmode. Option to\nselect packet transfer mode is also added.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Lukasz Bartosik <lbartosik@marvell.com>\n---\n lib/librte_eventdev/rte_eventdev_version.map | 2 +\n lib/librte_eventdev/rte_eventmode_helper.c | 128 +++++++++++++++++++++++++++\n lib/librte_eventdev/rte_eventmode_helper.h | 51 +++++++++++\n 3 files changed, 181 insertions(+)", "diff": "diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map\nindex 95fd089..1199064 100644\n--- a/lib/librte_eventdev/rte_eventdev_version.map\n+++ b/lib/librte_eventdev/rte_eventdev_version.map\n@@ -128,4 +128,6 @@ EXPERIMENTAL {\n \n \trte_event_eth_rx_adapter_cb_register;\n \trte_event_eth_rx_adapter_stats_get;\n+\trte_eventmode_helper_print_options_list;\n+\trte_eventmode_helper_print_options_description;\n };\ndiff --git a/lib/librte_eventdev/rte_eventmode_helper.c b/lib/librte_eventdev/rte_eventmode_helper.c\nindex f47970e..8119306 100644\n--- a/lib/librte_eventdev/rte_eventmode_helper.c\n+++ b/lib/librte_eventdev/rte_eventmode_helper.c\n@@ -1,7 +1,135 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n * Copyright (C) 2019 Marvell International Ltd.\n */\n+#include <getopt.h>\n \n #include <rte_eventmode_helper.h>\n+#include <rte_malloc.h>\n \n #include \"rte_eventmode_helper_internal.h\"\n+\n+#define CMD_LINE_OPT_TRANSFER_MODE\t\"transfer-mode\"\n+\n+static const char short_options[] =\n+\t\"\"\n+\t;\n+\n+enum {\n+\t/* long options mapped to a short option */\n+\n+\t/* first long only option value must be >= 256, so that we won't\n+\t * conflict with short options\n+\t */\n+\tCMD_LINE_OPT_MIN_NUM = 256,\n+\tCMD_LINE_OPT_TRANSFER_MODE_NUM,\n+};\n+\n+static const struct option lgopts[] = {\n+\t{CMD_LINE_OPT_TRANSFER_MODE, 1, 0, CMD_LINE_OPT_TRANSFER_MODE_NUM},\n+\t{NULL, 0, 0, 0}\n+};\n+\n+/* Internal functions */\n+\n+static int32_t\n+internal_parse_decimal(const char *str)\n+{\n+\tchar *end = NULL;\n+\tunsigned long num;\n+\n+\tnum = strtoul(str, &end, 10);\n+\tif ((str[0] == '\\0') || (end == NULL) || (*end != '\\0'))\n+\t\treturn -1;\n+\n+\treturn num;\n+}\n+\n+/* Global functions */\n+\n+void __rte_experimental\n+rte_eventmode_helper_print_options_list(void)\n+{\n+\tfprintf(stderr, \" --\"\n+\t\t\" [--transfer-mode MODE]\"\n+\t\t);\n+}\n+\n+void __rte_experimental\n+rte_eventmode_helper_print_options_description(void)\n+{\n+\tfprintf(stderr,\n+\t\t\" --transfer-mode MODE\\n\"\n+\t\t\" 0: Packet transfer via polling (default)\\n\"\n+\t\t\" 1: Packet transfer via eventdev\\n\"\n+\t\t\"\\n\");\n+}\n+\n+static int\n+em_parse_transfer_mode(struct rte_eventmode_helper_conf *conf,\n+\t\tconst char *optarg)\n+{\n+\tint32_t parsed_dec;\n+\n+\tparsed_dec = internal_parse_decimal(optarg);\n+\tif (parsed_dec != RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_POLL &&\n+\t parsed_dec != RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_EVENT) {\n+\t\tRTE_EM_HLPR_LOG_ERR(\"Unsupported packet transfer mode\");\n+\t\treturn -1;\n+\t}\n+\tconf->mode = parsed_dec;\n+\treturn 0;\n+}\n+\n+static void\n+em_initialize_helper_conf(struct rte_eventmode_helper_conf *conf)\n+{\n+\t/* Set default conf */\n+\n+\t/* Packet transfer mode: poll */\n+\tconf->mode = RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_POLL;\n+}\n+\n+struct rte_eventmode_helper_conf *\n+rte_eventmode_helper_parse_args(int argc, char **argv)\n+{\n+\tint32_t opt, ret;\n+\tstruct rte_eventmode_helper_conf *conf = NULL;\n+\n+\t/* Allocate memory for conf */\n+\tconf = rte_zmalloc(\"eventmode-helper-conf\",\n+\t\t\tsizeof(struct rte_eventmode_helper_conf),\n+\t\t\tRTE_CACHE_LINE_SIZE);\n+\tif (conf == NULL) {\n+\t\tRTE_EM_HLPR_LOG_ERR(\n+\t\t\t\"Failed allocating memory for eventmode helper conf\");\n+\t\t\tgoto err;\n+\t}\n+\n+\t/* Initialize conf with default values */\n+\tem_initialize_helper_conf(conf);\n+\n+\twhile ((opt = getopt_long(argc, argv, short_options,\n+\t\t\t\tlgopts, NULL)) != EOF) {\n+\t\tswitch (opt) {\n+\n+\t\t/* Packet transfer mode */\n+\t\tcase CMD_LINE_OPT_TRANSFER_MODE_NUM:\n+\t\t\tret = em_parse_transfer_mode(conf, optarg);\n+\t\t\tif (ret < 0) {\n+\t\t\t\tRTE_EM_HLPR_LOG_ERR(\n+\t\t\t\t\t\"Invalid packet transfer mode\");\n+\t\t\t\tgoto err;\n+\t\t\t}\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tgoto err;\n+\t\t}\n+\t}\n+\treturn conf;\n+\n+err:\n+\tif (conf != NULL)\n+\t\trte_free(conf);\n+\n+\treturn NULL;\n+}\ndiff --git a/lib/librte_eventdev/rte_eventmode_helper.h b/lib/librte_eventdev/rte_eventmode_helper.h\nindex d32cd00..2a0cb30 100644\n--- a/lib/librte_eventdev/rte_eventmode_helper.h\n+++ b/lib/librte_eventdev/rte_eventmode_helper.h\n@@ -8,6 +8,57 @@\n extern \"C\" {\n #endif\n \n+#include <rte_compat.h>\n+\n+/* Packet transfer mode of the application */\n+enum rte_eventmode_helper_pkt_transfer_mode {\n+\tRTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_POLL = 0,\n+\tRTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_EVENT,\n+};\n+\n+struct rte_eventmode_helper_conf {\n+\tenum rte_eventmode_helper_pkt_transfer_mode mode;\n+\t\t/**< Packet transfer mode of the application */\n+\tvoid *mode_params;\n+\t\t/**< Mode specific parameters */\n+};\n+\n+/* Common helper functions for command line parsing */\n+\n+/**\n+ * Print event mode options list\n+ *\n+ */\n+void __rte_experimental\n+rte_eventmode_helper_print_options_list(void);\n+\n+/**\n+ * Print event mode options description\n+ *\n+ */\n+void __rte_experimental\n+rte_eventmode_helper_print_options_description(void);\n+\n+/**\n+ * Parse event mode arguments\n+ *\n+ * The application can call this function in it's argument parsing routine to\n+ * parse the event mode specific args and create the conf accordingly. This\n+ * function is to be executed on the MASTER lcore only.\n+ *\n+ * @param argc\n+ * A non-negative value. If it is greater than 0, the array members\n+ * for argv[0] through argv[argc] (non-inclusive) shall contain pointers\n+ * to strings.\n+ * @param argv\n+ * An array of strings. The contents of the array, as well as the strings\n+ * which are pointed to by the array, may be modified by this function.\n+ * @return\n+ * Configuration generated by parsing the event mode args.\n+ */\n+struct rte_eventmode_helper_conf *\n+rte_eventmode_helper_parse_args(int argc, char **argv);\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "16/39" ] }