Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54189/?format=api
{ "id": 54189, "url": "https://patches.dpdk.org/api/patches/54189/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1559580584-5728-5-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559580584-5728-5-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559580584-5728-5-git-send-email-anoobj@marvell.com", "date": "2019-06-03T16:49:09", "name": "[04/39] examples/l2fwd-event: move global vars to common header", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9e99a494cd3fc3e7d761eb2e14fe0bdce20159c2", "submitter": { "id": 1205, "url": "https://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1559580584-5728-5-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 4867, "url": "https://patches.dpdk.org/api/series/4867/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4867", "date": "2019-06-03T16:49:08", "name": null, "version": 1, "mbox": "https://patches.dpdk.org/series/4867/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/54189/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/54189/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DDF361B95D;\n\tMon, 3 Jun 2019 18:50:24 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 899BE1B953\n\tfor <dev@dpdk.org>; Mon, 3 Jun 2019 18:50:21 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx53GlctE031637; Mon, 3 Jun 2019 09:50:21 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2sw79pr0xj-2\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tMon, 03 Jun 2019 09:50:20 -0700", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tMon, 3 Jun 2019 09:50:15 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Mon, 3 Jun 2019 09:50:13 -0700", "from ajoseph83.caveonetworks.com.com (unknown [10.29.45.56])\n\tby maili.marvell.com (Postfix) with ESMTP id 0FD743F703F;\n\tMon, 3 Jun 2019 09:50:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=WOLbdrCmTmrZriQlYKbojUcOvYxGY2qUVfC0IaCCcw0=;\n\tb=lHHmptE3LMfdgB/ndPen+BuN2Nn099nRdlakdjdoMEXc8O1O68e7lPEA7mDJ4ODRLpSv\n\te13KftNg/AY46dfTdpG8UI0AZuf9ulqOuWEaNJ8FiMdy4agew22JQnWtCWaYTOSqUoe1\n\tvNzqiMXDrn6+87SW4u5wjo5lus5Lv6FnvQUJq/GTrF7o0t2znXfPrBaNhZdqZR36MkfL\n\t0nOwUuqLD0/HjBUlkW2XBt85wysj2t0KY2yfk2oCzrs4HFv+8zVfeE/oSeaMFaLhCm2J\n\tVT3I00y6+JpyJSAauJh0pIbSv1PUgKsKUScmYISLrWlbr+DC7yETdzfa8QfnKyzKsTsO\n\tAg== ", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Nikhil Rao <nikhil.rao@intel.com>,\n\t\"Erik Gabriel Carrillo\" <erik.g.carrillo@intel.com>, Abhinandan Gujjar\n\t<abhinandan.gujjar@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "CC": "Narayana Prasad <pathreya@marvell.com>, <dev@dpdk.org>, Lukasz Bartosik\n\t<lbartosik@marvell.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>, \n\t\"Hemant Agrawal\" <hemant.agrawal@nxp.com>, \n\tNipun Gupta <nipun.gupta@nxp.com>, \"Harry van Haaren\"\n\t<harry.van.haaren@intel.com>, =?utf-8?q?Mattias_R=C3=B6nnblom?=\n\t<mattias.ronnblom@ericsson.com>, Liang Ma <liang.j.ma@intel.com>,\n\t\"Anoob Joseph\" <anoobj@marvell.com>", "Date": "Mon, 3 Jun 2019 22:19:09 +0530", "Message-ID": "<1559580584-5728-5-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1559580584-5728-1-git-send-email-anoobj@marvell.com>", "References": "<1559580584-5728-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-06-03_13:, , signatures=0", "Subject": "[dpdk-dev] [PATCH 04/39] examples/l2fwd-event: move global vars to\n\tcommon header", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Lukasz Bartosik <lbartosik@marvell.com>\n---\n examples/l2fwd-event/l2fwd_common.h | 26 +++++++++++++++++++++++\n examples/l2fwd-event/main.c | 41 +++++++++++++++----------------------\n 2 files changed, 43 insertions(+), 24 deletions(-)", "diff": "diff --git a/examples/l2fwd-event/l2fwd_common.h b/examples/l2fwd-event/l2fwd_common.h\nindex a7bb5af..55226f7 100644\n--- a/examples/l2fwd-event/l2fwd_common.h\n+++ b/examples/l2fwd-event/l2fwd_common.h\n@@ -5,6 +5,10 @@\n #ifndef _L2FWD_COMMON_H_\n #define _L2FWD_COMMON_H_\n \n+#include <stdbool.h>\n+\n+#include <rte_common.h>\n+\n #define RTE_LOGTYPE_L2FWD RTE_LOGTYPE_USER1\n \n #define MAX_PKT_BURST 32\n@@ -34,4 +38,26 @@ struct l2fwd_port_statistics {\n \tuint64_t dropped;\n } __rte_cache_aligned;\n \n+volatile bool force_quit;\n+\n+int mac_updating;\n+\n+/* ethernet addresses of ports */\n+static struct rte_ether_addr l2fwd_ports_eth_addr[RTE_MAX_ETHPORTS];\n+\n+/* mask of enabled ports */\n+static uint32_t l2fwd_enabled_port_mask;\n+\n+/* list of enabled ports */\n+static uint32_t l2fwd_dst_ports[RTE_MAX_ETHPORTS];\n+\n+struct lcore_queue_conf lcore_queue_conf[RTE_MAX_LCORE];\n+\n+struct rte_eth_dev_tx_buffer *tx_buffer[RTE_MAX_ETHPORTS];\n+\n+struct l2fwd_port_statistics port_statistics[RTE_MAX_ETHPORTS];\n+\n+/* A tsc-based timer responsible for triggering statistics printout */\n+uint64_t timer_period;\n+\n #endif /* _L2FWD_COMMON_H_ */\ndiff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c\nindex 1551c7f..67f2bb0 100644\n--- a/examples/l2fwd-event/main.c\n+++ b/examples/l2fwd-event/main.c\n@@ -42,29 +42,11 @@\n \n #include \"l2fwd_common.h\"\n \n-static volatile bool force_quit;\n-\n-/* MAC updating enabled by default */\n-static int mac_updating = 1;\n-\n static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;\n static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;\n \n-/* ethernet addresses of ports */\n-static struct rte_ether_addr l2fwd_ports_eth_addr[RTE_MAX_ETHPORTS];\n-\n-/* mask of enabled ports */\n-static uint32_t l2fwd_enabled_port_mask;\n-\n-/* list of enabled ports */\n-static uint32_t l2fwd_dst_ports[RTE_MAX_ETHPORTS];\n-\n static unsigned int l2fwd_rx_queue_per_lcore = 1;\n \n-struct lcore_queue_conf lcore_queue_conf[RTE_MAX_LCORE];\n-\n-static struct rte_eth_dev_tx_buffer *tx_buffer[RTE_MAX_ETHPORTS];\n-\n static struct rte_eth_conf port_conf = {\n \t.rxmode = {\n \t\t.split_hdr_size = 0,\n@@ -76,11 +58,6 @@ static struct rte_eth_conf port_conf = {\n \n struct rte_mempool *l2fwd_pktmbuf_pool;\n \n-struct l2fwd_port_statistics port_statistics[RTE_MAX_ETHPORTS];\n-\n-/* A tsc-based timer responsible for triggering statistics printout */\n-static uint64_t timer_period = 10; /* default period is 10 seconds */\n-\n /* Print out statistics on packets dropped */\n static void\n print_stats(void)\n@@ -492,6 +469,20 @@ signal_handler(int signum)\n \t}\n }\n \n+static void\n+l2fwd_init_global_vars(void)\n+{\n+\tforce_quit = false;\n+\n+\t/* MAC updating enabled by default */\n+\tmac_updating = 1;\n+\n+\t/* Default period is 10 seconds */\n+\ttimer_period = 10;\n+\n+\tl2fwd_enabled_port_mask = 0;\n+}\n+\n int\n main(int argc, char **argv)\n {\n@@ -505,6 +496,9 @@ main(int argc, char **argv)\n \tunsigned int nb_lcores = 0;\n \tunsigned int nb_mbufs;\n \n+\t/* Set default values for global vars */\n+\tl2fwd_init_global_vars();\n+\n \t/* init EAL */\n \tret = rte_eal_init(argc, argv);\n \tif (ret < 0)\n@@ -512,7 +506,6 @@ main(int argc, char **argv)\n \targc -= ret;\n \targv += ret;\n \n-\tforce_quit = false;\n \tsignal(SIGINT, signal_handler);\n \tsignal(SIGTERM, signal_handler);\n \n", "prefixes": [ "04/39" ] }