Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/5412/?format=api
{ "id": 5412, "url": "https://patches.dpdk.org/api/patches/5412/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1434122299-1632-1-git-send-email-sergio.gonzalez.monroy@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1434122299-1632-1-git-send-email-sergio.gonzalez.monroy@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1434122299-1632-1-git-send-email-sergio.gonzalez.monroy@intel.com", "date": "2015-06-12T15:18:19", "name": "[dpdk-dev] ixgbevf: fix incorrect RX function selection", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1d7c855ffbbe0adaa34ce0473b69bc5155dfd3f0", "submitter": { "id": 73, "url": "https://patches.dpdk.org/api/people/73/?format=api", "name": "Sergio Gonzalez Monroy", "email": "sergio.gonzalez.monroy@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1434122299-1632-1-git-send-email-sergio.gonzalez.monroy@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/5412/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/5412/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3DFD9C328;\n\tFri, 12 Jun 2015 17:18:24 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 3DC98C326\n\tfor <dev@dpdk.org>; Fri, 12 Jun 2015 17:18:23 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP; 12 Jun 2015 08:18:22 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga001.fm.intel.com with ESMTP; 12 Jun 2015 08:18:21 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt5CFIKmp031683 for <dev@dpdk.org>; Fri, 12 Jun 2015 16:18:20 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t5CFIJ6v001671\n\tfor <dev@dpdk.org>; Fri, 12 Jun 2015 16:18:19 +0100", "(from smonroy@localhost)\n\tby sivswdev02.ir.intel.com with id t5CFIJoY001666\n\tfor dev@dpdk.org; Fri, 12 Jun 2015 16:18:19 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,602,1427785200\"; d=\"scan'208\";a=\"726108931\"", "From": "Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 12 Jun 2015 16:18:19 +0100", "Message-Id": "<1434122299-1632-1-git-send-email-sergio.gonzalez.monroy@intel.com>", "X-Mailer": "git-send-email 1.8.5.4", "Subject": "[dpdk-dev] [PATCH] ixgbevf: fix incorrect RX function selection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The logic to select ixgbe VF RX function is different than PF side.\n\nThere are a few issues with its current state:\n - it does not allow to select ixgbe_recv_pkts_vec among other options.\n - it can cause memory corruption for scatter mode as it does not allocate\n enough entries in sw_ring.\n - when checksum is enabled, incorrect vector RX function is selected.\n\nTo solve above issues, change the VF RX function selection logic to\nmimic PF side.\n\nSigned-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 9 +++++++++\n drivers/net/ixgbe/ixgbe_rxtx.c | 11 ++---------\n 2 files changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 0d9f9b2..c1a70a1 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2947,6 +2947,8 @@ static int\n ixgbevf_dev_configure(struct rte_eth_dev *dev)\n {\n \tstruct rte_eth_conf* conf = &dev->data->dev_conf;\n+\tstruct ixgbe_adapter *adapter =\n+\t\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n \n \tPMD_INIT_LOG(DEBUG, \"Configured Virtual Function port id: %d\",\n \t\t dev->data->port_id);\n@@ -2967,6 +2969,13 @@ ixgbevf_dev_configure(struct rte_eth_dev *dev)\n \t}\n #endif\n \n+\t/*\n+\t * Initialize to TRUE. If any of Rx queues doesn't meet the bulk\n+\t * allocation or vector Rx preconditions we will reset it.\n+\t */\n+\tadapter->rx_bulk_alloc_allowed = true;\n+\tadapter->rx_vec_allowed = true;\n+\n \treturn 0;\n }\n \ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex 4f9ab22..7cc26ef 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -4549,7 +4549,6 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)\n \t\t(uint16_t)dev->data->dev_conf.rxmode.max_rx_pkt_len);\n \n \t/* Setup RX queues */\n-\tdev->rx_pkt_burst = ixgbe_recv_pkts;\n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\trxq = dev->data->rx_queues[i];\n \n@@ -4615,14 +4614,6 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)\n \t\t\tif (!dev->data->scattered_rx)\n \t\t\t\tPMD_INIT_LOG(DEBUG, \"forcing scatter mode\");\n \t\t\tdev->data->scattered_rx = 1;\n-#ifdef RTE_IXGBE_INC_VECTOR\n-\t\t\tif (rte_is_power_of_2(rxq->nb_rx_desc))\n-\t\t\t\tdev->rx_pkt_burst =\n-\t\t\t\t\tixgbe_recv_scattered_pkts_vec;\n-\t\t\telse\n-#endif\n-\t\t\t\tdev->rx_pkt_burst =\n-\t\t\t\t\tixgbe_recv_pkts_lro_single_alloc;\n \t\t}\n \t}\n \n@@ -4640,6 +4631,8 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)\n \t\tIXGBE_PSRTYPE_RQPL_SHIFT;\n \tIXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE, psrtype);\n \n+\tixgbe_set_rx_function(dev);\n+\n \treturn 0;\n }\n \n", "prefixes": [ "dpdk-dev" ] }