Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53965/?format=api
{ "id": 53965, "url": "https://patches.dpdk.org/api/patches/53965/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/3abfda8b6646fde5b6c411a2e141bd04a4ec03c5.1559319237.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<3abfda8b6646fde5b6c411a2e141bd04a4ec03c5.1559319237.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3abfda8b6646fde5b6c411a2e141bd04a4ec03c5.1559319237.git.igor.russkikh@aquantia.com", "date": "2019-05-31T16:14:52", "name": "[RFC,3/5] app/testpmd: macsec off command", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bccd33f99d086e9a7d879a3ae1ca86e71e3aa420", "submitter": { "id": 1124, "url": "https://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/3abfda8b6646fde5b6c411a2e141bd04a4ec03c5.1559319237.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 4840, "url": "https://patches.dpdk.org/api/series/4840/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4840", "date": "2019-05-31T16:14:44", "name": "[RFC,1/5] security: MACSEC infrastructure data declarations", "version": 1, "mbox": "https://patches.dpdk.org/series/4840/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53965/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/53965/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D3ED21B9A9;\n\tFri, 31 May 2019 18:14:55 +0200 (CEST)", "from NAM03-DM3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr800072.outbound.protection.outlook.com [40.107.80.72])\n\tby dpdk.org (Postfix) with ESMTP id 057781B957\n\tfor <dev@dpdk.org>; Fri, 31 May 2019 18:14:54 +0200 (CEST)", "from MWHPR11MB1968.namprd11.prod.outlook.com (10.175.54.143) by\n\tMWHPR11MB1262.namprd11.prod.outlook.com (10.169.236.147) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1922.23; Fri, 31 May 2019 16:14:52 +0000", "from MWHPR11MB1968.namprd11.prod.outlook.com\n\t([fe80::fd20:d79e:4027:a437]) by\n\tMWHPR11MB1968.namprd11.prod.outlook.com\n\t([fe80::fd20:d79e:4027:a437%3]) with mapi id 15.20.1943.016;\n\tFri, 31 May 2019 16:14:52 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com;\n\ts=selector1-AQUANTIA1COM-onmicrosoft-com; \n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=UpDxYPge02aAyK4hIFAqyXmAncC6mNZSWnSTl+fs5zQ=;\n\tb=MoCnWdnSJ5XJhH08ROpmV9YHEk0YRz0e3EkZpQ4Tk1PRdm+rd5PNBc11aEJ2A6/s5O/qoAZihzp4pnTrNsQhl8IhRzKlGhzYM26cOCB2fWfzWYsOjlR5zZJt89bpsf1zhNHbNulXyGRyqP9jegrC4dUhveKegvpfkRb0vc6zDrE=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Pavel Belous\n\t<Pavel.Belous@aquantia.com>, John McNamara <john.mcnamara@intel.com>, \n\tKonstantin Ananyev <konstantin.ananyev@intel.com>, Thomas Monjalon\n\t<thomas@monjalon.net>, Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty\n\t<declan.doherty@intel.com>, Igor Russkikh <Igor.Russkikh@aquantia.com>", "Thread-Topic": "[RFC 3/5] app/testpmd: macsec off command", "Thread-Index": "AQHVF8v68Ya2YMuZyUiwO0qasAoGSQ==", "Date": "Fri, 31 May 2019 16:14:52 +0000", "Message-ID": "<3abfda8b6646fde5b6c411a2e141bd04a4ec03c5.1559319237.git.igor.russkikh@aquantia.com>", "References": "<4595add642bf8ca1114488657d12a973b966e8f5.1559319237.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<4595add642bf8ca1114488657d12a973b966e8f5.1559319237.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HE1PR0401CA0056.eurprd04.prod.outlook.com\n\t(2603:10a6:3:19::24) To MWHPR11MB1968.namprd11.prod.outlook.com\n\t(2603:10b6:300:111::15)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "180d5129-6237-49ae-ab78-08d6e5e31c81", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);\n\tSRVR:MWHPR11MB1262; ", "x-ms-traffictypediagnostic": "MWHPR11MB1262:", "x-microsoft-antispam-prvs": "<MWHPR11MB1262417696434293265669D598190@MWHPR11MB1262.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:168;", "x-forefront-prvs": "00540983E2", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(136003)(39850400004)(366004)(346002)(376002)(189003)(199004)(256004)(14444005)(50226002)(66946007)(81166006)(8676002)(11346002)(44832011)(81156014)(14454004)(7736002)(478600001)(72206003)(5660300002)(1730700003)(476003)(2351001)(76176011)(2616005)(26005)(66446008)(71200400001)(186003)(73956011)(71190400001)(68736007)(66556008)(66476007)(64756008)(118296001)(2501003)(25786009)(99286004)(6916009)(305945005)(6116002)(6436002)(4326008)(5640700003)(6512007)(3846002)(102836004)(52116002)(36756003)(2906002)(8936002)(446003)(86362001)(6506007)(54906003)(316002)(107886003)(66066001)(386003)(53936002)(6486002)(486006);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR11MB1262;\n\tH:MWHPR11MB1968.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "tXRrD4w24yMSwFThRCT+WQq6rwR/mDcbLh55GiOHMBRebNIT/p5qslAh/FAwohDwEprBM6+dEt0XnCTX6O0RhCiqBtH6+abOOBoDhuT5dhB4tm0ZqKykSQD6TBpooZapOutlL3OtuRrbJ/JNPPt7Uv9tJIcvDcQ8xBrl3wme5zP4ylBFJJS5hWsO1hGUY+WCOwfizCM2RXhCIznYUwbB7lgyR8cmldZdEthRb69hnzwNE4Icj9bBZeqM9WyVRIpA6lLtAEPig8w+VtFntmdCtd8NAq3QJ8fiGikXPe8dGELk4jctpZ+rihf/WDNu+0Jna6sblvJva8Jf9f3CIg9kgSvyQ+ZH9plIgZOtKxG+4COSFCu5A8iw39tzz4OmsgjvGv4Rr0fLO5zGpYUOUphd31Uw4ZalMK28BFAjtKdTD/U=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "180d5129-6237-49ae-ab78-08d6e5e31c81", "X-MS-Exchange-CrossTenant-originalarrivaltime": "31 May 2019 16:14:52.4055\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "irusski@aquantia.com", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MWHPR11MB1262", "Subject": "[dpdk-dev] [RFC 3/5] app/testpmd: macsec off command", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "draft on how macsec off command will looks like\n\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n app/test-pmd/cmdline.c | 22 +++++++++++++++++-----\n 1 file changed, 17 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\r\nindex dbee3d958c2e..af7c2853fd2c 100644\r\n--- a/app/test-pmd/cmdline.c\r\n+++ b/app/test-pmd/cmdline.c\r\n@@ -14173,6 +14173,8 @@ cmd_set_macsec_offload_off_parsed(\r\n \tint ret = -ENOTSUP;\r\n \tstruct rte_eth_dev_info dev_info;\r\n \tportid_t port_id = res->port_id;\r\n+\tstruct rte_security_ctx *ctx;\r\n+\tstruct rte_eth_dev_info dev_info;\r\n \r\n \tif (port_id_is_invalid(port_id, ENABLED_WARN))\r\n \t\treturn;\r\n@@ -14181,14 +14183,24 @@ cmd_set_macsec_offload_off_parsed(\r\n \t\treturn;\r\n \t}\r\n \r\n-\trte_eth_dev_info_get(port_id, &dev_info);\r\n-\tif (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {\r\n-#ifdef RTE_LIBRTE_IXGBE_PMD\r\n-\t\tret = rte_pmd_ixgbe_macsec_disable(port_id);\r\n-#endif\r\n+\tif (!macsec_session) {\r\n+\t\tprintf(\"MACsec is not active\\n\", port_id);\r\n+\t\treturn;\r\n+\t}\r\n+\r\n+\tctx = rte_eth_dev_get_sec_ctx(port_id);\r\n+\tif (!ctx) {\r\n+\t\tret = -ENOTSUP;\r\n+\t\tgoto done;\r\n \t}\r\n+\r\n+\t/* Use of the same mempool for session header and private data */\r\n+\tret = rte_security_session_destroy(ctx, macsec_session);\r\n+\r\n+done:\r\n \tswitch (ret) {\r\n \tcase 0:\r\n+\t\t/* TBD: Remove this offload bit? */\r\n \t\tports[port_id].dev_conf.txmode.offloads &=\r\n \t\t\t\t\t\t~DEV_TX_OFFLOAD_MACSEC_INSERT;\r\n \t\tcmd_reconfig_device_queue(port_id, 1, 1);\r\n", "prefixes": [ "RFC", "3/5" ] }