Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53955/?format=api
{ "id": 53955, "url": "https://patches.dpdk.org/api/patches/53955/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190531135231.10836-3-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190531135231.10836-3-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190531135231.10836-3-arkadiuszx.kusztal@intel.com", "date": "2019-05-31T13:52:30", "name": "[2/3] crypto/openssl: rework openssl rsa implementation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b0ab124eb5ee71c12dff6ad8ca832e5af373c164", "submitter": { "id": 452, "url": "https://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190531135231.10836-3-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 4838, "url": "https://patches.dpdk.org/api/series/4838/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4838", "date": "2019-05-31T13:52:28", "name": "Rework API for RSA algorithm in asymmetric crypto", "version": 1, "mbox": "https://patches.dpdk.org/series/4838/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53955/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/53955/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CE6261B956;\n\tFri, 31 May 2019 15:54:02 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 2F1571B94B\n\tfor <dev@dpdk.org>; Fri, 31 May 2019 15:54:00 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 May 2019 06:53:59 -0700", "from akusztax-mobl.ger.corp.intel.com ([10.104.14.178])\n\tby fmsmga002.fm.intel.com with ESMTP; 31 May 2019 06:53:57 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,535,1549958400\"; d=\"scan'208\";a=\"180330592\"", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "akhil.goyal@nxp.com, fiona.trahe@intel.com,\n\tshally.verma@caviumnetworks.com,\n\tArek Kusztal <arkadiuszx.kusztal@intel.com>", "Date": "Fri, 31 May 2019 15:52:30 +0200", "Message-Id": "<20190531135231.10836-3-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.19.1.windows.1", "In-Reply-To": "<20190531135231.10836-1-arkadiuszx.kusztal@intel.com>", "References": "<20190531135231.10836-1-arkadiuszx.kusztal@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/3] crypto/openssl: rework openssl rsa\n\timplementation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit reworks implementation of RSA algorithm\nin OPENSSL PMD to be conformant to API changes.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n drivers/crypto/openssl/rte_openssl_pmd.c | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c\nindex 73ce383..b0a8ea2 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd.c\n@@ -1842,15 +1842,13 @@ process_openssl_rsa_op(struct rte_crypto_op *cop,\n \tint ret = 0;\n \tstruct rte_crypto_asym_op *op = cop->asym;\n \tRSA *rsa = sess->u.r.rsa;\n-\tuint32_t pad = (op->rsa.pad);\n+\tuint32_t pad = (op->rsa.padding.type);\n \tuint8_t *tmp;\n \n \tcop->status = RTE_CRYPTO_OP_STATUS_SUCCESS;\n \n \tswitch (pad) {\n-\tcase RTE_CRYPTO_RSA_PKCS1_V1_5_BT0:\n-\tcase RTE_CRYPTO_RSA_PKCS1_V1_5_BT1:\n-\tcase RTE_CRYPTO_RSA_PKCS1_V1_5_BT2:\n+\tcase RTE_CRYPTO_RSA_PADDING_PKCS1:\n \t\tpad = RSA_PKCS1_PADDING;\n \t\tbreak;\n \tcase RTE_CRYPTO_RSA_PADDING_NONE:\n@@ -1867,19 +1865,19 @@ process_openssl_rsa_op(struct rte_crypto_op *cop,\n \tcase RTE_CRYPTO_ASYM_OP_ENCRYPT:\n \t\tret = RSA_public_encrypt(op->rsa.message.length,\n \t\t\t\top->rsa.message.data,\n-\t\t\t\top->rsa.message.data,\n+\t\t\t\top->rsa.cipher.data,\n \t\t\t\trsa,\n \t\t\t\tpad);\n \n \t\tif (ret > 0)\n-\t\t\top->rsa.message.length = ret;\n+\t\t\top->rsa.cipher.length = ret;\n \t\tOPENSSL_LOG(DEBUG,\n \t\t\t\t\"length of encrypted text %d\\n\", ret);\n \t\tbreak;\n \n \tcase RTE_CRYPTO_ASYM_OP_DECRYPT:\n-\t\tret = RSA_private_decrypt(op->rsa.message.length,\n-\t\t\t\top->rsa.message.data,\n+\t\tret = RSA_private_decrypt(op->rsa.cipher.length,\n+\t\t\t\top->rsa.cipher.data,\n \t\t\t\top->rsa.message.data,\n \t\t\t\trsa,\n \t\t\t\tpad);\n", "prefixes": [ "2/3" ] }