Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53946/?format=api
https://patches.dpdk.org/api/patches/53946/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190530212959.1205097-11-benjamin.walker@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190530212959.1205097-11-benjamin.walker@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190530212959.1205097-11-benjamin.walker@intel.com", "date": "2019-05-30T21:29:58", "name": "[v2,11/12] eal/pci: rte_pci_get_iommu_class handles no drivers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7d8f5aef83fc7cbc9d0b8b94f88c6237ef1f0ae1", "submitter": { "id": 487, "url": "https://patches.dpdk.org/api/people/487/?format=api", "name": "Walker, Benjamin", "email": "benjamin.walker@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190530212959.1205097-11-benjamin.walker@intel.com/mbox/", "series": [ { "id": 4832, "url": "https://patches.dpdk.org/api/series/4832/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4832", "date": "2019-05-30T21:29:48", "name": "[v2,01/12] eal: Make rte_eal_using_phys_addrs work sooner", "version": 2, "mbox": "https://patches.dpdk.org/series/4832/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53946/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/53946/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A58731B9AD;\n\tThu, 30 May 2019 23:31:00 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 41F721B94D\n\tfor <dev@dpdk.org>; Thu, 30 May 2019 23:30:28 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 May 2019 14:30:23 -0700", "from bwalker-desk.ch.intel.com ([143.182.136.145])\n\tby fmsmga002.fm.intel.com with ESMTP; 30 May 2019 14:30:25 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,532,1549958400\"; d=\"scan'208\";a=\"180089095\"", "From": "Ben Walker <benjamin.walker@intel.com>", "To": "dev@dpdk.org", "Cc": "Ben Walker <benjamin.walker@intel.com>", "Date": "Thu, 30 May 2019 14:29:58 -0700", "Message-Id": "<20190530212959.1205097-11-benjamin.walker@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190530212959.1205097-1-benjamin.walker@intel.com>", "References": "<20190530174819.1160221-2-benjamin.walker@intel.com>\n\t<20190530212959.1205097-1-benjamin.walker@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 11/12] eal/pci: rte_pci_get_iommu_class\n\thandles no drivers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In the case where no drivers are registered with the system,\nrte_pci_get_iommu_class should return RTE_IOVA_DC.\n\nSigned-off-by: Ben Walker <benjamin.walker@intel.com>\n---\n drivers/bus/pci/linux/pci.c | 91 ++++++++++++++++++++-----------------\n 1 file changed, 50 insertions(+), 41 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex a71c66380..60424932e 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -589,49 +589,80 @@ pci_ignore_device(struct rte_pci_device *dev)\n enum rte_iova_mode\n rte_pci_get_iommu_class(void)\n {\n-\tbool is_bound = false;\n-\tbool is_vfio_noiommu_enabled = true;\n-\tbool has_iova_va = false;\n-\tbool is_bound_uio = false;\n-\tbool iommu_no_va = false;\n-\tstruct rte_pci_device *dev = NULL;\n-\tstruct rte_pci_driver *drv = NULL;\n+\tstruct rte_pci_device *dev;\n+\tstruct rte_pci_driver *drv;\n+\tstruct rte_pci_addr *addr;\n+\tenum rte_iova_mode iova_mode;\n+\n+\tiova_mode = RTE_IOVA_DC;\n \n \tFOREACH_DEVICE_ON_PCIBUS(dev) {\n \t\tif (pci_ignore_device(dev))\n \t\t\tcontinue;\n \n+\t\taddr = &dev->addr;\n+\n \t\tswitch (dev->kdrv) {\n \t\tcase RTE_KDRV_UNKNOWN:\n \t\tcase RTE_KDRV_NONE:\n \t\t\tbreak;\n \t\tcase RTE_KDRV_VFIO:\n-\t\t\tis_bound = true;\n \t\t\tFOREACH_DRIVER_ON_PCIBUS(drv) {\n \t\t\t\tif (!rte_pci_match(drv, dev))\n \t\t\t\t\tcontinue;\n \n-\t\t\t\t/*\n-\t\t\t\t * just one PCI device needs to be checked out because\n-\t\t\t\t * the IOMMU hardware is the same for all of them.\n-\t\t\t\t */\n-\t\t\t\tiommu_no_va = !pci_one_device_iommu_support_va(dev);\n+\t\t\t\tif ((drv->drv_flags & RTE_PCI_DRV_IOVA_AS_VA) == 0)\n+\t\t\t\t\tcontinue;\n \n-\t\t\t\tif (drv->drv_flags & RTE_PCI_DRV_IOVA_AS_VA) {\n-\t\t\t\t\thas_iova_va = true;\n-\t\t\t\t\tbreak;\n+\t\t\t\tif (!pci_one_device_iommu_support_va(dev)) {\n+\t\t\t\t\tRTE_LOG(WARNING, EAL, \"Device \" PCI_PRI_FMT\n+\t\t\t\t\t\t\" wanted IOVA as VA, but \",\n+\t\t\t\t\t\taddr->domain, addr->bus, addr->devid,\n+\t\t\t\t\t\taddr->function);\n+\t\t\t\t\tRTE_LOG(WARNING, EAL,\n+\t\t\t\t\t\t\"IOMMU does not support it.\\n\");\n+\t\t\t\t\tiova_mode = RTE_IOVA_PA;\n+\t\t\t\t}\n+#ifdef VFIO_PRESENT\n+\t\t\t\telse if (rte_vfio_noiommu_is_enabled()) {\n+\t\t\t\t\tRTE_LOG(WARNING, EAL, \"Device \" PCI_PRI_FMT\n+\t\t\t\t\t\t\" wanted IOVA as VA, but \",\n+\t\t\t\t\t\taddr->domain, addr->bus, addr->devid,\n+\t\t\t\t\t\taddr->function);\n+\t\t\t\t\tRTE_LOG(WARNING, EAL,\n+\t\t\t\t\t\t\"vfio-noiommu is enabled.\\n\");\n+\t\t\t\t\tiova_mode = RTE_IOVA_PA;\n+#endif\n+\t\t\t\t} else if (iova_mode == RTE_IOVA_PA) {\n+\t\t\t\t\tRTE_LOG(WARNING, EAL, \"Device \" PCI_PRI_FMT\n+\t\t\t\t\t\t\" wanted IOVA as VA, but \",\n+\t\t\t\t\t\taddr->domain, addr->bus, addr->devid,\n+\t\t\t\t\t\taddr->function);\n+\t\t\t\t\tRTE_LOG(WARNING, EAL,\n+\t\t\t\t\t\t\"other devices require PA.\\n\");\n+\t\t\t\t} else {\n+\t\t\t\t\tiova_mode = RTE_IOVA_VA;\n \t\t\t\t}\n \t\t\t}\n \t\t\tbreak;\n \t\tcase RTE_KDRV_IGB_UIO:\n \t\tcase RTE_KDRV_UIO_GENERIC:\n \t\tcase RTE_KDRV_NIC_UIO:\n-\t\t\tis_bound = true;\n \t\t\tFOREACH_DRIVER_ON_PCIBUS(drv) {\n \t\t\t\tif (!rte_pci_match(drv, dev))\n \t\t\t\t\tcontinue;\n \n-\t\t\t\tis_bound_uio = true;\n+\t\t\t\tif (iova_mode == RTE_IOVA_VA) {\n+\t\t\t\t\tRTE_LOG(WARNING, EAL,\n+\t\t\t\t\t\t\"Some devices wanted IOVA as VA, but \");\n+\t\t\t\t\tRTE_LOG(WARNING, EAL, \"device \" PCI_PRI_FMT\n+\t\t\t\t\t\t\" requires PA.\\n\",\n+\t\t\t\t\t\taddr->domain, addr->bus, addr->devid,\n+\t\t\t\t\t\taddr->function);\n+\n+\t\t\t\t}\n+\n+\t\t\t\tiova_mode = RTE_IOVA_PA;\n \t\t\t\tbreak;\n \t\t\t}\n \t\t\tbreak;\n@@ -639,29 +670,7 @@ rte_pci_get_iommu_class(void)\n \t\t}\n \t}\n \n-\tif (!is_bound)\n-\t\treturn RTE_IOVA_DC;\n-\n-#ifdef VFIO_PRESENT\n-\tis_vfio_noiommu_enabled = rte_vfio_noiommu_is_enabled() == true ?\n-\t\t\t\t\ttrue : false;\n-#endif\n-\n-\tif (has_iova_va && !is_bound_uio && !is_vfio_noiommu_enabled &&\n-\t\t\t!iommu_no_va)\n-\t\treturn RTE_IOVA_VA;\n-\n-\tif (has_iova_va) {\n-\t\tRTE_LOG(WARNING, EAL, \"Some devices want iova as va but pa will be used because.. \");\n-\t\tif (is_vfio_noiommu_enabled)\n-\t\t\tRTE_LOG(WARNING, EAL, \"vfio-noiommu mode configured\\n\");\n-\t\tif (is_bound_uio)\n-\t\t\tRTE_LOG(WARNING, EAL, \"few device bound to UIO\\n\");\n-\t\tif (iommu_no_va)\n-\t\t\tRTE_LOG(WARNING, EAL, \"IOMMU does not support IOVA as VA\\n\");\n-\t}\n-\n-\treturn RTE_IOVA_PA;\n+\treturn iova_mode;\n }\n \n /* Read PCI config space. */\n", "prefixes": [ "v2", "11/12" ] }{ "id": 53946, "url": "