Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53942/?format=api
https://patches.dpdk.org/api/patches/53942/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190530212959.1205097-8-benjamin.walker@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190530212959.1205097-8-benjamin.walker@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190530212959.1205097-8-benjamin.walker@intel.com", "date": "2019-05-30T21:29:55", "name": "[v2,08/12] eal/pci: Collapse loops in rte_pci_get_iommu_class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c3b55303e34885d10bfc948bc9d2946bd11211aa", "submitter": { "id": 487, "url": "https://patches.dpdk.org/api/people/487/?format=api", "name": "Walker, Benjamin", "email": "benjamin.walker@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190530212959.1205097-8-benjamin.walker@intel.com/mbox/", "series": [ { "id": 4832, "url": "https://patches.dpdk.org/api/series/4832/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4832", "date": "2019-05-30T21:29:48", "name": "[v2,01/12] eal: Make rte_eal_using_phys_addrs work sooner", "version": 2, "mbox": "https://patches.dpdk.org/series/4832/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53942/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/53942/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3DDC21B999;\n\tThu, 30 May 2019 23:30:45 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 8E7101B94A\n\tfor <dev@dpdk.org>; Thu, 30 May 2019 23:30:27 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 May 2019 14:30:23 -0700", "from bwalker-desk.ch.intel.com ([143.182.136.145])\n\tby fmsmga002.fm.intel.com with ESMTP; 30 May 2019 14:30:25 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,532,1549958400\"; d=\"scan'208\";a=\"180089086\"", "From": "Ben Walker <benjamin.walker@intel.com>", "To": "dev@dpdk.org", "Cc": "Ben Walker <benjamin.walker@intel.com>", "Date": "Thu, 30 May 2019 14:29:55 -0700", "Message-Id": "<20190530212959.1205097-8-benjamin.walker@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190530212959.1205097-1-benjamin.walker@intel.com>", "References": "<20190530174819.1160221-2-benjamin.walker@intel.com>\n\t<20190530212959.1205097-1-benjamin.walker@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 08/12] eal/pci: Collapse loops in\n\trte_pci_get_iommu_class", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The three loops can now be easily combined into one.\n\nThis is slightly less efficient than before because it\ndoesn't break out early. But that can be addressed\nlater.\n\nSigned-off-by: Ben Walker <benjamin.walker@intel.com>\n---\n drivers/bus/pci/linux/pci.c | 19 +++----------------\n 1 file changed, 3 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex 549d61e74..765c473e8 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -604,15 +604,7 @@ rte_pci_get_iommu_class(void)\n \t\tif (dev->kdrv != RTE_KDRV_UNKNOWN &&\n \t\t dev->kdrv != RTE_KDRV_NONE) {\n \t\t\tis_bound = true;\n-\t\t\tbreak;\n \t\t}\n-\t}\n-\tif (!is_bound)\n-\t\treturn RTE_IOVA_DC;\n-\n-\tFOREACH_DEVICE_ON_PCIBUS(dev) {\n-\t\tif (pci_ignore_device(dev))\n-\t\t\tcontinue;\n \n \t\tif (dev->kdrv == RTE_KDRV_VFIO) {\n \t\t\tFOREACH_DRIVER_ON_PCIBUS(drv) {\n@@ -630,15 +622,7 @@ rte_pci_get_iommu_class(void)\n \t\t\t\t\tbreak;\n \t\t\t\t}\n \t\t\t}\n-\n-\t\t\tif (has_iova_va)\n-\t\t\t\tbreak;\n \t\t}\n-\t}\n-\n-\tFOREACH_DEVICE_ON_PCIBUS(dev) {\n-\t\tif (pci_ignore_device(dev))\n-\t\t\tcontinue;\n \n \t\tif (dev->kdrv == RTE_KDRV_IGB_UIO ||\n \t\t dev->kdrv == RTE_KDRV_UIO_GENERIC) {\n@@ -646,6 +630,9 @@ rte_pci_get_iommu_class(void)\n \t\t}\n \t}\n \n+\tif (!is_bound)\n+\t\treturn RTE_IOVA_DC;\n+\n #ifdef VFIO_PRESENT\n \tis_vfio_noiommu_enabled = rte_vfio_noiommu_is_enabled() == true ?\n \t\t\t\t\ttrue : false;\n", "prefixes": [ "v2", "08/12" ] }{ "id": 53942, "url": "