Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53784/?format=api
{ "id": 53784, "url": "https://patches.dpdk.org/api/patches/53784/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190528194318.11641-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190528194318.11641-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190528194318.11641-1-stephen@networkplumber.org", "date": "2019-05-28T19:43:18", "name": "net/i40e: remove queue_stats_mapping_set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8c00ee52811764accf48e1c85c615f13b3ad114e", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190528194318.11641-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 4801, "url": "https://patches.dpdk.org/api/series/4801/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4801", "date": "2019-05-28T19:43:18", "name": "net/i40e: remove queue_stats_mapping_set", "version": 1, "mbox": "https://patches.dpdk.org/series/4801/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53784/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/53784/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E7FE11B948;\n\tTue, 28 May 2019 21:43:25 +0200 (CEST)", "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n\t[209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 082981B05\n\tfor <dev@dpdk.org>; Tue, 28 May 2019 21:43:24 +0200 (CEST)", "by mail-pf1-f193.google.com with SMTP id b76so12116011pfb.5\n\tfor <dev@dpdk.org>; Tue, 28 May 2019 12:43:23 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tq142sm20583327pfc.27.2019.05.28.12.43.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 28 May 2019 12:43:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=FnvbgjJp8T5i4oEm1ZYXige2fA5DR/hN7Wv1TfCxUkA=;\n\tb=WDq/odDh1ANcu5en4wqmpAGjMdehy+hliIg5+oBOAAa9f1oW/Eqq389vE7u87JbVT2\n\tgI1zGPOE1EykCRzV7RWNQzQNi3mIpi6tIXVuEXZCXbnrO1RaFaHKD2ygP6tUCAtXzReM\n\tG0qYhIBq4mmMgbc+un0T/hufQ6KP3DYrkwkVlEJjTiPNENuehjGF9tBsEJrZwqMtG3c4\n\tWfjKo+AnqLNohPoNqWQbFlXS6l9yUgwDVeGkIrGDMV5pjeZXST3Dms7D+oZqu+fqr1Zt\n\tTRodwHgHh61PPTW7mbTS46kqYkXpf4jQwCS1PZqWRuEp768vSCL8hIH7gNpKrCN3XoAg\n\tZ64A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=FnvbgjJp8T5i4oEm1ZYXige2fA5DR/hN7Wv1TfCxUkA=;\n\tb=NMKW+cuR44awfYqnVtxcqUAYEuUV5qZ4+s13C/mqWzo19gzduh03qu5NzsZbVxHGLP\n\to+sDW1miZVFdeIzPAnxOY9HhoZHw4JmSbHEzX+0nxU7GlnLbJqYHOmqZr3kUsvRpWcDm\n\tVdhNjxV8xkDmfcYi3IESACpfKR+rh8QtAkDba2c80Nbb8qYVcjexDh5hrAeUWgW9hL/F\n\t+hOlLYXzjW3WH6Pwqe20O0FznzBjDTYtquyD2KhMQhQ8HcsW58I7wH4GmACU2h/HMC6G\n\tS1wvhC4Jn5J8WAbXYJBk6Is4fO6dircZTZfFfOu4QTVWuz28VKjLzNlqcCsdlMBldLQ7\n\txvnw==", "X-Gm-Message-State": "APjAAAUa3fKUrXufF07ZPVotR2Yi0K9yCsLgNRsQN0KuqJiPogOlSvN3\n\tRPla37wn54Zfdcp+myLm+M7v2Q==", "X-Google-Smtp-Source": "APXvYqwLD7P3lsOg2ojxUv4q7r3KywFDE7ZaUmO5dOjg6cbGjv9QxCKTcyX0eeoIV+g7DKNIglEc5A==", "X-Received": "by 2002:a63:2d41:: with SMTP id\n\tt62mr135841836pgt.113.1559072603188; \n\tTue, 28 May 2019 12:43:23 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "beilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 28 May 2019 12:43:18 -0700", "Message-Id": "<20190528194318.11641-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This driver was inserting its own stub for queue_stats_mapping which\ndid nothing but cause this device to return a different errno\nthan every other device driver. All devices that don't implement\nqueue stats mapping should return the same error.\n\nMaybe the plan originally was to implement something, if that\never happens, just put in the right code.\n\nFixes: 4861cde46116 (\"i40e: new poll mode driver\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/i40e/i40e_ethdev.c | 16 ----------------\n 1 file changed, 16 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex cab440f5a8f6..5bbcbb4fc608 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -237,10 +237,6 @@ static int i40e_dev_xstats_get_names(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_eth_xstat_name *xstats_names,\n \t\t\t\t unsigned limit);\n static void i40e_dev_stats_reset(struct rte_eth_dev *dev);\n-static int i40e_dev_queue_stats_mapping_set(struct rte_eth_dev *dev,\n-\t\t\t\t\t uint16_t queue_id,\n-\t\t\t\t\t uint8_t stat_idx,\n-\t\t\t\t\t uint8_t is_rx);\n static int i40e_fw_version_get(struct rte_eth_dev *dev,\n \t\t\t\tchar *fw_version, size_t fw_size);\n static void i40e_dev_info_get(struct rte_eth_dev *dev,\n@@ -456,7 +452,6 @@ static const struct eth_dev_ops i40e_eth_dev_ops = {\n \t.xstats_get_names = i40e_dev_xstats_get_names,\n \t.stats_reset = i40e_dev_stats_reset,\n \t.xstats_reset = i40e_dev_stats_reset,\n-\t.queue_stats_mapping_set = i40e_dev_queue_stats_mapping_set,\n \t.fw_version_get = i40e_fw_version_get,\n \t.dev_infos_get = i40e_dev_info_get,\n \t.dev_supported_ptypes_get = i40e_dev_supported_ptypes_get,\n@@ -3431,17 +3426,6 @@ i40e_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \treturn count;\n }\n \n-static int\n-i40e_dev_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *dev,\n-\t\t\t\t __rte_unused uint16_t queue_id,\n-\t\t\t\t __rte_unused uint8_t stat_idx,\n-\t\t\t\t __rte_unused uint8_t is_rx)\n-{\n-\tPMD_INIT_FUNC_TRACE();\n-\n-\treturn -ENOSYS;\n-}\n-\n static int\n i40e_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)\n {\n", "prefixes": [] }