Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53760/?format=api
https://patches.dpdk.org/api/patches/53760/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190528120553.2992-21-lukaszx.krakowiak@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190528120553.2992-21-lukaszx.krakowiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190528120553.2992-21-lukaszx.krakowiak@intel.com", "date": "2019-05-28T12:05:46", "name": "[20/27] sched: update grinder handle function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "efbf9e27b58cd0435153e0701089c3930347ba31", "submitter": { "id": 1221, "url": "https://patches.dpdk.org/api/people/1221/?format=api", "name": "Lukasz Krakowiak", "email": "lukaszx.krakowiak@intel.com" }, "delegate": { "id": 10018, "url": "https://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190528120553.2992-21-lukaszx.krakowiak@intel.com/mbox/", "series": [ { "id": 4794, "url": "https://patches.dpdk.org/api/series/4794/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4794", "date": "2019-05-28T12:05:26", "name": "sched: feature enhancements", "version": 1, "mbox": "https://patches.dpdk.org/series/4794/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53760/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/53760/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0E84A1B9F3;\n\tTue, 28 May 2019 14:08:53 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 8BDD81B99B\n\tfor <dev@dpdk.org>; Tue, 28 May 2019 14:08:40 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 May 2019 05:08:40 -0700", "from lkrakowx-mobl.ger.corp.intel.com ([10.103.104.99])\n\tby fmsmga001.fm.intel.com with ESMTP; 28 May 2019 05:08:38 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Lukasz Krakowiak <lukaszx.krakowiak@intel.com>", "To": "cristian.dumitrescu@intel.com", "Cc": "dev@dpdk.org, Jasvinder Singh <jasvinder.singh@intel.com>,\n\tAbraham Tovar <abrahamx.tovar@intel.com>,\n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 28 May 2019 14:05:46 +0200", "Message-Id": "<20190528120553.2992-21-lukaszx.krakowiak@intel.com>", "X-Mailer": "git-send-email 2.19.2.windows.1", "In-Reply-To": "<20190528120553.2992-1-lukaszx.krakowiak@intel.com>", "References": "<20190528120553.2992-1-lukaszx.krakowiak@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 20/27] sched: update grinder handle function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jasvinder Singh <jasvinder.singh@intel.com>\n\nUpdate grinder handle function implementation of the scheduler to allow\nconfiguration flexiblity for pipe traffic classes and queues, and subport\nlevel configuration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 49 +++++++++++++++++++-----------------\n 1 file changed, 26 insertions(+), 23 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex 34b85af20..0c5479426 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -2495,7 +2495,7 @@ grinder_wrr(struct rte_sched_subport *subport, uint32_t pos)\n }\n \n \n-#define grinder_evict(port, pos)\n+#define grinder_evict(subport, pos)\n \n static inline void\n grinder_prefetch_pipe(struct rte_sched_subport *subport, uint32_t pos)\n@@ -2507,9 +2507,9 @@ grinder_prefetch_pipe(struct rte_sched_subport *subport, uint32_t pos)\n }\n \n static inline void\n-grinder_prefetch_tc_queue_arrays(struct rte_sched_port *port, uint32_t pos)\n+grinder_prefetch_tc_queue_arrays(struct rte_sched_subport *subport, uint32_t pos)\n {\n-\tstruct rte_sched_grinder *grinder = port->subport->grinder + pos;\n+\tstruct rte_sched_grinder *grinder = subport->grinder + pos;\n \tstruct rte_sched_pipe *pipe = grinder->pipe;\n \tstruct rte_sched_queue *queue;\n \tuint32_t tc_index = grinder->tc_index, i;\n@@ -2532,8 +2532,8 @@ grinder_prefetch_tc_queue_arrays(struct rte_sched_port *port, uint32_t pos)\n \t\trte_prefetch0(grinder->be.qbase[i] + qr[i]);\n \t}\n \n-\tgrinder_wrr_load(port->subport, pos);\n-\tgrinder_wrr(port->subport, pos);\n+\tgrinder_wrr_load(subport, pos);\n+\tgrinder_wrr(subport, pos);\n }\n \n static inline void\n@@ -2580,9 +2580,9 @@ grinder_prefetch_mbuf(struct rte_sched_subport *subport, uint32_t pos)\n }\n \n static inline uint32_t\n-grinder_handle(struct rte_sched_port *port, uint32_t pos)\n+grinder_handle(struct rte_sched_port *port,\n+\tstruct rte_sched_subport *subport, uint32_t pos)\n {\n-\tstruct rte_sched_subport *subport = port->subport;\n \tstruct rte_sched_grinder *grinder = subport->grinder + pos;\n \n \tswitch (grinder->state) {\n@@ -2603,9 +2603,9 @@ grinder_handle(struct rte_sched_port *port, uint32_t pos)\n \t{\n \t\tstruct rte_sched_pipe *pipe = grinder->pipe;\n \n-\t\tgrinder->pipe_params = port->pipe_profiles + pipe->profile;\n-\t\tgrinder_prefetch_tc_queue_arrays(port, pos);\n-\t\tgrinder_credits_update(port, port->subport, pos);\n+\t\tgrinder->pipe_params = subport->pipe_profiles + pipe->profile;\n+\t\tgrinder_prefetch_tc_queue_arrays(subport, pos);\n+\t\tgrinder_credits_update(port, subport, pos);\n \n \t\tgrinder->state = e_GRINDER_PREFETCH_MBUF;\n \t\treturn 0;\n@@ -2626,38 +2626,40 @@ grinder_handle(struct rte_sched_port *port, uint32_t pos)\n \t\tresult = grinder_schedule(port, subport, pos);\n \n \t\t/* Look for next packet within the same TC */\n-\t\tif (result && grinder->qmask) {\n-\t\t\tgrinder_wrr(port->subport, pos);\n-\t\t\tgrinder_prefetch_mbuf(port->subport, pos);\n+\t\tif (result &&\n+\t\t\t(grinder->tc_index == RTE_SCHED_TRAFFIC_CLASS_BE) &&\n+\t\t\t(grinder->be.qmask)) {\n+\t\t\tgrinder_wrr(subport, pos);\n+\t\t\tgrinder_prefetch_mbuf(subport, pos);\n \n \t\t\treturn 1;\n \t\t}\n-\t\tgrinder_wrr_store(port->subport, pos);\n+\t\tgrinder_wrr_store(subport, pos);\n \n \t\t/* Look for another active TC within same pipe */\n-\t\tif (grinder_next_tc(port->subport, pos)) {\n-\t\t\tgrinder_prefetch_tc_queue_arrays(port, pos);\n+\t\tif (grinder_next_tc(subport, pos)) {\n+\t\t\tgrinder_prefetch_tc_queue_arrays(subport, pos);\n \n \t\t\tgrinder->state = e_GRINDER_PREFETCH_MBUF;\n \t\t\treturn result;\n \t\t}\n \n \t\tif (grinder->productive == 0 &&\n-\t\t port->pipe_loop == RTE_SCHED_PIPE_INVALID)\n-\t\t\tport->pipe_loop = grinder->pindex;\n+\t\t subport->pipe_loop == RTE_SCHED_PIPE_INVALID)\n+\t\t\tsubport->pipe_loop = grinder->pindex;\n \n-\t\tgrinder_evict(port, pos);\n+\t\tgrinder_evict(subport, pos);\n \n \t\t/* Look for another active pipe */\n-\t\tif (grinder_next_pipe(port->subport, pos)) {\n-\t\t\tgrinder_prefetch_pipe(port->subport, pos);\n+\t\tif (grinder_next_pipe(subport, pos)) {\n+\t\t\tgrinder_prefetch_pipe(subport, pos);\n \n \t\t\tgrinder->state = e_GRINDER_PREFETCH_TC_QUEUE_ARRAYS;\n \t\t\treturn result;\n \t\t}\n \n \t\t/* No active pipe found */\n-\t\tport->busy_grinders--;\n+\t\tsubport->busy_grinders--;\n \n \t\tgrinder->state = e_GRINDER_PREFETCH_PIPE;\n \t\treturn result;\n@@ -2717,7 +2719,8 @@ rte_sched_port_dequeue(struct rte_sched_port *port, struct rte_mbuf **pkts, uint\n \n \t/* Take each queue in the grinder one step further */\n \tfor (i = 0, count = 0; ; i++) {\n-\t\tcount += grinder_handle(port, i & (RTE_SCHED_PORT_N_GRINDERS - 1));\n+\t\tcount += grinder_handle(port, port->subport,\n+\t\t\ti & (RTE_SCHED_PORT_N_GRINDERS - 1));\n \t\tif ((count == n_pkts) ||\n \t\t rte_sched_port_exceptions(port, i >= RTE_SCHED_PORT_N_GRINDERS)) {\n \t\t\tbreak;\n", "prefixes": [ "20/27" ] }{ "id": 53760, "url": "