Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53758/?format=api
https://patches.dpdk.org/api/patches/53758/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190528120553.2992-19-lukaszx.krakowiak@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190528120553.2992-19-lukaszx.krakowiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190528120553.2992-19-lukaszx.krakowiak@intel.com", "date": "2019-05-28T12:05:44", "name": "[18/27] sched: update mbuf prefetch function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "94e1f6193910af4495b321daf998f144b4d88db7", "submitter": { "id": 1221, "url": "https://patches.dpdk.org/api/people/1221/?format=api", "name": "Lukasz Krakowiak", "email": "lukaszx.krakowiak@intel.com" }, "delegate": { "id": 10018, "url": "https://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190528120553.2992-19-lukaszx.krakowiak@intel.com/mbox/", "series": [ { "id": 4794, "url": "https://patches.dpdk.org/api/series/4794/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4794", "date": "2019-05-28T12:05:26", "name": "sched: feature enhancements", "version": 1, "mbox": "https://patches.dpdk.org/series/4794/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53758/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/53758/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 15A7E1B9E4;\n\tTue, 28 May 2019 14:08:50 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 342251B99B\n\tfor <dev@dpdk.org>; Tue, 28 May 2019 14:08:37 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 May 2019 05:08:36 -0700", "from lkrakowx-mobl.ger.corp.intel.com ([10.103.104.99])\n\tby fmsmga001.fm.intel.com with ESMTP; 28 May 2019 05:08:35 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Lukasz Krakowiak <lukaszx.krakowiak@intel.com>", "To": "cristian.dumitrescu@intel.com", "Cc": "dev@dpdk.org, Jasvinder Singh <jasvinder.singh@intel.com>,\n\tAbraham Tovar <abrahamx.tovar@intel.com>,\n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 28 May 2019 14:05:44 +0200", "Message-Id": "<20190528120553.2992-19-lukaszx.krakowiak@intel.com>", "X-Mailer": "git-send-email 2.19.2.windows.1", "In-Reply-To": "<20190528120553.2992-1-lukaszx.krakowiak@intel.com>", "References": "<20190528120553.2992-1-lukaszx.krakowiak@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 18/27] sched: update mbuf prefetch function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jasvinder Singh <jasvinder.singh@intel.com>\n\nUpdate mbuf prefetch function of the scheduler grinder to allow configuration\nflexiblity for pipe traffic classes and queues, and subport level\nconfiguration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 42 ++++++++++++++++++++++++++++--------\n 1 file changed, 33 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex ba344f0a1..06d89e3fd 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -2478,19 +2478,43 @@ grinder_prefetch_tc_queue_arrays(struct rte_sched_port *port, uint32_t pos)\n }\n \n static inline void\n-grinder_prefetch_mbuf(struct rte_sched_port *port, uint32_t pos)\n+grinder_prefetch_mbuf(struct rte_sched_subport *subport, uint32_t pos)\n {\n-\tstruct rte_sched_grinder *grinder = port->grinder + pos;\n-\tuint32_t qpos = grinder->qpos;\n-\tstruct rte_mbuf **qbase = grinder->qbase[qpos];\n-\tuint16_t qsize = grinder->qsize;\n-\tuint16_t qr = grinder->queue[qpos]->qr & (qsize - 1);\n+\tstruct rte_sched_grinder *grinder = subport->grinder + pos;\n+\tstruct rte_mbuf **qbase;\n+\tuint32_t tc_index = grinder->tc_index;\n+\tuint32_t qpos;\n+\tuint16_t qsize, qr;\n+\n+\tif (tc_index < RTE_SCHED_TRAFFIC_CLASS_BE) {\n+\t\tqbase = grinder->sp.qbase;\n+\t\tqsize = grinder->sp.qsize;\n+\t\tqr = grinder->sp.queue->qr & (qsize - 1);\n+\n+\t\tgrinder->pkt = qbase[qr];\n+\t\trte_prefetch0(grinder->pkt);\n+\n+\t\tif (unlikely((qr & 0x7) == 7)) {\n+\t\t\tuint16_t qr_next =\n+\t\t\t\t(grinder->sp.queue->qr + 1) & (qsize - 1);\n+\n+\t\t\trte_prefetch0(qbase + qr_next);\n+\t\t}\n+\n+\t\treturn;\n+\t}\n+\n+\tqpos = grinder->be.qpos;\n+\tqbase = grinder->be.qbase[qpos];\n+\tqsize = grinder->be.qsize[qpos];\n+\tqr = grinder->be.queue[qpos]->qr & (qsize - 1);\n \n \tgrinder->pkt = qbase[qr];\n \trte_prefetch0(grinder->pkt);\n \n \tif (unlikely((qr & 0x7) == 7)) {\n-\t\tuint16_t qr_next = (grinder->queue[qpos]->qr + 1) & (qsize - 1);\n+\t\tuint16_t qr_next =\n+\t\t\t(grinder->be.queue[qpos]->qr + 1) & (qsize - 1);\n \n \t\trte_prefetch0(qbase + qr_next);\n \t}\n@@ -2529,7 +2553,7 @@ grinder_handle(struct rte_sched_port *port, uint32_t pos)\n \n \tcase e_GRINDER_PREFETCH_MBUF:\n \t{\n-\t\tgrinder_prefetch_mbuf(port, pos);\n+\t\tgrinder_prefetch_mbuf(port->subport, pos);\n \n \t\tgrinder->state = e_GRINDER_READ_MBUF;\n \t\treturn 0;\n@@ -2544,7 +2568,7 @@ grinder_handle(struct rte_sched_port *port, uint32_t pos)\n \t\t/* Look for next packet within the same TC */\n \t\tif (result && grinder->qmask) {\n \t\t\tgrinder_wrr(port->subport, pos);\n-\t\t\tgrinder_prefetch_mbuf(port, pos);\n+\t\t\tgrinder_prefetch_mbuf(port->subport, pos);\n \n \t\t\treturn 1;\n \t\t}\n", "prefixes": [ "18/27" ] }{ "id": 53758, "url": "