Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53744/?format=api
{ "id": 53744, "url": "https://patches.dpdk.org/api/patches/53744/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190528120553.2992-11-lukaszx.krakowiak@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190528120553.2992-11-lukaszx.krakowiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190528120553.2992-11-lukaszx.krakowiak@intel.com", "date": "2019-05-28T12:05:36", "name": "[10/27] sched: update subport and tc queue stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1af24acdf7fe9f1b8b153518eb83cf54f61ecaa3", "submitter": { "id": 1221, "url": "https://patches.dpdk.org/api/people/1221/?format=api", "name": "Lukasz Krakowiak", "email": "lukaszx.krakowiak@intel.com" }, "delegate": { "id": 10018, "url": "https://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190528120553.2992-11-lukaszx.krakowiak@intel.com/mbox/", "series": [ { "id": 4794, "url": "https://patches.dpdk.org/api/series/4794/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4794", "date": "2019-05-28T12:05:26", "name": "sched: feature enhancements", "version": 1, "mbox": "https://patches.dpdk.org/series/4794/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53744/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/53744/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 934AC1B9B3;\n\tTue, 28 May 2019 14:08:33 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 25CFF1B998\n\tfor <dev@dpdk.org>; Tue, 28 May 2019 14:08:23 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 May 2019 05:08:22 -0700", "from lkrakowx-mobl.ger.corp.intel.com ([10.103.104.99])\n\tby fmsmga001.fm.intel.com with ESMTP; 28 May 2019 05:08:21 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Lukasz Krakowiak <lukaszx.krakowiak@intel.com>", "To": "cristian.dumitrescu@intel.com", "Cc": "dev@dpdk.org, Jasvinder Singh <jasvinder.singh@intel.com>,\n\tAbraham Tovar <abrahamx.tovar@intel.com>,\n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 28 May 2019 14:05:36 +0200", "Message-Id": "<20190528120553.2992-11-lukaszx.krakowiak@intel.com>", "X-Mailer": "git-send-email 2.19.2.windows.1", "In-Reply-To": "<20190528120553.2992-1-lukaszx.krakowiak@intel.com>", "References": "<20190528120553.2992-1-lukaszx.krakowiak@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 10/27] sched: update subport and tc queue stats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jasvinder Singh <jasvinder.singh@intel.com>\n\nUpdate subport and tc queue stats implementation of scheduler to allow\nconfiguration flexiblity for pipe traffic classes and queues, and subport\nlevel configuration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 46 +++++++++++++++++++-----------------\n 1 file changed, 24 insertions(+), 22 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex d28d2d203..86f2bdf51 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -1412,7 +1412,7 @@ rte_sched_subport_read_stats(struct rte_sched_port *port,\n \t stats == NULL || tc_ov == NULL)\n \t\treturn -1;\n \n-\ts = port->subport + subport_id;\n+\ts = port->subports[subport_id];\n \n \t/* Copy subport stats and clear */\n \tmemcpy(stats, &s->stats, sizeof(struct rte_sched_subport_stats));\n@@ -1468,10 +1468,10 @@ rte_sched_port_queue_is_empty(struct rte_sched_port *port, uint32_t qindex)\n #ifdef RTE_SCHED_COLLECT_STATS\n \n static inline void\n-rte_sched_port_update_subport_stats(struct rte_sched_port *port, uint32_t qindex, struct rte_mbuf *pkt)\n+rte_sched_port_update_subport_stats(struct rte_sched_subport *s,\n+\tstruct rte_mbuf *pkt)\n {\n-\tstruct rte_sched_subport *s = port->subport + (qindex / rte_sched_port_queues_per_subport(port));\n-\tuint32_t tc_index = (qindex >> 2) & 0x3;\n+\tuint32_t tc_index = rte_mbuf_sched_traffic_class_get(pkt);\n \tuint32_t pkt_len = pkt->pkt_len;\n \n \ts->stats.n_pkts_tc[tc_index] += 1;\n@@ -1480,31 +1480,31 @@ rte_sched_port_update_subport_stats(struct rte_sched_port *port, uint32_t qindex\n \n #ifdef RTE_SCHED_RED\n static inline void\n-rte_sched_port_update_subport_stats_on_drop(struct rte_sched_port *port,\n-\t\t\t\t\t\tuint32_t qindex,\n-\t\t\t\t\t\tstruct rte_mbuf *pkt, uint32_t red)\n+rte_sched_port_update_subport_stats_on_drop(struct rte_sched_subport *subport,\n+\t\t\t\t\t\tstruct rte_mbuf *pkt,\n+\t\t\t\t\t\tuint32_t red)\n #else\n static inline void\n-rte_sched_port_update_subport_stats_on_drop(struct rte_sched_port *port,\n-\t\t\t\t\t\tuint32_t qindex,\n-\t\t\t\t\t\tstruct rte_mbuf *pkt, __rte_unused uint32_t red)\n+rte_sched_port_update_subport_stats_on_drop(struct rte_sched_subport *subport,\n+\t\t\t\t\t\tstruct rte_mbuf *pkt,\n+\t\t\t\t\t\t__rte_unused uint32_t red)\n #endif\n {\n-\tstruct rte_sched_subport *s = port->subport + (qindex / rte_sched_port_queues_per_subport(port));\n-\tuint32_t tc_index = (qindex >> 2) & 0x3;\n+\tuint32_t tc_index = rte_mbuf_sched_traffic_class_get(pkt);\n \tuint32_t pkt_len = pkt->pkt_len;\n \n-\ts->stats.n_pkts_tc_dropped[tc_index] += 1;\n-\ts->stats.n_bytes_tc_dropped[tc_index] += pkt_len;\n+\tsubport->stats.n_pkts_tc_dropped[tc_index] += 1;\n+\tsubport->stats.n_bytes_tc_dropped[tc_index] += pkt_len;\n #ifdef RTE_SCHED_RED\n-\ts->stats.n_pkts_red_dropped[tc_index] += red;\n+\tsubport->stats.n_pkts_red_dropped[tc_index] += red;\n #endif\n }\n \n static inline void\n-rte_sched_port_update_queue_stats(struct rte_sched_port *port, uint32_t qindex, struct rte_mbuf *pkt)\n+rte_sched_port_update_queue_stats(struct rte_sched_subport *subport,\n+\tuint32_t qindex, struct rte_mbuf *pkt)\n {\n-\tstruct rte_sched_queue_extra *qe = port->queue_extra + qindex;\n+\tstruct rte_sched_queue_extra *qe = subport->queue_extra + qindex;\n \tuint32_t pkt_len = pkt->pkt_len;\n \n \tqe->stats.n_pkts += 1;\n@@ -1513,17 +1513,19 @@ rte_sched_port_update_queue_stats(struct rte_sched_port *port, uint32_t qindex,\n \n #ifdef RTE_SCHED_RED\n static inline void\n-rte_sched_port_update_queue_stats_on_drop(struct rte_sched_port *port,\n+rte_sched_port_update_queue_stats_on_drop(struct rte_sched_subport *subport,\n \t\t\t\t\t\tuint32_t qindex,\n-\t\t\t\t\t\tstruct rte_mbuf *pkt, uint32_t red)\n+\t\t\t\t\t\tstruct rte_mbuf *pkt,\n+\t\t\t\t\t\tint32_t red)\n #else\n static inline void\n-rte_sched_port_update_queue_stats_on_drop(struct rte_sched_port *port,\n+rte_sched_port_update_queue_stats_on_drop(struct rte_sched_subport *subport,\n \t\t\t\t\t\tuint32_t qindex,\n-\t\t\t\t\t\tstruct rte_mbuf *pkt, __rte_unused uint32_t red)\n+\t\t\t\t\t\tstruct rte_mbuf *pkt,\n+\t\t\t\t\t\t__rte_unused uint32_t red)\n #endif\n {\n-\tstruct rte_sched_queue_extra *qe = port->queue_extra + qindex;\n+\tstruct rte_sched_queue_extra *qe = subport->queue_extra + qindex;\n \tuint32_t pkt_len = pkt->pkt_len;\n \n \tqe->stats.n_pkts_dropped += 1;\n", "prefixes": [ "10/27" ] }