Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53518/?format=api
{ "id": 53518, "url": "https://patches.dpdk.org/api/patches/53518/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190517122220.31283-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190517122220.31283-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190517122220.31283-1-maxime.coquelin@redhat.com", "date": "2019-05-17T12:22:15", "name": "[0/5] vhost: I-cache pressure optimizations", "commit_ref": null, "pull_url": null, "state": null, "archived": false, "hash": null, "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190517122220.31283-1-maxime.coquelin@redhat.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/53518/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/53518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A40A25F3C;\n\tFri, 17 May 2019 14:22:41 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id C29335F34\n\tfor <dev@dpdk.org>; Fri, 17 May 2019 14:22:39 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4516CC049598;\n\tFri, 17 May 2019 12:22:31 +0000 (UTC)", "from localhost.localdomain (ovpn-112-59.ams2.redhat.com\n\t[10.36.112.59])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 637E3100203C;\n\tFri, 17 May 2019 12:22:23 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, jfreimann@redhat.com,\n\tzhihong.wang@intel.com, bruce.richardson@intel.com,\n\tkonstantin.ananyev@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Fri, 17 May 2019 14:22:15 +0200", "Message-Id": "<20190517122220.31283-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]); Fri, 17 May 2019 12:22:33 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 0/5] vhost: I-cache pressure optimizations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some OVS-DPDK PVP benchmarks show a performance drop\nwhen switching from DPDK v17.11 to v18.11.\n\nWith the addition of packed ring layout support,\nrte_vhost_enqueue_burst and rte_vhost_dequeue_burst\nbecame very large, and only a part of the instructions\nare executed (either packed or split ring used).\n\nThis series aims at improving the I-cache pressure,\nfirst by un-inlining split and packed rings, but\nalso by moving parts considered as cold in dedicated\nfunctions (dirty page logging, fragmented descriptors\nbuffer management added for CVE-2018-1059).\n\nWith the series applied, size of the enqueue and\ndequeue split paths is reduced significantly:\n\n+---------+--------------------+---------------------+\n| Version | Enqueue split path | Dequeue split path |\n+---------+--------------------+---------------------+\n| v19.05 | 16461B | 25521B |\n| +series | 7286B | 11285B |\n+---------+--------------------+---------------------+\n\nUsing perf tool to monitor iTLB-load-misses event\nwhile doing PVP benchmark with testpmd as vswitch,\nwe can see the number of iTLB misses being reduced:\n\n- v19.05:\n# perf stat --repeat 10 -C 2,3 -e iTLB-load-miss -- sleep 10\n\n Performance counter stats for 'CPU(s) 2,3' (10 runs):\n\n 2,438 iTLB-load-miss ( +- 13.43% )\n\n 10.00058928 +- 0.00000336 seconds time elapsed ( +- 0.00% )\n\n- +series:\n# perf stat --repeat 10 -C 2,3 -e iTLB-load-miss -- sleep 10\n\n Performance counter stats for 'CPU(s) 2,3' (10 runs):\n\n 55 iTLB-load-miss ( +- 10.08% )\n\n 10.00059466 +- 0.00000283 seconds time elapsed ( +- 0.00% )\n\nThe series also force the inlining of some rte_memcpy\nhelpers, as by adding packed ring support, some of them\nwere not more inlined but embedded as functions in\nthe virtio_net object file, which was not expected.\n\nFinally, the series simplifies the descriptors buffers\nprefetching, by doing it in the recently introduced\ndescriptor buffer mapping function.\n\nMaxime Coquelin (4):\n vhost: un-inline dirty pages logging functions\n vhost: do not inline packed and split functions\n vhost: do not inline unlikely fragmented buffers code\n vhost: simplify descriptor's buffer prefetching\n\nroot (1):\n eal/x86: force inlining of all memcpy and mov helpers\n\n .../common/include/arch/x86/rte_memcpy.h | 18 +-\n lib/librte_vhost/vhost.c | 165 ++++++++++++++++++\n lib/librte_vhost/vhost.h | 164 ++---------------\n lib/librte_vhost/virtio_net.c | 142 +++++++--------\n 4 files changed, 250 insertions(+), 239 deletions(-)", "diff": null, "prefixes": [ "0/5" ] }