Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53346/?format=api
https://patches.dpdk.org/api/patches/53346/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1557389028-2462-1-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1557389028-2462-1-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1557389028-2462-1-git-send-email-david.marchand@redhat.com", "date": "2019-05-09T08:03:48", "name": "net/virtio: remove useless check on mempool", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d22ad05af2ccc71a502bf657a7e2e54ac76b0f39", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1557389028-2462-1-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 4614, "url": "https://patches.dpdk.org/api/series/4614/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4614", "date": "2019-05-09T08:03:48", "name": "net/virtio: remove useless check on mempool", "version": 1, "mbox": "https://patches.dpdk.org/series/4614/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53346/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/53346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DD4A33977;\n\tThu, 9 May 2019 10:07:24 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 268922082;\n\tThu, 9 May 2019 10:07:23 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 74415307EA8F;\n\tThu, 9 May 2019 08:07:22 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.205.200])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AA93C600C5;\n\tThu, 9 May 2019 08:07:18 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tTiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>", "Date": "Thu, 9 May 2019 10:03:48 +0200", "Message-Id": "<1557389028-2462-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.44]); Thu, 09 May 2019 08:07:22 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH] net/virtio: remove useless check on mempool", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This .rx_queue_setup devop is called after ethdev already dereferenced\nthe mempool pointer.\nNo need to check and we can remove this rte_exit.\n\nFixes: 48cec290a3d2 (\"net/virtio: move queue configure code to proper place\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/virtio/virtio_rxtx.c | 5 -----\n 1 file changed, 5 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 8c56f23..4f44360 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -889,11 +889,6 @@\n \trxvq = &vq->rxq;\n \trxvq->queue_id = queue_idx;\n \trxvq->mpool = mp;\n-\tif (rxvq->mpool == NULL) {\n-\t\trte_exit(EXIT_FAILURE,\n-\t\t\t\"Cannot allocate mbufs for rx virtqueue\");\n-\t}\n-\n \tdev->data->rx_queues[queue_idx] = rxvq;\n \n \treturn 0;\n", "prefixes": [] }{ "id": 53346, "url": "