Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53331/?format=api
{ "id": 53331, "url": "https://patches.dpdk.org/api/patches/53331/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1557349352-26070-1-git-send-email-drc@linux.vnet.ibm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1557349352-26070-1-git-send-email-drc@linux.vnet.ibm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1557349352-26070-1-git-send-email-drc@linux.vnet.ibm.com", "date": "2019-05-08T21:02:32", "name": "[v3,3/4] test: change memory barrier variables to uint64_t", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a7caf90d447bee8e62d7dc81515f56ffc50311d4", "submitter": { "id": 1256, "url": "https://patches.dpdk.org/api/people/1256/?format=api", "name": "David Christensen", "email": "drc@linux.vnet.ibm.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1557349352-26070-1-git-send-email-drc@linux.vnet.ibm.com/mbox/", "series": [ { "id": 4602, "url": "https://patches.dpdk.org/api/series/4602/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4602", "date": "2019-05-08T21:02:08", "name": "[v3,1/4] test: fix typo in print statement", "version": 3, "mbox": "https://patches.dpdk.org/series/4602/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53331/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/53331/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C1C284C90;\n\tWed, 8 May 2019 23:02:41 +0200 (CEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 6CFB64C8F\n\tfor <dev@dpdk.org>; Wed, 8 May 2019 23:02:40 +0200 (CEST)", "from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx48Kr5ve033862 for <dev@dpdk.org>; Wed, 8 May 2019 17:02:39 -0400", "from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2sc5j7u1xt-1\n\t(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)\n\tfor <dev@dpdk.org>; Wed, 08 May 2019 17:02:38 -0400", "from localhost\n\tby e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <dev@dpdk.org> from <drc@linux.vnet.ibm.com>;\n\tWed, 8 May 2019 22:02:37 +0100", "from b01cxnp23032.gho.pok.ibm.com (9.57.198.27)\n\tby e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\t(version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256)\n\tWed, 8 May 2019 22:02:35 +0100", "from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com\n\t[9.57.199.107])\n\tby b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid x48L2YER37879914\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Wed, 8 May 2019 21:02:34 GMT", "from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 94481124053;\n\tWed, 8 May 2019 21:02:34 +0000 (GMT)", "from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 66772124052;\n\tWed, 8 May 2019 21:02:34 +0000 (GMT)", "from oprom9.localdomain (unknown [9.40.204.34])\n\tby b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP;\n\tWed, 8 May 2019 21:02:34 +0000 (GMT)" ], "From": "David Christensen <drc@linux.vnet.ibm.com>", "To": "dev@dpdk.org", "Cc": "David Christensen <drc@linux.vnet.ibm.com>", "Date": "Wed, 8 May 2019 16:02:32 -0500", "X-Mailer": "git-send-email 1.8.3.1", "X-TM-AS-GCONF": "00", "x-cbid": "19050821-0064-0000-0000-000003DBB949", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00011072; HX=3.00000242; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000285; SDB=6.01200514; UDB=6.00629910;\n\tIPR=6.00981401; \n\tMB=3.00026797; MTD=3.00000008; XFM=3.00000015; UTC=2019-05-08 21:02:36", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "19050821-0065-0000-0000-00003D651C98", "Message-Id": "<1557349352-26070-1-git-send-email-drc@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-05-08_12:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0\n\tmlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1810050000 definitions=main-1905080127", "Subject": "[dpdk-dev] [PATCH v3 3/4] test: change memory barrier variables to\n\tuint64_t", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Memory barrier failures can be intermittent. Increase the size of the\nsum/val/iteration variables to allow tests that can run for days so that\nsporadic errors can be identified.\n\nSigned-off-by: David Christensen <drc@linux.vnet.ibm.com>\n---\nv2:\n* Removed change to ITER_MAX\nv3:\n* None\n---\n app/test/test_barrier.c | 23 ++++++++++++-----------\n 1 file changed, 12 insertions(+), 11 deletions(-)", "diff": "diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c\nindex ae37b1e..a0b4704 100644\n--- a/app/test/test_barrier.c\n+++ b/app/test/test_barrier.c\n@@ -55,8 +55,8 @@ struct plock {\n */\n struct plock_test {\n \tstruct plock lock;\n-\tuint32_t val;\n-\tuint32_t iter;\n+\tuint64_t val;\n+\tuint64_t iter;\n };\n \n /*\n@@ -65,8 +65,8 @@ struct plock_test {\n */\n struct lcore_plock_test {\n \tstruct plock_test *pt[2]; /* shared, lock-protected data */\n-\tuint32_t sum[2]; /* local copy of the shared data */\n-\tuint32_t iter; /* number of iterations to perfom */\n+\tuint64_t sum[2]; /* local copy of the shared data */\n+\tuint64_t iter; /* number of iterations to perfom */\n \tuint32_t lc; /* given lcore id */\n };\n \n@@ -130,7 +130,8 @@ struct lcore_plock_test {\n plock_test1_lcore(void *data)\n {\n \tuint64_t tm;\n-\tuint32_t i, lc, ln, n;\n+\tuint32_t lc, ln;\n+\tuint64_t i, n;\n \tstruct lcore_plock_test *lpt;\n \n \tlpt = data;\n@@ -166,9 +167,9 @@ struct lcore_plock_test {\n \n \ttm = rte_get_timer_cycles() - tm;\n \n-\tprintf(\"%s(%u): %u iterations finished, in %\" PRIu64\n+\tprintf(\"%s(%u): %\" PRIu64 \" iterations finished, in %\" PRIu64\n \t\t\" cycles, %#Lf cycles/iteration, \"\n-\t\t\"local sum={%u, %u}\\n\",\n+\t\t\"local sum={%\" PRIu64 \", %\" PRIu64 \"}\\n\",\n \t\t__func__, lc, i, tm, (long double)tm / i,\n \t\tlpt->sum[0], lpt->sum[1]);\n \treturn 0;\n@@ -184,11 +185,11 @@ struct lcore_plock_test {\n * and local data are the same.\n */\n static int\n-plock_test(uint32_t iter, enum plock_use_type utype)\n+plock_test(uint64_t iter, enum plock_use_type utype)\n {\n \tint32_t rc;\n \tuint32_t i, lc, n;\n-\tuint32_t *sum;\n+\tuint64_t *sum;\n \tstruct plock_test *pt;\n \tstruct lcore_plock_test *lpt;\n \n@@ -199,7 +200,7 @@ struct lcore_plock_test {\n \tlpt = calloc(n, sizeof(*lpt));\n \tsum = calloc(n + 1, sizeof(*sum));\n \n-\tprintf(\"%s(iter=%u, utype=%u) started on %u lcores\\n\",\n+\tprintf(\"%s(iter=%\" PRIu64 \", utype=%u) started on %u lcores\\n\",\n \t\t__func__, iter, utype, n);\n \n \tif (pt == NULL || lpt == NULL || sum == NULL) {\n@@ -247,7 +248,7 @@ struct lcore_plock_test {\n \n \trc = 0;\n \tfor (i = 0; i != n; i++) {\n-\t\tprintf(\"%s: sum[%u]=%u, pt[%u].val=%u, pt[%u].iter=%u;\\n\",\n+\t\tprintf(\"%s: sum[%u]=%\" PRIu64 \", pt[%u].val=%\" PRIu64 \", pt[%u].iter=%\" PRIu64 \";\\n\",\n \t\t\t__func__, i, sum[i], i, pt[i].val, i, pt[i].iter);\n \n \t\t/* race condition occurred, lock doesn't work properly */\n", "prefixes": [ "v3", "3/4" ] }