Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53289,
    "url": "https://patches.dpdk.org/api/patches/53289/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190506085632.13861-1-alialnu@mellanox.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190506085632.13861-1-alialnu@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190506085632.13861-1-alialnu@mellanox.com",
    "date": "2019-05-06T08:56:55",
    "name": "examples/ip_fragmentation: fix Tx queues init",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "01822cae286b87f658e61451c7a84fe10dd388c8",
    "submitter": {
        "id": 969,
        "url": "https://patches.dpdk.org/api/people/969/?format=api",
        "name": "Ali Alnubani",
        "email": "alialnu@mellanox.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190506085632.13861-1-alialnu@mellanox.com/mbox/",
    "series": [
        {
            "id": 4574,
            "url": "https://patches.dpdk.org/api/series/4574/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4574",
            "date": "2019-05-06T08:56:55",
            "name": "examples/ip_fragmentation: fix Tx queues init",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/4574/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/53289/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/53289/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1EC71343C;\n\tMon,  6 May 2019 10:56:58 +0200 (CEST)",
            "from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00071.outbound.protection.outlook.com [40.107.0.71])\n\tby dpdk.org (Postfix) with ESMTP id 09456239;\n\tMon,  6 May 2019 10:56:57 +0200 (CEST)",
            "from DB6PR0501MB2167.eurprd05.prod.outlook.com (10.168.58.144) by\n\tDB6PR0501MB2278.eurprd05.prod.outlook.com (10.168.56.153) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1856.14; Mon, 6 May 2019 08:56:55 +0000",
            "from DB6PR0501MB2167.eurprd05.prod.outlook.com\n\t([fe80::d827:c945:ca7e:a04b]) by\n\tDB6PR0501MB2167.eurprd05.prod.outlook.com\n\t([fe80::d827:c945:ca7e:a04b%2]) with mapi id 15.20.1856.012;\n\tMon, 6 May 2019 08:56:55 +0000"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=NLzAFl8VPvGH8KRgd3bCzmPA0SzWdazoWkXGeJFzZ+g=;\n\tb=BVTqHat/kPekBgtybxnPVNN3cq5qmnUpD/kYfMKeohGPZoZ+p8ICvEM0DvrcF1QNyiyq8oSNiSWY4rIXnyvc7EtyCWX9csTgEMFgc+/VR+rApY3LGOq6pXPYAkPG7NjVN/vLzb0AhroBVgAKJ8+Nb2bFxq0KVLdOoE8OrOULUyQ=",
        "From": "Ali Alnubani <alialnu@mellanox.com>",
        "To": "\"konstantin.ananyev@intel.com\" <konstantin.ananyev@intel.com>",
        "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"stable@dpdk.org\" <stable@dpdk.org>",
        "Thread-Topic": "[PATCH] examples/ip_fragmentation: fix Tx queues init",
        "Thread-Index": "AQHVA+mn2MiduEe32E2VlqJScyneMQ==",
        "Date": "Mon, 6 May 2019 08:56:55 +0000",
        "Message-ID": "<20190506085632.13861-1-alialnu@mellanox.com>",
        "Accept-Language": "en-US",
        "Content-Language": "en-US",
        "X-MS-Has-Attach": "",
        "X-MS-TNEF-Correlator": "",
        "x-mailer": "git-send-email 2.19.2",
        "x-clientproxiedby": "LO2P265CA0451.GBRP265.PROD.OUTLOOK.COM\n\t(2603:10a6:600:e::31) To DB6PR0501MB2167.eurprd05.prod.outlook.com\n\t(2603:10a6:4:51::16)",
        "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=alialnu@mellanox.com; ",
        "x-ms-exchange-messagesentrepresentingtype": "1",
        "x-originating-ip": "[37.142.13.130]",
        "x-ms-publictraffictype": "Email",
        "x-ms-office365-filtering-correlation-id": "76ea9dc3-ef62-423c-f696-08d6d200ca3c",
        "x-ms-office365-filtering-ht": "Tenant",
        "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);\n\tSRVR:DB6PR0501MB2278; ",
        "x-ms-traffictypediagnostic": "DB6PR0501MB2278:",
        "x-microsoft-antispam-prvs": "<DB6PR0501MB22781C721EC73685BD6BFC0DD7300@DB6PR0501MB2278.eurprd05.prod.outlook.com>",
        "x-ms-oob-tlc-oobclassifiers": "OLM:1148;",
        "x-forefront-prvs": "0029F17A3F",
        "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(376002)(39860400002)(136003)(346002)(396003)(366004)(189003)(199004)(7736002)(54906003)(6916009)(6506007)(1076003)(102836004)(6486002)(316002)(26005)(6512007)(66476007)(2351001)(25786009)(486006)(73956011)(66446008)(66556008)(64756008)(36756003)(66946007)(305945005)(476003)(2501003)(81156014)(50226002)(53936002)(6116002)(5660300002)(8936002)(256004)(478600001)(86362001)(2616005)(8676002)(3846002)(52116002)(2906002)(5640700003)(99286004)(186003)(6436002)(14454004)(81166006)(66066001)(68736007)(71190400001)(71200400001)(4326008)(386003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2278;\n\tH:DB6PR0501MB2167.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; MX:1; A:1; ",
        "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)",
        "x-ms-exchange-senderadcheck": "1",
        "x-microsoft-antispam-message-info": "fxDLsS/0lv5F7gWs1hK7CyfEZxSoIZxdxIs4ZyLdxch7kG+Xn8GAJT654ABxmsNpaWvRIOxzcDAPQV+ygLGmqPNiz2VlYr58sXoAesjBgSUrCUN+zwp7X0lKLOmQMShEjZIK7FFwUbNcyZ+KsHzSSFgYBRHwAQNedSyJcaT4VaMEBulfPsDei+mQL7QRQYblj1IjwLJ02BYSDctNJqaErUDrCCQKo5l2Aqd7dhbMHHCci/mNRwVxnAFQn/oRICtO9J4SHM/2h+mLbmhnvHzkfZcvkya1V5wfxLZ7LjcqcKKwPg8ZKVIZAvxlwxfgy42T/d2bFi1zfLc4u0JwOrRfCdfKMu0Sy12wlQrY2nC8m2xk+Xxv4CdwNsyosHcieDwMj9ZEQWWlUotHKwxbmrekzGk7eN4GptiGwrfDPwEP3PI=",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "base64",
        "MIME-Version": "1.0",
        "X-OriginatorOrg": "Mellanox.com",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "76ea9dc3-ef62-423c-f696-08d6d200ca3c",
        "X-MS-Exchange-CrossTenant-originalarrivaltime": "06 May 2019 08:56:55.8693\n\t(UTC)",
        "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
        "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
        "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB6PR0501MB2278",
        "Subject": "[dpdk-dev] [PATCH] examples/ip_fragmentation: fix Tx queues init",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The application tries to configure queue ids larger\nthan the maximum allowed by MAX_TX_QUEUE_PER_PORT. This\ncauses the startup error:\n\n\"\n  ...\n  Initializing port 0 on lcore 0... Address:7C:FE:90:12:23:0D\n  txq=0,0 txq=1,1 txq=2,2 txq=3,3 txq=4,4 txq=5,5 txq=6,6 txq=7,7 txq=8,8\n  txq=9,9 txq=10,10 txq=11,11 txq=12,12 txq=13,13 txq=14,14 txq=15,15\n  txq=16,16 Invalid TX queue_id=16\n\n  EAL: Error - exiting with code: 1\n    Cause: rte_eth_tx_queue_setup: err=-22, port=0\n\"\n\nThe error reproduces when lcores aren't set, and when the\nmachine has more than 16 cores.\n\nFixes: af75078fece3 (\"first public release\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ali Alnubani <alialnu@mellanox.com>\n---\n examples/ip_fragmentation/main.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c\r\nindex e90a61e35..953115aba 100644\r\n--- a/examples/ip_fragmentation/main.c\r\n+++ b/examples/ip_fragmentation/main.c\r\n@@ -984,6 +984,9 @@ main(int argc, char **argv)\r\n \t\t\tif (rte_lcore_is_enabled(lcore_id) == 0)\r\n \t\t\t\tcontinue;\r\n \r\n+\t\t\tif (queueid >= rte_eth_devices[portid].data->nb_tx_queues)\r\n+\t\t\t\tbreak;\r\n+\r\n \t\t\tsocket = (int) rte_lcore_to_socket_id(lcore_id);\r\n \t\t\tprintf(\"txq=%u,%d \", lcore_id, queueid);\r\n \t\t\tfflush(stdout);\r\n",
    "prefixes": []
}