Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53276,
    "url": "https://patches.dpdk.org/api/patches/53276/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190505054528.133534-1-xiao.w.wang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190505054528.133534-1-xiao.w.wang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190505054528.133534-1-xiao.w.wang@intel.com",
    "date": "2019-05-05T05:45:28",
    "name": "net/ice: minor code cleanups",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2edb39efc704375d35593a0b852cbd2962e24909",
    "submitter": {
        "id": 281,
        "url": "https://patches.dpdk.org/api/people/281/?format=api",
        "name": "Xiao Wang",
        "email": "xiao.w.wang@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "https://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190505054528.133534-1-xiao.w.wang@intel.com/mbox/",
    "series": [
        {
            "id": 4566,
            "url": "https://patches.dpdk.org/api/series/4566/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4566",
            "date": "2019-05-05T05:45:28",
            "name": "net/ice: minor code cleanups",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/4566/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/53276/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/53276/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 23E732082;\n\tSun,  5 May 2019 08:01:20 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 1A5AA1041\n\tfor <dev@dpdk.org>; Sun,  5 May 2019 08:01:18 +0200 (CEST)",
            "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 May 2019 23:01:18 -0700",
            "from dpdk-xiao-1.sh.intel.com ([10.67.111.145])\n\tby fmsmga007.fm.intel.com with ESMTP; 04 May 2019 23:01:16 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,431,1549958400\"; d=\"scan'208\";a=\"148514862\"",
        "From": "Xiao Wang <xiao.w.wang@intel.com>",
        "To": "wenzhuo.lu@intel.com",
        "Cc": "dev@dpdk.org, qiming.yang@intel.com, Xiao Wang <xiao.w.wang@intel.com>",
        "Date": "Sun,  5 May 2019 13:45:28 +0800",
        "Message-Id": "<20190505054528.133534-1-xiao.w.wang@intel.com>",
        "X-Mailer": "git-send-email 2.15.1",
        "Subject": "[dpdk-dev] [PATCH] net/ice: minor code cleanups",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch is a cleanup on comment, variable modifier, coding style.\n\nSigned-off-by: Xiao Wang <xiao.w.wang@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 1f06a2c80..706632424 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -1587,7 +1587,7 @@ ice_dev_uninit(struct rte_eth_dev *dev)\n \t/* disable uio intr before callback unregister */\n \trte_intr_disable(intr_handle);\n \n-\t/* register callback func to eal lib */\n+\t/* unregister callback func from eal lib */\n \trte_intr_callback_unregister(intr_handle,\n \t\t\t\t     ice_interrupt_handler, dev);\n \n@@ -2125,7 +2125,7 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev,\n }\n \n static int\n-ice_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete)\n+ice_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n {\n #define CHECK_INTERVAL 100  /* 100ms */\n #define MAX_REPEAT_TIME 10  /* 1s (10 * 100ms) in total */\n@@ -2502,7 +2502,7 @@ ice_vlan_tpid_set(struct rte_eth_dev *dev,\n \t\t\treg_id = 3;\n \t\telse\n \t\t\treg_id = 5;\n-\tbreak;\n+\t\tbreak;\n \tcase ETH_VLAN_TYPE_INNER:\n \t\tif (qinq) {\n \t\t\treg_id = 5;\n",
    "prefixes": []
}