Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53274/?format=api
{ "id": 53274, "url": "https://patches.dpdk.org/api/patches/53274/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190504140910.8935-1-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190504140910.8935-1-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190504140910.8935-1-qi.z.zhang@intel.com", "date": "2019-05-04T14:09:10", "name": "net/iavf: enable more link speed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c824f0880349e9e37e9a32c7527ff060a1edb99c", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190504140910.8935-1-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 4564, "url": "https://patches.dpdk.org/api/series/4564/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4564", "date": "2019-05-04T14:09:10", "name": "net/iavf: enable more link speed", "version": 1, "mbox": "https://patches.dpdk.org/series/4564/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53274/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/53274/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 011851041;\n\tSat, 4 May 2019 16:07:08 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id C9475B62;\n\tSat, 4 May 2019 16:07:05 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 May 2019 07:07:04 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby fmsmga005.fm.intel.com with ESMTP; 04 May 2019 07:07:03 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,430,1549958400\"; d=\"scan'208\";a=\"343397406\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\twei.zhao1@intel.com", "Cc": "paul.m.stillwell.jr@intel.com, dev@dpdk.org,\n\tQi Zhang <qi.z.zhang@intel.com>, stable@dpdk.org", "Date": "Sat, 4 May 2019 22:09:10 +0800", "Message-Id": "<20190504140910.8935-1-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "Subject": "[dpdk-dev] [PATCH] net/iavf: enable more link speed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Enable advanced link speed mode (VIRTCHNL_VF_CAP_ADV_LINK_SPEED) so iavf\nPMD can identify more link speed that reported by pf.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/iavf/base/virtchnl.h | 17 ++++++++++++++++-\n drivers/net/iavf/iavf.h | 2 +-\n drivers/net/iavf/iavf_ethdev.c | 21 +++++++++++++++------\n drivers/net/iavf/iavf_vchnl.c | 4 ++--\n 4 files changed, 34 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/iavf/base/virtchnl.h b/drivers/net/iavf/base/virtchnl.h\nindex 13bfdb86b..10b65380c 100644\n--- a/drivers/net/iavf/base/virtchnl.h\n+++ b/drivers/net/iavf/base/virtchnl.h\n@@ -258,6 +258,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);\n #define VIRTCHNL_VF_OFFLOAD_ENCAP\t\t0X00100000\n #define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM\t\t0X00200000\n #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM\t0X00400000\n+/* Define below the capability flags that are not offloads */\n+#define VIRTCHNL_VF_CAP_ADV_LINK_SPEED 0x00000080\n \n #define VF_BASE_MODE_OFFLOADS (VIRTCHNL_VF_OFFLOAD_L2 | \\\n \t\t\t VIRTCHNL_VF_OFFLOAD_VLAN | \\\n@@ -562,10 +564,23 @@ enum virtchnl_event_codes {\n struct virtchnl_pf_event {\n \tenum virtchnl_event_codes event;\n \tunion {\n+\t\t/* If the PF driver does not support the new speed reporting\n+\t\t * capabilities then use link_event else use link_event_adv to\n+\t\t * get the speed and link information. The ability to understand\n+\t\t * new speeds is indicated by setting the capability flag\n+\t\t * VIRTCHNL_VF_CAP_ADV_LINK_SPEED in vf_cap_flags parameter\n+\t\t * in virtchnl_vf_resource struct and can be used to determine\n+\t\t * which link event struct to use below.\n+\t\t */\n \t\tstruct {\n \t\t\tenum virtchnl_link_speed link_speed;\n-\t\t\tbool link_status;\n+\t\t\tu8 link_status;\n \t\t} link_event;\n+\t\tstruct {\n+\t\t\t/* link_speed provided in Mbps */\n+\t\t\tu32 link_speed;\n+\t\t\tu8 link_status;\n+\t\t} link_event_adv;\n \t} event_data;\n \n \tint severity;\ndiff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h\nindex e6e3e8d30..9a334e41c 100644\n--- a/drivers/net/iavf/iavf.h\n+++ b/drivers/net/iavf/iavf.h\n@@ -95,7 +95,7 @@ struct iavf_info {\n \t/* Event from pf */\n \tbool dev_closed;\n \tbool link_up;\n-\tenum virtchnl_link_speed link_speed;\n+\tuint32_t link_speed;\n \n \tstruct iavf_vsi vsi;\n \tbool vf_reset;\ndiff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 7a0696ed7..bd9c5ecdf 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -584,24 +584,33 @@ iavf_dev_link_update(struct rte_eth_dev *dev,\n \t * when receive LINK_CHANGE evnet from PF by Virtchnnl.\n \t */\n \tswitch (vf->link_speed) {\n-\tcase VIRTCHNL_LINK_SPEED_100MB:\n+\tcase 10:\n+\t\tnew_link.link_speed = ETH_SPEED_NUM_10M;\n+\t\tbreak;\n+\tcase 100:\n \t\tnew_link.link_speed = ETH_SPEED_NUM_100M;\n \t\tbreak;\n-\tcase VIRTCHNL_LINK_SPEED_1GB:\n+\tcase 1000:\n \t\tnew_link.link_speed = ETH_SPEED_NUM_1G;\n \t\tbreak;\n-\tcase VIRTCHNL_LINK_SPEED_10GB:\n+\tcase 10000:\n \t\tnew_link.link_speed = ETH_SPEED_NUM_10G;\n \t\tbreak;\n-\tcase VIRTCHNL_LINK_SPEED_20GB:\n+\tcase 20000:\n \t\tnew_link.link_speed = ETH_SPEED_NUM_20G;\n \t\tbreak;\n-\tcase VIRTCHNL_LINK_SPEED_25GB:\n+\tcase 25000:\n \t\tnew_link.link_speed = ETH_SPEED_NUM_25G;\n \t\tbreak;\n-\tcase VIRTCHNL_LINK_SPEED_40GB:\n+\tcase 40000:\n \t\tnew_link.link_speed = ETH_SPEED_NUM_40G;\n \t\tbreak;\n+\tcase 50000:\n+\t\tnew_link.link_speed = ETH_SPEED_NUM_50G;\n+\t\tbreak;\n+\tcase 100000:\n+\t\tnew_link.link_speed = ETH_SPEED_NUM_100G;\n+\t\tbreak;\n \tdefault:\n \t\tnew_link.link_speed = ETH_SPEED_NUM_NONE;\n \t\tbreak;\ndiff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c\nindex 6381fb63c..da6401d35 100644\n--- a/drivers/net/iavf/iavf_vchnl.c\n+++ b/drivers/net/iavf/iavf_vchnl.c\n@@ -153,7 +153,7 @@ iavf_handle_pf_event_msg(struct rte_eth_dev *dev, uint8_t *msg,\n \tcase VIRTCHNL_EVENT_LINK_CHANGE:\n \t\tPMD_DRV_LOG(DEBUG, \"VIRTCHNL_EVENT_LINK_CHANGE event\");\n \t\tvf->link_up = pf_msg->event_data.link_event.link_status;\n-\t\tvf->link_speed = pf_msg->event_data.link_event.link_speed;\n+\t\tvf->link_speed = pf_msg->event_data.link_event_adv.link_speed;\n \t\tiavf_dev_link_update(dev, 0);\n \t\t_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC,\n \t\t\t\t\t NULL);\n@@ -344,7 +344,7 @@ iavf_get_vf_resource(struct iavf_adapter *adapter)\n \t * add advanced/optional offload capabilities\n \t */\n \n-\tcaps = IAVF_BASIC_OFFLOAD_CAPS;\n+\tcaps = IAVF_BASIC_OFFLOAD_CAPS | VIRTCHNL_VF_CAP_ADV_LINK_SPEED;\n \n \targs.in_args = (uint8_t *)∩︀\n \targs.in_args_size = sizeof(caps);\n", "prefixes": [] }