Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53259,
    "url": "https://patches.dpdk.org/api/patches/53259/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190503153539.17993-1-thomas@monjalon.net/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190503153539.17993-1-thomas@monjalon.net>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190503153539.17993-1-thomas@monjalon.net",
    "date": "2019-05-03T15:35:39",
    "name": "ipc: replace bool checks with explicit non-zero",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2423c495d82925bab11d4ecb4e0038cb4267320a",
    "submitter": {
        "id": 685,
        "url": "https://patches.dpdk.org/api/people/685/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas@monjalon.net"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190503153539.17993-1-thomas@monjalon.net/mbox/",
    "series": [
        {
            "id": 4557,
            "url": "https://patches.dpdk.org/api/series/4557/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4557",
            "date": "2019-05-03T15:35:39",
            "name": "ipc: replace bool checks with explicit non-zero",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/4557/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/53259/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/53259/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8D0B85F13;\n\tFri,  3 May 2019 17:36:01 +0200 (CEST)",
            "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n\t[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id AC9392C6A\n\tfor <dev@dpdk.org>; Fri,  3 May 2019 17:36:00 +0200 (CEST)",
            "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 4269E20D84;\n\tFri,  3 May 2019 11:36:00 -0400 (EDT)",
            "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Fri, 03 May 2019 11:36:00 -0400",
            "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 2D635103D9;\n\tFri,  3 May 2019 11:35:59 -0400 (EDT)"
        ],
        "DKIM-Signature": [
            "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding; s=mesmtp; bh=FH+r3n4+Pqtp2oIu4MFtobW\n\tz/w6pR3zDNfGXIWGOvL4=; b=JSDYPdEGg5G8pOXwXclyktAObP9Igz29WbnZmij\n\tCCwtCrieVopTJkQOjeOWRy0e56g9KxDhx9EK6WcxA8C+bIF0qno1HU0QBZFx3EDE\n\tFkhOWtoa8kETHEwhQxfcnExleiQfL/ECc2OP7ErhLKPYTlcF3U/WCrTv/GBDi3Ij\n\tOl2I=",
            "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:message-id:mime-version:subject:to:x-me-proxy:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=FH+r3n4+Pqtp2oIu4\n\tMFtobWz/w6pR3zDNfGXIWGOvL4=; b=eOj5EHKJ+Am9m0rqoqBjeVRRmbWGTri+f\n\tBYDlNbgpUU1ZTJDJpDYMHebXkpEWc0GhBLdCCqIAWKGS45y5W3qST2kf2QkHLbqy\n\tVr03cCBtPWwuEuttrbVNlZ+oTDouHr5gvEoEc0Nm/BgytiBbpq0aS3VjaY2HjOGx\n\tB3ZXYkVFxj8WQ/SuQ4qWE5CTsBR+niQAwd7n7nOKq2q4IiQSLmdxLMaQnJ3LuHHf\n\t8V9/fTjP3LKUspk2HNIDZWbCZBx9S/rFldeOy5gExKWIXXYNsWuvASEjbjVCDM4H\n\tokJYZPG3f7kUITSJXz86xBkU8v9fWSW7JPVmnIyyNZsQezBIzeb6g=="
        ],
        "X-ME-Sender": "<xms:31_MXGHjiE3NWFDJTzNH9PtFnFg1YRE7dVpORsFEYfOecxvZM4yDYQ>",
        "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduuddrjedugdelhecutefuodetggdotefrodftvf\n\tcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n\tuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertdertd\n\tdtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhn\n\tjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrg\n\thmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhu\n\tshhtvghrufhiiigvpedt",
        "X-ME-Proxy": "<xmx:31_MXCEHKhM0gLJn2Ck3u1ysaeMxjJaQXy1qmpfrp8o-ivEYyEl90w>\n\t<xmx:31_MXPB-WyhjWFpMZ1cdFda8_QOINUBEBHi7i2lE_VqIsOf14xEhvA>\n\t<xmx:31_MXG0FiSTn7109kK3xYjn5RPNE5pA3liIYhFE3u7dF0M4eKMyYTQ>\n\t<xmx:4F_MXLSG3jQkd4HjGDkwTPxxkeEFDWM1_U9sOibTH2FGm3K562IZHQ>",
        "From": "Thomas Monjalon <thomas@monjalon.net>",
        "To": "anatoly.burakov@intel.com",
        "Cc": "dev@dpdk.org",
        "Date": "Fri,  3 May 2019 17:35:39 +0200",
        "Message-Id": "<20190503153539.17993-1-thomas@monjalon.net>",
        "X-Mailer": "git-send-email 2.21.0",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH] ipc: replace bool checks with explicit non-zero",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The function check_input() was returning a bool as error code.\nIt is changed to return an int, semantically more correct.\nWhile at it, make checks of validate_action_name() return\nexplicit as described in the coding guidelines.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/librte_eal/common/eal_common_proc.c | 30 ++++++++++++-------------\n 1 file changed, 15 insertions(+), 15 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex d098803b1..d23728604 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -202,7 +202,7 @@ rte_mp_action_register(const char *name, rte_mp_t action)\n {\n \tstruct action_entry *entry;\n \n-\tif (validate_action_name(name))\n+\tif (validate_action_name(name) != 0)\n \t\treturn -1;\n \n \tentry = malloc(sizeof(struct action_entry));\n@@ -230,7 +230,7 @@ rte_mp_action_unregister(const char *name)\n {\n \tstruct action_entry *entry;\n \n-\tif (validate_action_name(name))\n+\tif (validate_action_name(name) != 0)\n \t\treturn;\n \n \tpthread_mutex_lock(&mp_mutex_action);\n@@ -749,50 +749,50 @@ mp_send(struct rte_mp_msg *msg, const char *peer, int type)\n \treturn ret;\n }\n \n-static bool\n+static int\n check_input(const struct rte_mp_msg *msg)\n {\n \tif (msg == NULL) {\n \t\tRTE_LOG(ERR, EAL, \"Msg cannot be NULL\\n\");\n \t\trte_errno = EINVAL;\n-\t\treturn false;\n+\t\treturn -1;\n \t}\n \n-\tif (validate_action_name(msg->name))\n-\t\treturn false;\n+\tif (validate_action_name(msg->name) != 0)\n+\t\treturn -1;\n \n \tif (msg->len_param < 0) {\n \t\tRTE_LOG(ERR, EAL, \"Message data length is negative\\n\");\n \t\trte_errno = EINVAL;\n-\t\treturn false;\n+\t\treturn -1;\n \t}\n \n \tif (msg->num_fds < 0) {\n \t\tRTE_LOG(ERR, EAL, \"Number of fd's is negative\\n\");\n \t\trte_errno = EINVAL;\n-\t\treturn false;\n+\t\treturn -1;\n \t}\n \n \tif (msg->len_param > RTE_MP_MAX_PARAM_LEN) {\n \t\tRTE_LOG(ERR, EAL, \"Message data is too long\\n\");\n \t\trte_errno = E2BIG;\n-\t\treturn false;\n+\t\treturn -1;\n \t}\n \n \tif (msg->num_fds > RTE_MP_MAX_FD_NUM) {\n \t\tRTE_LOG(ERR, EAL, \"Cannot send more than %d FDs\\n\",\n \t\t\tRTE_MP_MAX_FD_NUM);\n \t\trte_errno = E2BIG;\n-\t\treturn false;\n+\t\treturn -1;\n \t}\n \n-\treturn true;\n+\treturn 0;\n }\n \n int __rte_experimental\n rte_mp_sendmsg(struct rte_mp_msg *msg)\n {\n-\tif (!check_input(msg))\n+\tif (check_input(msg) != 0)\n \t\treturn -1;\n \n \tRTE_LOG(DEBUG, EAL, \"sendmsg: %s\\n\", msg->name);\n@@ -946,7 +946,7 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,\n \treply->nb_received = 0;\n \treply->msgs = NULL;\n \n-\tif (check_input(req) == false)\n+\tif (check_input(req) != 0)\n \t\tgoto err;\n \n \tif (internal_config.no_shconf) {\n@@ -1040,7 +1040,7 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,\n \n \tRTE_LOG(DEBUG, EAL, \"request: %s\\n\", req->name);\n \n-\tif (check_input(req) == false)\n+\tif (check_input(req) != 0)\n \t\treturn -1;\n \n \tif (internal_config.no_shconf) {\n@@ -1177,7 +1177,7 @@ rte_mp_reply(struct rte_mp_msg *msg, const char *peer)\n {\n \tRTE_LOG(DEBUG, EAL, \"reply: %s\\n\", msg->name);\n \n-\tif (check_input(msg) == false)\n+\tif (check_input(msg) != 0)\n \t\treturn -1;\n \n \tif (peer == NULL) {\n",
    "prefixes": []
}