Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53223/?format=api
{ "id": 53223, "url": "https://patches.dpdk.org/api/patches/53223/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/3a54a27536a425c608c826f79b642f5f203fc3dd.1556809050.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<3a54a27536a425c608c826f79b642f5f203fc3dd.1556809050.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3a54a27536a425c608c826f79b642f5f203fc3dd.1556809050.git.dekelp@mellanox.com", "date": "2019-05-02T15:01:54", "name": "[v2,1/4] net/mlx5: remove unused functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "48689c2daa834ab89b6259a631211a199bce09be", "submitter": { "id": 1082, "url": "https://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 6624, "url": "https://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/3a54a27536a425c608c826f79b642f5f203fc3dd.1556809050.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 4545, "url": "https://patches.dpdk.org/api/series/4545/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4545", "date": "2019-05-02T15:01:53", "name": "net/mlx5: code cleanup in rx and tx files", "version": 2, "mbox": "https://patches.dpdk.org/series/4545/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53223/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/53223/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B1F091B113;\n\tThu, 2 May 2019 17:04:51 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id D83046CC1\n\tfor <dev@dpdk.org>; Thu, 2 May 2019 17:04:50 +0200 (CEST)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tdekelp@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 2 May 2019 18:04:47 +0300", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n\t[10.128.130.87])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x42F4ilT009153;\n\tThu, 2 May 2019 18:04:47 +0300" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "yskoh@mellanox.com, shahafs@mellanox.com", "Cc": "dev@dpdk.org", "Date": "Thu, 2 May 2019 18:01:54 +0300", "Message-Id": "<3a54a27536a425c608c826f79b642f5f203fc3dd.1556809050.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<cover.1556809050.git.dekelp@mellanox.com>", "References": "<cover.1556534247.git.dekelp@mellanox.com>\n\t<cover.1556809050.git.dekelp@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Functions implemented but never called:\nmlx5_rxq_ibv_releasable()\nmlx5_rxq_cleanup()\nmlx5_txq_ibv_releasable()\n\nFunction declared but not implemented:\nrxq_alloc_mprq_buf()\n\nThis patch removes these functions from code and header file.\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 31 -------------------------------\n drivers/net/mlx5/mlx5_rxtx.h | 4 ----\n drivers/net/mlx5/mlx5_txq.c | 13 -------------\n 3 files changed, 48 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 54438a4..db8c340 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -368,24 +368,6 @@\n }\n \n /**\n- * Clean up a RX queue.\n- *\n- * Destroy objects, free allocated memory and reset the structure for reuse.\n- *\n- * @param rxq_ctrl\n- * Pointer to RX queue structure.\n- */\n-void\n-mlx5_rxq_cleanup(struct mlx5_rxq_ctrl *rxq_ctrl)\n-{\n-\tDRV_LOG(DEBUG, \"port %u cleaning up Rx queue %u\",\n-\t\tPORT_ID(rxq_ctrl->priv), rxq_ctrl->rxq.idx);\n-\tif (rxq_ctrl->ibv)\n-\t\tmlx5_rxq_ibv_release(rxq_ctrl->ibv);\n-\tmemset(rxq_ctrl, 0, sizeof(*rxq_ctrl));\n-}\n-\n-/**\n * Returns the per-queue supported offloads.\n *\n * @param dev\n@@ -1131,19 +1113,6 @@ struct mlx5_rxq_ibv *\n }\n \n /**\n- * Return true if a single reference exists on the object.\n- *\n- * @param rxq_ibv\n- * Verbs Rx queue object.\n- */\n-int\n-mlx5_rxq_ibv_releasable(struct mlx5_rxq_ibv *rxq_ibv)\n-{\n-\tassert(rxq_ibv);\n-\treturn (rte_atomic32_read(&rxq_ibv->refcnt) == 1);\n-}\n-\n-/**\n * Callback function to initialize mbufs for Multi-Packet RQ.\n */\n static inline void\ndiff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h\nindex 0d88375..1732e32 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.h\n+++ b/drivers/net/mlx5/mlx5_rxtx.h\n@@ -251,7 +251,6 @@ struct mlx5_txq_ctrl {\n int mlx5_mprq_enabled(struct rte_eth_dev *dev);\n int mlx5_mprq_free_mp(struct rte_eth_dev *dev);\n int mlx5_mprq_alloc_mp(struct rte_eth_dev *dev);\n-void mlx5_rxq_cleanup(struct mlx5_rxq_ctrl *rxq_ctrl);\n int mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n \t\t\tunsigned int socket, const struct rte_eth_rxconf *conf,\n \t\t\tstruct rte_mempool *mp);\n@@ -263,7 +262,6 @@ int mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n struct mlx5_rxq_ibv *mlx5_rxq_ibv_new(struct rte_eth_dev *dev, uint16_t idx);\n struct mlx5_rxq_ibv *mlx5_rxq_ibv_get(struct rte_eth_dev *dev, uint16_t idx);\n int mlx5_rxq_ibv_release(struct mlx5_rxq_ibv *rxq_ibv);\n-int mlx5_rxq_ibv_releasable(struct mlx5_rxq_ibv *rxq_ibv);\n struct mlx5_rxq_ibv *mlx5_rxq_ibv_drop_new(struct rte_eth_dev *dev);\n void mlx5_rxq_ibv_drop_release(struct rte_eth_dev *dev);\n int mlx5_rxq_ibv_verify(struct rte_eth_dev *dev);\n@@ -276,7 +274,6 @@ struct mlx5_rxq_ctrl *mlx5_rxq_new(struct rte_eth_dev *dev, uint16_t idx,\n int mlx5_rxq_releasable(struct rte_eth_dev *dev, uint16_t idx);\n int mlx5_rxq_verify(struct rte_eth_dev *dev);\n int rxq_alloc_elts(struct mlx5_rxq_ctrl *rxq_ctrl);\n-int rxq_alloc_mprq_buf(struct mlx5_rxq_ctrl *rxq_ctrl);\n struct mlx5_ind_table_ibv *mlx5_ind_table_ibv_new(struct rte_eth_dev *dev,\n \t\t\t\t\t\t const uint16_t *queues,\n \t\t\t\t\t\t uint32_t queues_n);\n@@ -314,7 +311,6 @@ int mlx5_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n struct mlx5_txq_ibv *mlx5_txq_ibv_new(struct rte_eth_dev *dev, uint16_t idx);\n struct mlx5_txq_ibv *mlx5_txq_ibv_get(struct rte_eth_dev *dev, uint16_t idx);\n int mlx5_txq_ibv_release(struct mlx5_txq_ibv *txq_ibv);\n-int mlx5_txq_ibv_releasable(struct mlx5_txq_ibv *txq_ibv);\n int mlx5_txq_ibv_verify(struct rte_eth_dev *dev);\n struct mlx5_txq_ctrl *mlx5_txq_new(struct rte_eth_dev *dev, uint16_t idx,\n \t\t\t\t uint16_t desc, unsigned int socket,\ndiff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c\nindex 0b6c247..2cdb1d3 100644\n--- a/drivers/net/mlx5/mlx5_txq.c\n+++ b/drivers/net/mlx5/mlx5_txq.c\n@@ -668,19 +668,6 @@ struct mlx5_txq_ibv *\n }\n \n /**\n- * Return true if a single reference exists on the object.\n- *\n- * @param txq_ibv\n- * Verbs Tx queue object.\n- */\n-int\n-mlx5_txq_ibv_releasable(struct mlx5_txq_ibv *txq_ibv)\n-{\n-\tassert(txq_ibv);\n-\treturn (rte_atomic32_read(&txq_ibv->refcnt) == 1);\n-}\n-\n-/**\n * Verify the Verbs Tx queue list is empty\n *\n * @param dev\n", "prefixes": [ "v2", "1/4" ] }