Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53154/?format=api
https://patches.dpdk.org/api/patches/53154/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1556530816-423522-1-git-send-email-yipeng1.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1556530816-423522-1-git-send-email-yipeng1.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1556530816-423522-1-git-send-email-yipeng1.wang@intel.com", "date": "2019-04-29T09:40:16", "name": "doc: fix rte_hash_hash comment for ambiguity", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e9aec8f909f891eb26a0a19598cdc15a1fbba354", "submitter": { "id": 754, "url": "https://patches.dpdk.org/api/people/754/?format=api", "name": "Wang, Yipeng1", "email": "yipeng1.wang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1556530816-423522-1-git-send-email-yipeng1.wang@intel.com/mbox/", "series": [ { "id": 4508, "url": "https://patches.dpdk.org/api/series/4508/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4508", "date": "2019-04-29T09:40:16", "name": "doc: fix rte_hash_hash comment for ambiguity", "version": 1, "mbox": "https://patches.dpdk.org/series/4508/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53154/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/53154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AE2C98E76;\n\tMon, 29 Apr 2019 20:03:24 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id DE3B17D52\n\tfor <dev@dpdk.org>; Mon, 29 Apr 2019 20:03:22 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Apr 2019 11:03:21 -0700", "from skx-blue.jf.intel.com ([10.54.80.170])\n\tby orsmga008.jf.intel.com with ESMTP; 29 Apr 2019 11:03:21 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,410,1549958400\"; d=\"scan'208\";a=\"138476074\"", "From": "Yipeng Wang <yipeng1.wang@intel.com>", "To": "yipeng1.wang@intel.com, pablo.de.lara.guarch@intel.com,\n\tgentoorion@gmail.com, anatoly.burakov@intel.com", "Cc": "dev@dpdk.org", "Date": "Mon, 29 Apr 2019 02:40:16 -0700", "Message-Id": "<1556530816-423522-1-git-send-email-yipeng1.wang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_hash_hash is multi-thread safe but not multi-process safe\nbecause of the use of function pointers. Previous document\nand comment says the other way around. This commit fixes\nthe issue.\n\nFixes: fc1f2750a3ec (\"doc: programmers guide\")\nFixes: 48a399119619 (\"hash: replace with cuckoo hash implementation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yipeng Wang <yipeng1.wang@intel.com>\nSuggested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nReported-by: Andrey Nikolaev <gentoorion@gmail.com>\n---\n doc/guides/prog_guide/multi_proc_support.rst | 2 +-\n lib/librte_hash/rte_hash.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst\nindex 1384fe3..761fca9 100644\n--- a/doc/guides/prog_guide/multi_proc_support.rst\n+++ b/doc/guides/prog_guide/multi_proc_support.rst\n@@ -176,7 +176,7 @@ Some of these are documented below:\n \n * The use of function pointers between multiple processes running based of different compiled binaries is not supported,\n since the location of a given function in one process may be different to its location in a second.\n- This prevents the librte_hash library from behaving properly as in a multi-threaded instance,\n+ This prevents the librte_hash library from behaving properly as in a multi-process instance,\n since it uses a pointer to the hash function internally.\n \n To work around this issue, it is recommended that multi-process applications perform the hash calculations by directly calling\ndiff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h\nindex c93d1a1..abba8d7 100644\n--- a/lib/librte_hash/rte_hash.h\n+++ b/lib/librte_hash/rte_hash.h\n@@ -463,7 +463,7 @@ rte_hash_lookup_with_hash(const struct rte_hash *h,\n \n /**\n * Calc a hash value by key.\n- * This operation is not multi-thread safe.\n+ * This operation is not multi-process safe.\n *\n * @param h\n * Hash table to look in.\n", "prefixes": [] }{ "id": 53154, "url": "