Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53107,
    "url": "https://patches.dpdk.org/api/patches/53107/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190426162230.21158-1-ktraynor@redhat.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190426162230.21158-1-ktraynor@redhat.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190426162230.21158-1-ktraynor@redhat.com",
    "date": "2019-04-26T16:22:30",
    "name": "vfio: expand non-viable group error message",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "0165d35e7c2bf0efe48ebff0afbb689b2e4c3ff9",
    "submitter": {
        "id": 598,
        "url": "https://patches.dpdk.org/api/people/598/?format=api",
        "name": "Kevin Traynor",
        "email": "ktraynor@redhat.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190426162230.21158-1-ktraynor@redhat.com/mbox/",
    "series": [
        {
            "id": 4484,
            "url": "https://patches.dpdk.org/api/series/4484/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4484",
            "date": "2019-04-26T16:22:30",
            "name": "vfio: expand non-viable group error message",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/4484/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/53107/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/53107/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 27C301B736;\n\tFri, 26 Apr 2019 18:22:46 +0200 (CEST)",
            "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 278C41B6EF\n\tfor <dev@dpdk.org>; Fri, 26 Apr 2019 18:22:44 +0200 (CEST)",
            "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8D63D30A74FC;\n\tFri, 26 Apr 2019 16:22:43 +0000 (UTC)",
            "from rh.redhat.com (ovpn-117-19.ams2.redhat.com [10.36.117.19])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7EDE15D717;\n\tFri, 26 Apr 2019 16:22:42 +0000 (UTC)"
        ],
        "From": "Kevin Traynor <ktraynor@redhat.com>",
        "To": "anatoly.burakov@intel.com,\n\tdev@dpdk.org",
        "Cc": "Kevin Traynor <ktraynor@redhat.com>",
        "Date": "Fri, 26 Apr 2019 17:22:30 +0100",
        "Message-Id": "<20190426162230.21158-1-ktraynor@redhat.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15",
        "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.45]); Fri, 26 Apr 2019 16:22:43 +0000 (UTC)",
        "Subject": "[dpdk-dev] [PATCH] vfio: expand non-viable group error message",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "\"VFIO group is not viable\" error message is correct\nbut not very user friendly for something which can\nusually be easily rectified.\n\nAdd some additional text to give more of a hint.\n\nSigned-off-by: Kevin Traynor <ktraynor@redhat.com>\n---\n lib/librte_eal/linux/eal/eal_vfio.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c\nindex 19e70bb66..6892a2c14 100644\n--- a/lib/librte_eal/linux/eal/eal_vfio.c\n+++ b/lib/librte_eal/linux/eal/eal_vfio.c\n@@ -686,5 +686,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,\n \t\treturn -1;\n \t} else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) {\n-\t\tRTE_LOG(ERR, EAL, \"  %s VFIO group is not viable!\\n\", dev_addr);\n+\t\tRTE_LOG(ERR, EAL, \"  %s VFIO group is not viable! \"\n+\t\t\t\t\"Not all devices in IOMMU group bound to VFIO or unbound\\n\",\n+\t\t\t\tdev_addr);\n \t\tclose(vfio_group_fd);\n \t\trte_vfio_clear_group(vfio_group_fd);\n",
    "prefixes": []
}