Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53094/?format=api
https://patches.dpdk.org/api/patches/53094/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190426050912.109813-3-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190426050912.109813-3-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190426050912.109813-3-xiaolong.ye@intel.com", "date": "2019-04-26T05:09:12", "name": "[v1,2/2] net/af_xdp: set MAC addrs field to NULL", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "91a86b36e265791082c6c7d928735dfea6a39218", "submitter": { "id": 1120, "url": "https://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190426050912.109813-3-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 4473, "url": "https://patches.dpdk.org/api/series/4473/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4473", "date": "2019-04-26T05:09:10", "name": "support RTE_ETH_DEV_CLOSE_REMOVE flag for AF_XDP", "version": 1, "mbox": "https://patches.dpdk.org/series/4473/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53094/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/53094/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B19061B5FB;\n\tFri, 26 Apr 2019 07:15:47 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 0CF501B5F5\n\tfor <dev@dpdk.org>; Fri, 26 Apr 2019 07:15:42 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Apr 2019 22:15:42 -0700", "from yexl-server.sh.intel.com ([10.67.110.206])\n\tby orsmga005.jf.intel.com with ESMTP; 25 Apr 2019 22:15:41 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,396,1549958400\"; d=\"scan'208\";a=\"319108859\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,\n\tThomas Monjalon <thomas@monjalon.net>", "Cc": "Xiaolong Ye <xiaolong.ye@intel.com>", "Date": "Fri, 26 Apr 2019 13:09:12 +0800", "Message-Id": "<20190426050912.109813-3-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190426050912.109813-1-xiaolong.ye@intel.com>", "References": "<20190426050912.109813-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 2/2] net/af_xdp: set MAC addrs field to NULL", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As af_xdp pmd doesn't allocate MAC addresses dynamically, it needs to be\nset as NULL, so it won't be released by rte_eth_dev_release_port(),\notherwise, there would be \"EAL: Error: Invalid memory\" error.\n\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/af_xdp/rte_eth_af_xdp.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex a12551cbf..f659c0496 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -458,6 +458,12 @@ eth_dev_close(struct rte_eth_dev *dev)\n \n \t(void)xsk_umem__delete(internals->umem->umem);\n \n+\t/*\n+\t * MAC is not allocated dynamically, setting it to NULL would prevent\n+\t * from releasing it in rte_eth_dev_release_port.\n+\t */\n+\tdev->data->mac_addrs = NULL;\n+\n \txdp_umem_destroy(internals->umem);\n \n \tremove_xdp_program(internals);\n", "prefixes": [ "v1", "2/2" ] }{ "id": 53094, "url": "