Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53083,
    "url": "https://patches.dpdk.org/api/patches/53083/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190425133456.23074-1-shreyansh.jain@nxp.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190425133456.23074-1-shreyansh.jain@nxp.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190425133456.23074-1-shreyansh.jain@nxp.com",
    "date": "2019-04-25T13:34:56",
    "name": "net/dpaa2: fix incorrect loop increment",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ff28e954f3ad6971df9a81cc9477850eba10d906",
    "submitter": {
        "id": 497,
        "url": "https://patches.dpdk.org/api/people/497/?format=api",
        "name": "Shreyansh Jain",
        "email": "shreyansh.jain@nxp.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190425133456.23074-1-shreyansh.jain@nxp.com/mbox/",
    "series": [
        {
            "id": 4468,
            "url": "https://patches.dpdk.org/api/series/4468/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4468",
            "date": "2019-04-25T13:34:56",
            "name": "net/dpaa2: fix incorrect loop increment",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/4468/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/53083/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/53083/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6A1271B59E;\n\tThu, 25 Apr 2019 15:45:06 +0200 (CEST)",
            "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n\tby dpdk.org (Postfix) with ESMTP id B93971B59B\n\tfor <dev@dpdk.org>; Thu, 25 Apr 2019 15:45:05 +0200 (CEST)",
            "from inva020.nxp.com (localhost [127.0.0.1])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 544CA1A0238;\n\tThu, 25 Apr 2019 15:45:05 +0200 (CEST)",
            "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 2671B1A02A7;\n\tThu, 25 Apr 2019 15:45:03 +0200 (CEST)",
            "from GDB1.ap.freescale.net (GDB1.ap.freescale.net [10.232.132.179])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 2FED9402DD;\n\tThu, 25 Apr 2019 21:44:59 +0800 (SGT)"
        ],
        "From": "Shreyansh Jain <shreyansh.jain@nxp.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com, Shreyansh Jain <shreyansh.jain@nxp.com>,\n\tsunil.kori@nxp.com",
        "Date": "Thu, 25 Apr 2019 19:04:56 +0530",
        "Message-Id": "<20190425133456.23074-1-shreyansh.jain@nxp.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "X-Virus-Scanned": "ClamAV using ClamSMTP",
        "Subject": "[dpdk-dev] [PATCH] net/dpaa2: fix incorrect loop increment",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Identified by LGTM, the loop was incorrectly incrementing a different\nvariable and conditional on another.\n\nFixes: fe2b986ac662 (\"net/dpaa2: support generic flow\")\nCc: sunil.kori@nxp.com\n\nSuggested-by: Ferruh Yigit <ferruh.yigit@intel.com>\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\n---\n drivers/net/dpaa2/dpaa2_flow.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c\nindex 98f68139b..9ef46d47e 100644\n--- a/drivers/net/dpaa2/dpaa2_flow.c\n+++ b/drivers/net/dpaa2/dpaa2_flow.c\n@@ -1734,7 +1734,7 @@ dpaa2_dev_verify_patterns(struct dpaa2_dev_priv *dev_priv,\n \t/* more\tthan DPKG_MAX_NUM_OF_EXTRACTS. Verify this limitation too. */\n \tfor (i = 0; pattern[i].type != RTE_FLOW_ITEM_TYPE_END; i++) {\n \t\tfor (j = 0; j < MAX_TCS + 1; j++) {\n-\t\t\t\tfor (k = 0; k < DPKG_MAX_NUM_OF_EXTRACTS; j++) {\n+\t\t\t\tfor (k = 0; k < DPKG_MAX_NUM_OF_EXTRACTS; k++) {\n \t\t\t\t\tif (dev_priv->pattern[j].pattern_type[k] == pattern[i].type)\n \t\t\t\t\t\tbreak;\n \t\t\t\t}\n",
    "prefixes": []
}