Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53066/?format=api
{ "id": 53066, "url": "https://patches.dpdk.org/api/patches/53066/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com", "date": "2019-04-24T16:34:38", "name": "eventdev: fix control flow issues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dd54c2cb0c6028cf1d688fbc2f120a4ee398fe02", "submitter": { "id": 883, "url": "https://patches.dpdk.org/api/people/883/?format=api", "name": "Gujjar, Abhinandan S", "email": "abhinandan.gujjar@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com/mbox/", "series": [ { "id": 4460, "url": "https://patches.dpdk.org/api/series/4460/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4460", "date": "2019-04-24T16:34:38", "name": "eventdev: fix control flow issues", "version": 1, "mbox": "https://patches.dpdk.org/series/4460/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53066/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/53066/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 73A831B564;\n\tThu, 25 Apr 2019 11:11:09 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 30F171B562\n\tfor <dev@dpdk.org>; Thu, 25 Apr 2019 11:11:07 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Apr 2019 02:11:07 -0700", "from unknown (HELO localhost.localdomain) ([10.224.122.195])\n\tby fmsmga001.fm.intel.com with ESMTP; 25 Apr 2019 02:11:05 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,393,1549958400\"; d=\"scan'208\";a=\"167790716\"", "From": "Abhinandan Gujjar <abhinandan.gujjar@intel.com>", "To": "jerin.jacob@caviumnetworks.com,\n\tdev@dpdk.org", "Cc": "narender.vangati@intel.com, abhinandan.gujjar@intel.com,\n\tjohn.mcnamara@intel.com", "Date": "Wed, 24 Apr 2019 22:04:38 +0530", "Message-Id": "<1556123678-80860-1-git-send-email-abhinandan.gujjar@intel.com>", "X-Mailer": "git-send-email 1.9.1", "Subject": "[dpdk-dev] [PATCH] eventdev: fix control flow issues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes null pointer dereference and control\nflow issues reported in event crypto adapter by coverity\n\nCoverity issue: 279439 Dereference null return value\nCoverity issue: 279446 Logically dead code\nCoverity issue: 279450 Logically dead code\nCoverity issue: 279462 Logically dead code\nFixes: 7901eac3409 (\"eventdev: add crypto adapter implementation\")\n\nSigned-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>\n---\n lib/librte_eventdev/rte_event_crypto_adapter.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c\nindex 11b28ca..5faf3c9 100644\n--- a/lib/librte_eventdev/rte_event_crypto_adapter.c\n+++ b/lib/librte_eventdev/rte_event_crypto_adapter.c\n@@ -159,6 +159,9 @@ struct crypto_queue_pair_info {\n \tstruct rte_event_port_conf *port_conf = arg;\n \tstruct rte_event_crypto_adapter *adapter = eca_id_to_adapter(id);\n \n+\tif (adapter == NULL)\n+\t\treturn -EINVAL;\n+\n \tdev = &rte_eventdevs[adapter->eventdev_id];\n \tdev_conf = dev->data->dev_conf;\n \n@@ -353,7 +356,7 @@ struct crypto_queue_pair_info {\n \t\t\tcdev_id = m_data->request_info.cdev_id;\n \t\t\tqp_id = m_data->request_info.queue_pair_id;\n \t\t\tqp_info = &adapter->cdevs[cdev_id].qpairs[qp_id];\n-\t\t\tif (qp_info == NULL) {\n+\t\t\tif (!qp_info->qp_enabled) {\n \t\t\t\trte_pktmbuf_free(crypto_op->sym->m_src);\n \t\t\t\trte_crypto_op_free(crypto_op);\n \t\t\t\tcontinue;\n@@ -369,7 +372,7 @@ struct crypto_queue_pair_info {\n \t\t\tcdev_id = m_data->request_info.cdev_id;\n \t\t\tqp_id = m_data->request_info.queue_pair_id;\n \t\t\tqp_info = &adapter->cdevs[cdev_id].qpairs[qp_id];\n-\t\t\tif (qp_info == NULL) {\n+\t\t\tif (!qp_info->qp_enabled) {\n \t\t\t\trte_pktmbuf_free(crypto_op->sym->m_src);\n \t\t\t\trte_crypto_op_free(crypto_op);\n \t\t\t\tcontinue;\n@@ -427,10 +430,9 @@ struct crypto_queue_pair_info {\n \tret = 0;\n \tfor (cdev_id = 0; cdev_id < num_cdev; cdev_id++) {\n \t\tcurr_dev = &adapter->cdevs[cdev_id];\n-\t\tif (curr_dev == NULL)\n-\t\t\tcontinue;\n \t\tdev = curr_dev->dev;\n-\n+\t\tif (dev == NULL)\n+\t\t\tcontinue;\n \t\tfor (qp = 0; qp < dev->data->nb_queue_pairs; qp++) {\n \n \t\t\tcurr_queue = &curr_dev->qpairs[qp];\n@@ -579,9 +581,9 @@ struct crypto_queue_pair_info {\n \t\tfor (cdev_id = adapter->next_cdev_id;\n \t\t\tcdev_id < num_cdev; cdev_id++) {\n \t\t\tcurr_dev = &adapter->cdevs[cdev_id];\n-\t\t\tif (curr_dev == NULL)\n-\t\t\t\tcontinue;\n \t\t\tdev = curr_dev->dev;\n+\t\t\tif (dev == NULL)\n+\t\t\t\tcontinue;\n \t\t\tdev_qps = dev->data->nb_queue_pairs;\n \n \t\t\tfor (qp = curr_dev->next_queue_pair_id;\n", "prefixes": [] }