Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53063/?format=api
{ "id": 53063, "url": "https://patches.dpdk.org/api/patches/53063/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1556170955-40555-1-git-send-email-nikhil.rao@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1556170955-40555-1-git-send-email-nikhil.rao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1556170955-40555-1-git-send-email-nikhil.rao@intel.com", "date": "2019-04-25T05:42:35", "name": "[v3] eventdev: add experimental tag back", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "36c29e87fcc8b9e5ce7c5c2c311fa6262b1238c7", "submitter": { "id": 528, "url": "https://patches.dpdk.org/api/people/528/?format=api", "name": "Rao, Nikhil", "email": "nikhil.rao@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1556170955-40555-1-git-send-email-nikhil.rao@intel.com/mbox/", "series": [ { "id": 4457, "url": "https://patches.dpdk.org/api/series/4457/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4457", "date": "2019-04-25T05:42:35", "name": "[v3] eventdev: add experimental tag back", "version": 3, "mbox": "https://patches.dpdk.org/series/4457/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/53063/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/53063/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B39022C54;\n\tThu, 25 Apr 2019 07:43:29 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id DED4BA49\n\tfor <dev@dpdk.org>; Thu, 25 Apr 2019 07:43:26 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Apr 2019 22:43:25 -0700", "from unknown (HELO broadwell-dev-4.localdomain) ([10.224.122.193])\n\tby orsmga002.jf.intel.com with ESMTP; 24 Apr 2019 22:43:23 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,392,1549958400\"; d=\"scan'208\";a=\"153579206\"", "From": "Nikhil Rao <nikhil.rao@intel.com>", "To": "thomas@monjalon.net", "Cc": "dev@dpdk.org,\n\tNikhil Rao <nikhil.rao@intel.com>,\n\tjerinj@marvell.com", "Date": "Thu, 25 Apr 2019 11:12:35 +0530", "Message-Id": "<1556170955-40555-1-git-send-email-nikhil.rao@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1555998614-35566-1-git-send-email-nikhil.rao@intel.com>", "References": "<1555998614-35566-1-git-send-email-nikhil.rao@intel.com>", "Subject": "[dpdk-dev] [PATCH v3] eventdev: add experimental tag back", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add the experimental tag back to the Rx event adapter callback,\nthe Rx event callback register and the Rx event adapter statistics\nretrieval functions due to API change to be proposed in a\nfuture patch.\n\nThis patch also adds the experimental tag to these\nfunction definition and adds the functions to the EXPERIMENTAL\nsection of the map file, these were missing previously.\n\nFixes: 80bdf91dc8ee (\"eventdev: promote adapter functions as stable\")\nCc: jerinj@marvell.com\n\nSigned-off-by: Nikhil Rao <nikhil.rao@intel.com>\n---\n\nv3:\n* add experimental tag to the Rx event adapter stats retrieval function\n\nv2:\n* add patch explanation to commit message\n\n lib/librte_eventdev/rte_event_eth_rx_adapter.c | 11 ++++++-----\n lib/librte_eventdev/rte_event_eth_rx_adapter.h | 17 +++++++++++++++--\n lib/librte_eventdev/rte_eventdev_version.map | 8 +++++++-\n 3 files changed, 28 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c\nindex 8d178be..27e0fe7 100644\n--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c\n+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c\n@@ -2296,7 +2296,7 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,\n \treturn rxa_ctrl(id, 0);\n }\n \n-int\n+int __rte_experimental\n rte_event_eth_rx_adapter_stats_get(uint8_t id,\n \t\t\t struct rte_event_eth_rx_adapter_stats *stats)\n {\n@@ -2383,10 +2383,11 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,\n \treturn rx_adapter->service_inited ? 0 : -ESRCH;\n }\n \n-int rte_event_eth_rx_adapter_cb_register(uint8_t id,\n-\t\t\t\t\tuint16_t eth_dev_id,\n-\t\t\t\t\trte_event_eth_rx_adapter_cb_fn cb_fn,\n-\t\t\t\t\tvoid *cb_arg)\n+int __rte_experimental\n+rte_event_eth_rx_adapter_cb_register(uint8_t id,\n+\t\t\t\tuint16_t eth_dev_id,\n+\t\t\t\trte_event_eth_rx_adapter_cb_fn cb_fn,\n+\t\t\t\tvoid *cb_arg)\n {\n \tstruct rte_event_eth_rx_adapter *rx_adapter;\n \tstruct eth_device_info *dev_info;\ndiff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h\nindex cf23cde..176f8ca 100644\n--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h\n+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h\n@@ -173,6 +173,9 @@ struct rte_event_eth_rx_adapter_queue_conf {\n };\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n * A structure used to retrieve statistics for an eth rx adapter instance.\n */\n struct rte_event_eth_rx_adapter_stats {\n@@ -201,6 +204,9 @@ struct rte_event_eth_rx_adapter_stats {\n };\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n * Callback function invoked by the SW adapter before it continues\n * to process packets. The callback is passed the size of the enqueue\n * buffer in the SW adapter and the occupancy of the buffer. The\n@@ -392,6 +398,9 @@ int rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t eth_dev_id,\n int rte_event_eth_rx_adapter_stop(uint8_t id);\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n * Retrieve statistics for an adapter\n *\n * @param id\n@@ -404,7 +413,8 @@ int rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t eth_dev_id,\n * - 0: Success, retrieved successfully.\n * - <0: Error code on failure.\n */\n-int rte_event_eth_rx_adapter_stats_get(uint8_t id,\n+int __rte_experimental\n+rte_event_eth_rx_adapter_stats_get(uint8_t id,\n \t\t\t\tstruct rte_event_eth_rx_adapter_stats *stats);\n \n /**\n@@ -437,6 +447,9 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,\n int rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id);\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n * Register callback to process Rx packets, this is supported for\n * SW based packet transfers.\n * @see rte_event_eth_rx_cb_fn\n@@ -453,7 +466,7 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,\n * - 0: Success\n * - <0: Error code on failure.\n */\n-int\n+int __rte_experimental\n rte_event_eth_rx_adapter_cb_register(uint8_t id,\n \t\t\t\tuint16_t eth_dev_id,\n \t\t\t\trte_event_eth_rx_adapter_cb_fn cb_fn,\ndiff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map\nindex 88c3ce5..55c56e3 100644\n--- a/lib/librte_eventdev/rte_eventdev_version.map\n+++ b/lib/librte_eventdev/rte_eventdev_version.map\n@@ -63,7 +63,6 @@ DPDK_17.11 {\n \trte_event_eth_rx_adapter_queue_del;\n \trte_event_eth_rx_adapter_service_id_get;\n \trte_event_eth_rx_adapter_start;\n-\trte_event_eth_rx_adapter_stats_get;\n \trte_event_eth_rx_adapter_stats_reset;\n \trte_event_eth_rx_adapter_stop;\n } DPDK_17.08;\n@@ -124,3 +123,10 @@ DPDK_19.05 {\n \trte_event_timer_arm_tmo_tick_burst;\n \trte_event_timer_cancel_burst;\n } DPDK_18.05;\n+\n+EXPERIMENTAL {\n+\tglobal:\n+\n+\trte_event_eth_rx_adapter_cb_register;\n+\trte_event_eth_rx_adapter_stats_get;\n+};\n", "prefixes": [ "v3" ] }