Patch Comment List
List patch comments
GET /api/patches/53/comments/?format=api
[ { "id": 515, "web_url": "https://patches.dpdk.org/comment/515/", "msgid": "<2954869.Rz44bk6IQk@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/2954869.Rz44bk6IQk@xps13", "date": "2014-08-27T15:42:02", "subject": "Re: [dpdk-dev] [PATCH 3/3] ethdev: improvements for some macro\n\tdefinition in head file", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-07-18 10:45, Helin Zhang:\n> improvements for some macro definition about RSS packet\n> classification types in rte_ethdev.h.\n[...]\n> -#define ETH_RSS_IPV4 ((uint16_t)1 << ETH_RSS_IPV4_SHIFT)\n[...]\n> +#define ETH_RSS_IPV4 (1 << ETH_RSS_IPV4_SHIFT)\n\nPlease explain your change in the commit log.\nIn general, the log should answer to these questions:\n\twhat was the problem?\n\twhen the problem was introduced?\n\twhy it's better now?\n\nThanks", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-wi0-f173.google.com (mail-wi0-f173.google.com\n\t[209.85.212.173]) by dpdk.org (Postfix) with ESMTP id CA823B379\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 17:38:06 +0200 (CEST)", "by mail-wi0-f173.google.com with SMTP id f8so6029491wiw.12\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 08:42:10 -0700 (PDT)", "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tgk17sm24980689wic.16.2014.08.27.08.42.07 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Aug 2014 08:42:08 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=5ceJyFpBMC+1Rg0jf5e5fuSsAaRH9oo8LaQ+V6FMttQ=;\n\tb=A7BMkzpRGC/MDUlASdxs6yEd9Rlbb1p4FEQIyo6y8T7JWTUEHfekDjPHfvBA3e8Ltz\n\tCo/fbQXwuXYJxszDSCCzOqOkRadyZfu3Co6B6KQS0qeTJQKA7wbZjApwXpV7qgqtlf0p\n\tvnPcJnS2RnKvIpXX/l2MTsi5EVhLqGvVn9TazF+zOUhhnpbD4rP6edVMLekBuCY/9Wts\n\t/lMgS+WkHHVFXzw9mM8JqEWMDa17bFs2kDW809ELxmnB4zB2cyEh+o/WR+cGa71/I6C8\n\tnKB26+Mi84RAHsjpFziHlbxUbBGqWAddLB6XjcFhQV5YihkdUMoNovBOpUyk318KLwI3\n\t58oA==", "X-Gm-Message-State": "ALoCoQlspx+cMqOQuL8e9mo8ZT8VseFxjFc1+kbzHf5frFAZ7wOQEjuVXJ5j5K4klOvrus+kzrio", "X-Received": "by 10.194.243.230 with SMTP id xb6mr4542872wjc.100.1409154129080;\n\tWed, 27 Aug 2014 08:42:09 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Helin Zhang <helin.zhang@intel.com>", "Date": "Wed, 27 Aug 2014 17:42:02 +0200", "Message-ID": "<2954869.Rz44bk6IQk@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<1405651521-14545-4-git-send-email-helin.zhang@intel.com>", "References": "<1405651521-14545-1-git-send-email-helin.zhang@intel.com>\n\t<1405651521-14545-4-git-send-email-helin.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 3/3] ethdev: improvements for some macro\n\tdefinition in head file", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 27 Aug 2014 15:38:06 -0000" }, "addressed": null } ]