Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52978/?format=api
{ "id": 52978, "url": "https://patches.dpdk.org/api/patches/52978/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1555935668-81847-1-git-send-email-orika@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1555935668-81847-1-git-send-email-orika@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1555935668-81847-1-git-send-email-orika@mellanox.com", "date": "2019-04-22T12:21:08", "name": "net/mlx5: fix encapsulation action flags", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "92bff335dbb7ac785d0dc5d971856e9825e21edf", "submitter": { "id": 795, "url": "https://patches.dpdk.org/api/people/795/?format=api", "name": "Ori Kam", "email": "orika@mellanox.com" }, "delegate": { "id": 6624, "url": "https://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1555935668-81847-1-git-send-email-orika@mellanox.com/mbox/", "series": [ { "id": 4410, "url": "https://patches.dpdk.org/api/series/4410/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4410", "date": "2019-04-22T12:21:08", "name": "net/mlx5: fix encapsulation action flags", "version": 1, "mbox": "https://patches.dpdk.org/series/4410/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52978/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/52978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 038D91B426;\n\tMon, 22 Apr 2019 14:21:24 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 10AA81B20C\n\tfor <dev@dpdk.org>; Mon, 22 Apr 2019 14:21:21 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\torika@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 22 Apr 2019 15:21:18 +0300", "from pegasus04.mtr.labs.mlnx (pegasus04.mtr.labs.mlnx\n\t[10.210.16.126])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3MCLHfe019462;\n\tMon, 22 Apr 2019 15:21:17 +0300" ], "From": "Ori Kam <orika@mellanox.com>", "To": "yskoh@mellanox.com, shahafs@mellanox.com", "Cc": "dev@dpdk.org, orika@mellanox.com", "Date": "Mon, 22 Apr 2019 12:21:08 +0000", "Message-Id": "<1555935668-81847-1-git-send-email-orika@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix encapsulation action flags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When creating the encapsulation action using Direct Rules, we need to\nadd flags to mark, if the action will be done on root table or on\nprivate table.\n\nFixes: 4f84a19779ca (\"net/mlx5: add Direct Rules API\")\n\nSigned-off-by: Ori Kam <orika@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.h | 1 +\n drivers/net/mlx5/mlx5_flow_dv.c | 4 +++-\n 2 files changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex c419e6b..b665420 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -255,6 +255,7 @@ struct mlx5_flow_dv_modify_hdr_resource {\n \tuint32_t actions_num; /**< Number of modification actions. */\n \tstruct mlx5_modification_cmd actions[MLX5_MODIFY_NUM];\n \t/**< Modification actions. */\n+\tuint64_t flags; /**< Flags for RDMA API. */\n };\n \n /* Jump action resource structure. */\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 2f777ec..ffc6ab7 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1830,10 +1830,12 @@ struct field_modify_info modify_tcp[] = {\n \t\tns = sh->tx_ns;\n \telse\n \t\tns = sh->rx_ns;\n+\tresource->flags = dev_flow->flow->group ? 0 : 1;\n \t/* Lookup a matching resource from cache. */\n \tLIST_FOREACH(cache_resource, &sh->modify_cmds, next) {\n \t\tif (resource->ft_type == cache_resource->ft_type &&\n \t\t resource->actions_num == cache_resource->actions_num &&\n+\t\t resource->flags == cache_resource->flags &&\n \t\t !memcmp((const void *)resource->actions,\n \t\t\t (const void *)cache_resource->actions,\n \t\t\t (resource->actions_num *\n@@ -1856,7 +1858,7 @@ struct field_modify_info modify_tcp[] = {\n \tcache_resource->verbs_action =\n \t\tmlx5_glue->dv_create_flow_action_modify_header\n \t\t\t\t\t(sh->ctx, cache_resource->ft_type,\n-\t\t\t\t\t ns, 0,\n+\t\t\t\t\t ns, cache_resource->flags,\n \t\t\t\t\t cache_resource->actions_num *\n \t\t\t\t\t sizeof(cache_resource->actions[0]),\n \t\t\t\t\t (uint64_t *)cache_resource->actions);\n", "prefixes": [] }