Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52949/?format=api
{ "id": 52949, "url": "https://patches.dpdk.org/api/patches/52949/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1555621175-103437-1-git-send-email-eserra@vmware.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1555621175-103437-1-git-send-email-eserra@vmware.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1555621175-103437-1-git-send-email-eserra@vmware.com", "date": "2019-04-18T20:59:37", "name": "[v2] net/vmxnet3: v4 boot and guest UDP RSS configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "74a6bcb601f7595c8f06dbdc2c108aae1045cbcc", "submitter": { "id": 1271, "url": "https://patches.dpdk.org/api/people/1271/?format=api", "name": "Eduard Serra", "email": "eserra@vmware.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1555621175-103437-1-git-send-email-eserra@vmware.com/mbox/", "series": [ { "id": 4387, "url": "https://patches.dpdk.org/api/series/4387/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4387", "date": "2019-04-18T20:59:37", "name": "[v2] net/vmxnet3: v4 boot and guest UDP RSS configuration", "version": 2, "mbox": "https://patches.dpdk.org/series/4387/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52949/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/52949/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 374631BC15;\n\tThu, 18 Apr 2019 22:59:42 +0200 (CEST)", "from NAM04-SN1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr700052.outbound.protection.outlook.com [40.107.70.52])\n\tby dpdk.org (Postfix) with ESMTP id 4CEED1BBF7\n\tfor <dev@dpdk.org>; Thu, 18 Apr 2019 22:59:40 +0200 (CEST)", "from MWHPR05MB3472.namprd05.prod.outlook.com (10.174.248.35) by\n\tMWHPR05MB2815.namprd05.prod.outlook.com (10.168.245.9) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1835.7; Thu, 18 Apr 2019 20:59:38 +0000", "from MWHPR05MB3472.namprd05.prod.outlook.com\n\t([fe80::c0af:3553:570:5a48]) by\n\tMWHPR05MB3472.namprd05.prod.outlook.com\n\t([fe80::c0af:3553:570:5a48%2]) with mapi id 15.20.1813.009;\n\tThu, 18 Apr 2019 20:59:38 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=eLLbDlTL2wSFFyYolwxhUqBArbz0tBOjaNhw+8YOzIQ=;\n\tb=GxWcf2y5AXhUAl6sEAOBvddi6ZQ7Zq+2wpE0mRem++MNzdck2QDF6PGVEAFLuVW1+2fqhbI1B75NIwcVEhxNNYL2wOEvd1RGedH1UJeg5gAMx8Y57Y8iCO/zM9rjGaKuthS1IbmD3ibS6Mqy9ErV/15ziYvHSpHThSSDT4bNrmo=", "From": "Eduard Serra Miralles <eserra@vmware.com>", "To": "Yong Wang <yongwang@vmware.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Eduard Serra Miralles <eserra@vmware.com>", "Thread-Topic": "[PATCH v2] net/vmxnet3: v4 boot and guest UDP RSS configuration", "Thread-Index": "AQHU9imi32binNRvzEWZRAl/uqUcSg==", "Date": "Thu, 18 Apr 2019 20:59:37 +0000", "Message-ID": "<1555621175-103437-1-git-send-email-eserra@vmware.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BYAPR05CA0015.namprd05.prod.outlook.com\n\t(2603:10b6:a03:c0::28) To MWHPR05MB3472.namprd05.prod.outlook.com\n\t(2603:10b6:301:40::35)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=eserra@vmware.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.7.4", "x-originating-ip": "[66.170.99.2]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "35b4f3c9-cfc8-4773-5a0a-08d6c440c491", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020);\n\tSRVR:MWHPR05MB2815; ", "x-ms-traffictypediagnostic": "MWHPR05MB2815:", "x-microsoft-antispam-prvs": "<MWHPR05MB2815C649D884A2835345102DBD260@MWHPR05MB2815.namprd05.prod.outlook.com>", "x-forefront-prvs": "0011612A55", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(376002)(366004)(136003)(39860400002)(346002)(199004)(189003)(26005)(186003)(6506007)(386003)(8936002)(81156014)(81166006)(102836004)(256004)(8676002)(2616005)(25786009)(19627235002)(64756008)(66446008)(66946007)(14454004)(86362001)(478600001)(14444005)(36756003)(71200400001)(71190400001)(476003)(486006)(66066001)(4326008)(6862004)(99286004)(52116002)(68736007)(6512007)(107886003)(53936002)(7736002)(305945005)(6636002)(6486002)(97736004)(5660300002)(54906003)(50226002)(316002)(6436002)(6116002)(3846002)(37006003)(2906002)(66476007)(66556008);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB2815;\n\tH:MWHPR05MB3472.namprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "TWX1C3fsWH0SHNYHW6JhtqAclvH9UnitVVKar6stz7raFOHVz+TH5NYiOYBc7J1TpjUsZ9N42zO2HRqWHCsb0eorqzxtrayMzmVkfU8K+U0V3xhj2uM8mNEwk6K5ECMHCo3iJWQR+O6VSfp1gqYMI/xlLPhqqBdmoM9RDYT2UeszGC0XiKSOPMI2d3iwT6hhqeKTP5nm1QqonEl7CsEIOO1KiQy/PnWPLRU6dcdBBksi0kEuhCSyNCF/oVsTFyuAZhF4L5vHQzBaahCfxkx1+39dN3Ir6PpAj68LDk0DV4x2s52oSttPKOeQ1ZIrR1bYWgfjbjzAJyo3FPsAkWa2BFDGb8itX2etY4e3Zh8HSTVUI1T1IDE7aEw3PBo57+PykFozgPblrJfbVYmkgXTCFBdIeVw7vLWDvMuAlB8dmkw=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "vmware.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "35b4f3c9-cfc8-4773-5a0a-08d6c440c491", "X-MS-Exchange-CrossTenant-originalarrivaltime": "18 Apr 2019 20:59:37.8197\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MWHPR05MB2815", "Subject": "[dpdk-dev] [PATCH v2] net/vmxnet3: v4 boot and guest UDP RSS\n\tconfiguration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Eduard Serra <eserra@vmware.com>\n\nThis patch introduces:\n- VMxnet3 v4 negotiation and,\n- entirely guest-driven UDP RSS support.\n\nVMxnet3 v3 already has UDP RSS support, however it\ndepends on hypervisor provisioning on the VM through\nESX specific flags, which are not transparent or known\nto the guest later on.\n\nVmxnet3 v4 introduces a new API transaction which allows\nconfiguring RSS entirely from the guest. This API must be\ninvoked after device shared mem region is initialized.\n\nIPv4 ESP RSS (SPI based) is also available, but currently\nthere are no ESP RSS definitions on rte_eth layer to\nhandle that.\n\nSigned-off-by: Eduard Serra <eserra@vmware.com>\nAcked-by: Yong Wang <yongwang@vmware.com>\n---\n\nv2:\n* Added missing defines, as we will not merge them separately\n---\n drivers/net/vmxnet3/base/vmxnet3_defs.h | 12 ++++++++++\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 21 ++++++++++++++++-\n drivers/net/vmxnet3/vmxnet3_ethdev.h | 8 +++++++\n drivers/net/vmxnet3/vmxnet3_rxtx.c | 40 +++++++++++++++++++++++++++++++++\n 4 files changed, 80 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h\r\nindex bbec708..296d7e5 100644\r\n--- a/drivers/net/vmxnet3/base/vmxnet3_defs.h\r\n+++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h\r\n@@ -89,6 +89,7 @@ typedef enum {\r\n VMXNET3_CMD_RESERVED3,\r\n VMXNET3_CMD_RESERVED4,\r\n VMXNET3_CMD_REGISTER_MEMREGS,\r\n+ VMXNET3_CMD_SET_RSS_FIELDS,\r\n \r\n VMXNET3_CMD_FIRST_GET = 0xF00D0000,\r\n VMXNET3_CMD_GET_QUEUE_STATUS = VMXNET3_CMD_FIRST_GET,\r\n@@ -749,6 +750,15 @@ struct Vmxnet3_MemRegs {\r\n #include \"vmware_pack_end.h\"\r\n Vmxnet3_MemRegs;\r\n \r\n+typedef enum Vmxnet3_RSSField {\r\n+ VMXNET3_RSS_FIELDS_TCPIP4 = 0x0001,\r\n+ VMXNET3_RSS_FIELDS_TCPIP6 = 0x0002,\r\n+ VMXNET3_RSS_FIELDS_UDPIP4 = 0x0004,\r\n+ VMXNET3_RSS_FIELDS_UDPIP6 = 0x0008,\r\n+ VMXNET3_RSS_FIELDS_ESPIP4 = 0x0010,\r\n+ VMXNET3_RSS_FIELDS_ESPIP6 = 0x0020,\r\n+} Vmxnet3_RSSField;\r\n+\r\n /*\r\n * If the command data <= 16 bytes, use the shared memory direcly.\r\n * Otherwise, use the variable length configuration descriptor.\r\n@@ -758,6 +768,8 @@ typedef\r\n union Vmxnet3_CmdInfo {\r\n Vmxnet3_VariableLenConfDesc varConf;\r\n Vmxnet3_SetPolling setPolling;\r\n+ Vmxnet3_RSSField setRSSFields;\r\n+ __le16 reserved[2];\r\n __le64 data[2];\r\n }\r\n #include \"vmware_pack_end.h\"\r\ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\r\nindex 93e5de9..846d7fd 100644\r\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\r\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\r\n@@ -266,7 +266,11 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)\r\n \tver = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_VRRS);\r\n \tPMD_INIT_LOG(DEBUG, \"Hardware version : %d\", ver);\r\n \r\n-\tif (ver & (1 << VMXNET3_REV_3)) {\r\n+\tif (ver & (1 << VMXNET3_REV_4)) {\r\n+\t\tVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_VRRS,\r\n+\t\t\t\t 1 << VMXNET3_REV_4);\r\n+\t\thw->version = VMXNET3_REV_4 + 1;\r\n+\t} else if (ver & (1 << VMXNET3_REV_3)) {\r\n \t\tVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_VRRS,\r\n \t\t\t\t 1 << VMXNET3_REV_3);\r\n \t\thw->version = VMXNET3_REV_3 + 1;\r\n@@ -764,6 +768,15 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)\r\n \t\tPMD_INIT_LOG(DEBUG, \"Failed to setup memory region\\n\");\r\n \t}\r\n \r\n+\tif (VMXNET3_VERSION_GE_4(hw)) {\r\n+\t\t/* Check for additional RSS */\r\n+\t\tret = vmxnet3_v4_rss_configure(dev);\r\n+\t\tif (ret != VMXNET3_SUCCESS) {\r\n+\t\t\tPMD_INIT_LOG(ERR, \"Failed to configure v4 RSS\");\r\n+\t\t\treturn ret;\r\n+\t\t}\r\n+\t}\r\n+\r\n \t/* Disable interrupts */\r\n \tvmxnet3_disable_intr(hw);\r\n \r\n@@ -1141,6 +1154,8 @@ static void\r\n vmxnet3_dev_info_get(struct rte_eth_dev *dev __rte_unused,\r\n \t\t struct rte_eth_dev_info *dev_info)\r\n {\r\n+\tstruct vmxnet3_hw *hw = dev->data->dev_private;\r\n+\r\n \tdev_info->max_rx_queues = VMXNET3_MAX_RX_QUEUES;\r\n \tdev_info->max_tx_queues = VMXNET3_MAX_TX_QUEUES;\r\n \tdev_info->min_rx_bufsize = 1518 + RTE_PKTMBUF_HEADROOM;\r\n@@ -1150,6 +1165,10 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev __rte_unused,\r\n \r\n \tdev_info->flow_type_rss_offloads = VMXNET3_RSS_OFFLOAD_ALL;\r\n \r\n+\tif (VMXNET3_VERSION_GE_4(hw)) {\r\n+\t\tdev_info->flow_type_rss_offloads |= VMXNET3_V4_RSS_MASK;\r\n+\t}\r\n+\r\n \tdev_info->rx_desc_lim = (struct rte_eth_desc_lim) {\r\n \t\t.nb_max = VMXNET3_RX_RING_MAX_SIZE,\r\n \t\t.nb_min = VMXNET3_DEF_RX_RING_SIZE,\r\ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h\r\nindex 5bc3a84..319d739 100644\r\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.h\r\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h\r\n@@ -34,6 +34,10 @@\r\n \tETH_RSS_IPV6 | \\\r\n \tETH_RSS_NONFRAG_IPV6_TCP)\r\n \r\n+#define VMXNET3_V4_RSS_MASK ( \\\r\n+\tETH_RSS_NONFRAG_IPV4_UDP | \\\r\n+\tETH_RSS_NONFRAG_IPV6_UDP)\r\n+\r\n /* RSS configuration structure - shared with device through GPA */\r\n typedef struct VMXNET3_RSSConf {\r\n \tuint16_t hashType;\r\n@@ -103,10 +107,12 @@ struct vmxnet3_hw {\r\n \tUPT1_RxStats snapshot_rx_stats[VMXNET3_MAX_RX_QUEUES];\r\n };\r\n \r\n+#define VMXNET3_REV_4\t\t3\t\t/* Vmxnet3 Rev. 4 */\r\n #define VMXNET3_REV_3\t\t2\t\t/* Vmxnet3 Rev. 3 */\r\n #define VMXNET3_REV_2\t\t1\t\t/* Vmxnet3 Rev. 2 */\r\n #define VMXNET3_REV_1\t\t0\t\t/* Vmxnet3 Rev. 1 */\r\n \r\n+#define VMXNET3_VERSION_GE_4(hw) ((hw)->version >= VMXNET3_REV_4 + 1)\r\n #define VMXNET3_VERSION_GE_3(hw) ((hw)->version >= VMXNET3_REV_3 + 1)\r\n #define VMXNET3_VERSION_GE_2(hw) ((hw)->version >= VMXNET3_REV_2 + 1)\r\n \r\n@@ -162,6 +168,8 @@ void vmxnet3_dev_clear_queues(struct rte_eth_dev *dev);\r\n void vmxnet3_dev_rx_queue_release(void *rxq);\r\n void vmxnet3_dev_tx_queue_release(void *txq);\r\n \r\n+int vmxnet3_v4_rss_configure(struct rte_eth_dev *dev);\r\n+\r\n int vmxnet3_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,\r\n \t\t\t\tuint16_t nb_rx_desc, unsigned int socket_id,\r\n \t\t\t\tconst struct rte_eth_rxconf *rx_conf,\r\ndiff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c\r\nindex d30914a..4867a64 100644\r\n--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\r\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\r\n@@ -1292,6 +1292,46 @@ static uint8_t rss_intel_key[40] = {\r\n };\r\n \r\n /*\r\n+ * Additional RSS configurations based on vmxnet v4+ APIs\r\n+ */\r\n+int\r\n+vmxnet3_v4_rss_configure(struct rte_eth_dev *dev)\r\n+{\r\n+\tstruct vmxnet3_hw *hw = dev->data->dev_private;\r\n+\tVmxnet3_DriverShared *shared = hw->shared;\r\n+\tVmxnet3_CmdInfo *cmdInfo = &shared->cu.cmdInfo;\r\n+\tstruct rte_eth_rss_conf *port_rss_conf;\r\n+\tuint64_t rss_hf;\r\n+\tuint32_t ret;\r\n+\r\n+\tPMD_INIT_FUNC_TRACE();\r\n+\r\n+\tcmdInfo->setRSSFields = 0;\r\n+\tport_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;\r\n+\trss_hf = port_rss_conf->rss_hf &\r\n+\t\t(VMXNET3_V4_RSS_MASK | VMXNET3_RSS_OFFLOAD_ALL);\r\n+\r\n+\tif (rss_hf & ETH_RSS_NONFRAG_IPV4_TCP)\r\n+\t\tcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_TCPIP4;\r\n+\tif (rss_hf & ETH_RSS_NONFRAG_IPV6_TCP)\r\n+\t\tcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_TCPIP6;\r\n+\tif (rss_hf & ETH_RSS_NONFRAG_IPV4_UDP)\r\n+\t\tcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_UDPIP4;\r\n+\tif (rss_hf & ETH_RSS_NONFRAG_IPV6_UDP)\r\n+\t\tcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_UDPIP6;\r\n+\r\n+\tVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,\r\n+\t\t\t VMXNET3_CMD_SET_RSS_FIELDS);\r\n+\tret = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);\r\n+\r\n+\tif (ret != VMXNET3_SUCCESS) {\r\n+\t\tPMD_DRV_LOG(ERR, \"Set RSS fields (v4) failed: %d\", ret);\r\n+\t}\r\n+\r\n+\treturn ret;\r\n+}\r\n+\r\n+/*\r\n * Configure RSS feature\r\n */\r\n int\r\n", "prefixes": [ "v2" ] }