Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52947/?format=api
https://patches.dpdk.org/api/patches/52947/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190418171923.570-1-herakliusz.lipiec@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190418171923.570-1-herakliusz.lipiec@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190418171923.570-1-herakliusz.lipiec@intel.com", "date": "2019-04-18T17:19:23", "name": "net/tap: ipc add check for number of messages received", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e0d0abe749c7cf5d3307b596de16eef4320f6b91", "submitter": { "id": 742, "url": "https://patches.dpdk.org/api/people/742/?format=api", "name": "Herakliusz Lipiec", "email": "herakliusz.lipiec@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190418171923.570-1-herakliusz.lipiec@intel.com/mbox/", "series": [ { "id": 4385, "url": "https://patches.dpdk.org/api/series/4385/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4385", "date": "2019-04-18T17:19:23", "name": "net/tap: ipc add check for number of messages received", "version": 1, "mbox": "https://patches.dpdk.org/series/4385/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52947/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/52947/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AC10E1BC15;\n\tThu, 18 Apr 2019 19:18:34 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 531C51BC12;\n\tThu, 18 Apr 2019 19:18:32 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Apr 2019 10:18:31 -0700", "from silpixa00399499.ir.intel.com (HELO\n\tsilpixa00399499.ger.corp.intel.com) ([10.237.222.133])\n\tby orsmga004.jf.intel.com with ESMTP; 18 Apr 2019 10:18:29 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,366,1549958400\"; d=\"scan'208\";a=\"292667963\"", "From": "Herakliusz Lipiec <herakliusz.lipiec@intel.com>", "To": "Keith Wiles <keith.wiles@intel.com>", "Cc": "dev@dpdk.org, Herakliusz Lipiec <herakliusz.lipiec@intel.com>,\n\trasland@mellanox.com, stable@dpdk.org", "Date": "Thu, 18 Apr 2019 18:19:23 +0100", "Message-Id": "<20190418171923.570-1-herakliusz.lipiec@intel.com>", "X-Mailer": "git-send-email 2.17.2", "Subject": "[dpdk-dev] [PATCH] net/tap: ipc add check for number of messages\n\treceived", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A sucessfull call to rte_mp_request_sync does not guarantee that there\nare valid messages in the buffer, and this should be checked for before\naccessing data in the message.\n\nFixes: c9aa56edec8e (\"net/tap: access primary process queues from secondary\")\nCc: rasland@mellanox.com\nCc: stable@dpdk.org\nSigned-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>\n---\n drivers/net/tap/rte_eth_tap.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex e9fda8cf6..a619a8850 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -2101,7 +2101,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)\n \trequest.len_param = sizeof(*request_param);\n \t/* Send request and receive reply */\n \tret = rte_mp_request_sync(&request, &replies, &timeout);\n-\tif (ret < 0) {\n+\tif (ret < 0 || replies.n_receieved != 1) {\n \t\tTAP_LOG(ERR, \"Failed to request queues from primary: %d\",\n \t\t\trte_errno);\n \t\treturn -1;\n", "prefixes": [] }{ "id": 52947, "url": "