Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52926/?format=api
https://patches.dpdk.org/api/patches/52926/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190418114903.42231-3-yskoh@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190418114903.42231-3-yskoh@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190418114903.42231-3-yskoh@mellanox.com", "date": "2019-04-18T11:49:02", "name": "[v3,3/4] net/mlx: fix library search in meson build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0d69d4c4a1f107dfc5d66d6225613a20fe0903c9", "submitter": { "id": 636, "url": "https://patches.dpdk.org/api/people/636/?format=api", "name": "Yongseok Koh", "email": "yskoh@mellanox.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190418114903.42231-3-yskoh@mellanox.com/mbox/", "series": [ { "id": 4375, "url": "https://patches.dpdk.org/api/series/4375/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4375", "date": "2019-04-18T11:49:01", "name": "[v3,1/4] drivers/event: disable octeontx for buggy compilers on arm64", "version": 3, "mbox": "https://patches.dpdk.org/series/4375/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52926/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/52926/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BF7491B9C1;\n\tThu, 18 Apr 2019 13:49:24 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 7F9C61B9BC\n\tfor <dev@dpdk.org>; Thu, 18 Apr 2019 13:49:19 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tyskoh@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 18 Apr 2019 14:49:16 +0300", "from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx\n\t[10.101.0.96])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3IBn6jE003469;\n\tThu, 18 Apr 2019 14:49:13 +0300" ], "From": "Yongseok Koh <yskoh@mellanox.com>", "To": "bruce.richardson@intel.com, jerinj@marvell.com, pbhagavatula@marvell.com,\n\tshahafs@mellanox.com", "Cc": "dev@dpdk.org, thomas@monjalon.net, gavin.hu@arm.com,\n\tHonnappa.Nagarahalli@arm.com, bluca@debian.org, stable@dpdk.org", "Date": "Thu, 18 Apr 2019 04:49:02 -0700", "Message-Id": "<20190418114903.42231-3-yskoh@mellanox.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20190418114903.42231-1-yskoh@mellanox.com>", "References": "<20190412232451.30197-1-yskoh@mellanox.com>\n\t<20190418114903.42231-1-yskoh@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v3 3/4] net/mlx: fix library search in meson build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If MLNX_OFED is installed, there's no .pc file installed for libraries and\ndependency() can't find libraries by pkg-config. By adding fallback of\nusing cc.find_library(), libraries are properly located.\n\nFixes: e30b4e566f47 (\"build: improve dependency handling\")\nCc: bluca@debian.org\nCc: stable@dpdk.org\n\nSigned-off-by: Yongseok Koh <yskoh@mellanox.com>\n---\n\nv3:\n* use lib name without 'lib' prefix for cc.find_library()\n\nv2:\n* change variable names to minimize code change\n\n drivers/net/mlx4/meson.build | 15 +++++++++------\n drivers/net/mlx5/meson.build | 15 +++++++++------\n 2 files changed, 18 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build\nindex de020701d1..2540489bb7 100644\n--- a/drivers/net/mlx4/meson.build\n+++ b/drivers/net/mlx4/meson.build\n@@ -13,14 +13,17 @@ if pmd_dlopen\n \t\t'-DMLX4_GLUE_VERSION=\"@0@\"'.format(LIB_GLUE_VERSION),\n \t]\n endif\n-libs = [\n-\tdependency('libmnl', required:false),\n-\tdependency('libmlx4', required:false),\n-\tdependency('libibverbs', required:false),\n-]\n+libnames = [ 'mnl', 'mlx4', 'ibverbs' ]\n+libs = []\n build = true\n-foreach lib:libs\n+foreach libname:libnames\n+\tlib = dependency('lib' + libname, required:false)\n \tif not lib.found()\n+\t\tlib = cc.find_library(libname, required:false)\n+\tendif\n+\tif lib.found()\n+\t\tlibs += [ lib ]\n+\telse\n \t\tbuild = false\n \tendif\n endforeach\ndiff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build\nindex a4c684e1b5..1a65c3a989 100644\n--- a/drivers/net/mlx5/meson.build\n+++ b/drivers/net/mlx5/meson.build\n@@ -13,14 +13,17 @@ if pmd_dlopen\n \t\t'-DMLX5_GLUE_VERSION=\"@0@\"'.format(LIB_GLUE_VERSION),\n \t]\n endif\n-libs = [\n-\tdependency('libmnl', required:false),\n-\tdependency('libmlx5', required:false),\n-\tdependency('libibverbs', required:false),\n-]\n+libnames = [ 'mnl', 'mlx5', 'ibverbs' ]\n+libs = []\n build = true\n-foreach lib:libs\n+foreach libname:libnames\n+\tlib = dependency('lib' + libname, required:false)\n \tif not lib.found()\n+\t\tlib = cc.find_library(libname, required:false)\n+\tendif\n+\tif lib.found()\n+\t\tlibs += [ lib ]\n+\telse\n \t\tbuild = false\n \tendif\n endforeach\n", "prefixes": [ "v3", "3/4" ] }{ "id": 52926, "url": "