Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52885/?format=api
{ "id": 52885, "url": "https://patches.dpdk.org/api/patches/52885/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/b419b29ed97be86e542e54db64d250064968ae80.1555515863.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<b419b29ed97be86e542e54db64d250064968ae80.1555515863.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/b419b29ed97be86e542e54db64d250064968ae80.1555515863.git.igor.russkikh@aquantia.com", "date": "2019-04-17T15:45:45", "name": "[v2,7/7] net/atlantic: public experimental macsec API", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "85a54ac0ba62fd2731fabce2a13de4d79d938bef", "submitter": { "id": 1124, "url": "https://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/b419b29ed97be86e542e54db64d250064968ae80.1555515863.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 4355, "url": "https://patches.dpdk.org/api/series/4355/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4355", "date": "2019-04-17T15:45:25", "name": "add MACSEC hw offload to atlantic PMD", "version": 2, "mbox": "https://patches.dpdk.org/series/4355/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52885/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/52885/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D0CEF1B811;\n\tWed, 17 Apr 2019 17:45:50 +0200 (CEST)", "from NAM05-DM3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr730041.outbound.protection.outlook.com [40.107.73.41])\n\tby dpdk.org (Postfix) with ESMTP id 684351B7E3\n\tfor <dev@dpdk.org>; Wed, 17 Apr 2019 17:45:46 +0200 (CEST)", "from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by\n\tDM6PR11MB3738.namprd11.prod.outlook.com (20.179.16.20) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1813.12; Wed, 17 Apr 2019 15:45:45 +0000", "from DM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::f035:2c20:5a61:7653]) by\n\tDM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::f035:2c20:5a61:7653%3]) with mapi id 15.20.1813.011;\n\tWed, 17 Apr 2019 15:45:45 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=PuEaxuaGuE7AY9He68kKqmK3MEoQsjdQFDfgoGV20xE=;\n\tb=i04YLWNt/UEaFqEmQVPLnDncCUC/JAcMjcCOJQ8bIlMXV6xlnYzlrduEc7tLmQVViViOXUeEpu//5YRnBqevYYvOKHMg6sEMOUu2kFf1DWoq5pqPuOGzbJbvA57mVSxrnxg44lvPbqN3NfQzhxgfaE5AZ6NLeVWr0xmvcoj029U=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, \"thomas@monjalon.net\"\n\t<thomas@monjalon.net>, \"arybchenko@solarflare.com\"\n\t<arybchenko@solarflare.com>, \"konstantin.ananyev@intel.com\"\n\t<konstantin.ananyev@intel.com>,\n\tIgor Russkikh <Igor.Russkikh@aquantia.com>", "Thread-Topic": "[PATCH v2 7/7] net/atlantic: public experimental macsec API", "Thread-Index": "AQHU9TSe/ooEPAKDEEKlJimSj3hrIA==", "Date": "Wed, 17 Apr 2019 15:45:45 +0000", "Message-ID": "<b419b29ed97be86e542e54db64d250064968ae80.1555515863.git.igor.russkikh@aquantia.com>", "References": "<cover.1555515863.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1555515863.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BYAPR07CA0027.namprd07.prod.outlook.com\n\t(2603:10b6:a02:bc::40) To DM6PR11MB3625.namprd11.prod.outlook.com\n\t(2603:10b6:5:13a::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "06b1aee7-35ce-4f96-cbd5-08d6c34bc106", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(2017052603328)(7193020);\n\tSRVR:DM6PR11MB3738; ", "x-ms-traffictypediagnostic": "DM6PR11MB3738:", "x-microsoft-antispam-prvs": "<DM6PR11MB3738D53800BD606853261B5298250@DM6PR11MB3738.namprd11.prod.outlook.com>", "x-forefront-prvs": "0010D93EFE", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(39850400004)(346002)(396003)(136003)(376002)(366004)(199004)(189003)(2906002)(25786009)(54906003)(256004)(7736002)(97736004)(316002)(4326008)(71200400001)(53936002)(5640700003)(107886003)(71190400001)(99286004)(68736007)(8676002)(1730700003)(5660300002)(86362001)(2351001)(6512007)(305945005)(52116002)(6436002)(106356001)(81166006)(2501003)(36756003)(81156014)(105586002)(8936002)(6916009)(386003)(102836004)(26005)(6116002)(186003)(50226002)(72206003)(6506007)(76176011)(6486002)(14454004)(66066001)(478600001)(3846002)(476003)(118296001)(486006)(2616005)(44832011)(446003)(11346002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3738;\n\tH:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "Rv65VARjAfxizuqi7jl+FZwRFjtNEo2MyPIQCWOF05wDzjNo6VSpCSiha9d5Ogy0RYkkFGl55OSsssGinONqG3F0Uzttd/c3gImhPWJJ1YYLdUCXFp+2CCtCJKECIRWbQV4EvO+0eXEoWl9fjqX1FdeMpMrHqjzXFjkU852f6W5CQyG9+jyEd2P82Uk7Onj9UL77W9rxcxGphSac0Dp/cVnTdMWLqkz6sgleo5NGB/nfSEcvh2ebtJibigH7n3qp7NrbBptxwTiEuIua8nlcvTsS8lPtyzQMH3pJSTmEHAA8mscyCrmCXe7EYowuvlwJ3SQ/ErbD/xOEj4ZO3BshA36UD3dzxqYPFv/ux1se45SQOS42MyzTwyYkcKQ6nu5gZzApPiH4LONFSNZ9O/j5lD80aNRmZmbQF2ZuIkiBz7Q=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "06b1aee7-35ce-4f96-cbd5-08d6c34bc106", "X-MS-Exchange-CrossTenant-originalarrivaltime": "17 Apr 2019 15:45:45.0627\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR11MB3738", "Subject": "[dpdk-dev] [PATCH v2 7/7] net/atlantic: public experimental macsec\n\tAPI", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add public visible macsec API functions.\nThese are wrappers over internal configuration routines,\nvalidating and converting port no into dev pointer\n\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n drivers/net/atlantic/Makefile | 1 +\n drivers/net/atlantic/meson.build | 1 +\n drivers/net/atlantic/rte_pmd_atlantic.c | 102 ++++++++++++++++++\n drivers/net/atlantic/rte_pmd_atlantic.h | 41 +++++++\n .../net/atlantic/rte_pmd_atlantic_version.map | 12 +++\n 5 files changed, 157 insertions(+)\n create mode 100644 drivers/net/atlantic/rte_pmd_atlantic.c\n create mode 100644 drivers/net/atlantic/rte_pmd_atlantic.h", "diff": "diff --git a/drivers/net/atlantic/Makefile b/drivers/net/atlantic/Makefile\r\nindex 62dcdbffa69c..263f12b5575f 100644\r\n--- a/drivers/net/atlantic/Makefile\r\n+++ b/drivers/net/atlantic/Makefile\r\n@@ -31,5 +31,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += hw_atl_utils.c\r\n SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += hw_atl_llh.c\r\n SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += hw_atl_utils_fw2x.c\r\n SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += hw_atl_b0.c\r\n+SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += rte_pmd_atlantic.c\r\n \r\n include $(RTE_SDK)/mk/rte.lib.mk\r\ndiff --git a/drivers/net/atlantic/meson.build b/drivers/net/atlantic/meson.build\r\nindex 28fb97cace6e..60b84684ec0a 100644\r\n--- a/drivers/net/atlantic/meson.build\r\n+++ b/drivers/net/atlantic/meson.build\r\n@@ -9,4 +9,5 @@ sources = files(\r\n \t'hw_atl/hw_atl_llh.c',\r\n \t'hw_atl/hw_atl_utils_fw2x.c',\r\n \t'hw_atl/hw_atl_utils.c',\r\n+\t'rte_pmd_atlantic.c',\r\n )\r\ndiff --git a/drivers/net/atlantic/rte_pmd_atlantic.c b/drivers/net/atlantic/rte_pmd_atlantic.c\r\nnew file mode 100644\r\nindex 000000000000..5bf4da27fdd0\r\n--- /dev/null\r\n+++ b/drivers/net/atlantic/rte_pmd_atlantic.c\r\n@@ -0,0 +1,102 @@\r\n+/* SPDX-License-Identifier: BSD-3-Clause\r\n+ * Copyright(c) 2018 Aquantia Corporation\r\n+ */\r\n+\r\n+#include <rte_ethdev_driver.h>\r\n+\r\n+#include \"rte_pmd_atlantic.h\"\r\n+#include \"atl_ethdev.h\"\r\n+\r\n+\r\n+__rte_experimental int\r\n+rte_pmd_atl_macsec_enable(uint16_t port,\r\n+\t\t\t uint8_t encr, uint8_t repl_prot)\r\n+{\r\n+\tstruct rte_eth_dev *dev;\r\n+\r\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\r\n+\r\n+\tdev = &rte_eth_devices[port];\r\n+\r\n+\tif (!is_atlantic_supported(dev))\r\n+\t\treturn -ENOTSUP;\r\n+\r\n+\treturn atl_macsec_enable(dev, encr, repl_prot);\r\n+}\r\n+\r\n+__rte_experimental int\r\n+rte_pmd_atl_macsec_disable(uint16_t port)\r\n+{\r\n+\tstruct rte_eth_dev *dev;\r\n+\r\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\r\n+\r\n+\tdev = &rte_eth_devices[port];\r\n+\r\n+\tif (!is_atlantic_supported(dev))\r\n+\t\treturn -ENOTSUP;\r\n+\r\n+\treturn atl_macsec_disable(dev);\r\n+}\r\n+\r\n+__rte_experimental int\r\n+rte_pmd_atl_macsec_config_txsc(uint16_t port, uint8_t *mac)\r\n+{\r\n+\tstruct rte_eth_dev *dev;\r\n+\r\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\r\n+\r\n+\tdev = &rte_eth_devices[port];\r\n+\r\n+\tif (!is_atlantic_supported(dev))\r\n+\t\treturn -ENOTSUP;\r\n+\r\n+\treturn atl_macsec_config_txsc(dev, mac);\r\n+}\r\n+\r\n+__rte_experimental int\r\n+rte_pmd_atl_macsec_config_rxsc(uint16_t port, uint8_t *mac, uint16_t pi)\r\n+{\r\n+\tstruct rte_eth_dev *dev;\r\n+\r\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\r\n+\r\n+\tdev = &rte_eth_devices[port];\r\n+\r\n+\tif (!is_atlantic_supported(dev))\r\n+\t\treturn -ENOTSUP;\r\n+\r\n+\treturn atl_macsec_config_rxsc(dev, mac, pi);\r\n+}\r\n+\r\n+__rte_experimental int\r\n+rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an,\r\n+\t\t\t\t uint32_t pn, uint8_t *key)\r\n+{\r\n+\tstruct rte_eth_dev *dev;\r\n+\r\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\r\n+\r\n+\tdev = &rte_eth_devices[port];\r\n+\r\n+\tif (!is_atlantic_supported(dev))\r\n+\t\treturn -ENOTSUP;\r\n+\r\n+\treturn atl_macsec_select_txsa(dev, idx, an, pn, key);\r\n+}\r\n+\r\n+__rte_experimental int\r\n+rte_pmd_atl_macsec_select_rxsa(uint16_t port, uint8_t idx, uint8_t an,\r\n+\t\t\t\t uint32_t pn, uint8_t *key)\r\n+{\r\n+\tstruct rte_eth_dev *dev;\r\n+\r\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\r\n+\r\n+\tdev = &rte_eth_devices[port];\r\n+\r\n+\tif (!is_atlantic_supported(dev))\r\n+\t\treturn -ENOTSUP;\r\n+\r\n+\treturn atl_macsec_select_rxsa(dev, idx, an, pn, key);\r\n+}\r\ndiff --git a/drivers/net/atlantic/rte_pmd_atlantic.h b/drivers/net/atlantic/rte_pmd_atlantic.h\r\nnew file mode 100644\r\nindex 000000000000..6a1925266156\r\n--- /dev/null\r\n+++ b/drivers/net/atlantic/rte_pmd_atlantic.h\r\n@@ -0,0 +1,41 @@\r\n+/* SPDX-License-Identifier: BSD-3-Clause\r\n+ * Copyright(c) 2018 Aquantia Corporation\r\n+ */\r\n+\r\n+/**\r\n+ * @file rte_pmd_atlantic.h\r\n+ * atlantic PMD specific functions.\r\n+ *\r\n+ **/\r\n+\r\n+#ifndef _PMD_ATLANTIC_H_\r\n+#define _PMD_ATLANTIC_H_\r\n+\r\n+#include <rte_ethdev_driver.h>\r\n+\r\n+/**\r\n+ * Enable MACsec offload.\r\n+ *\r\n+ * @param port\r\n+ * The port identifier of the Ethernet device.\r\n+ * @param en\r\n+ * 1 - Enable encryption (encrypt and add integrity signature).\r\n+ * 0 - Disable encryption (only add integrity signature).\r\n+ * @param rp\r\n+ * 1 - Enable replay protection.\r\n+ * 0 - Disable replay protection.\r\n+ * @return\r\n+ * - (0) if successful.\r\n+ * - (-ENODEV) if *port* invalid.\r\n+ * - (-ENOTSUP) if hardware doesn't support this feature.\r\n+ */\r\n+int rte_pmd_atl_macsec_enable(uint16_t port, uint8_t en, uint8_t rp);\r\n+int rte_pmd_atl_macsec_disable(uint16_t port);\r\n+int rte_pmd_atl_macsec_config_txsc(uint16_t port, uint8_t *mac);\r\n+int rte_pmd_atl_macsec_config_rxsc(uint16_t port, uint8_t *mac, uint16_t pi);\r\n+int rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an,\r\n+\t\t\t\t uint32_t pn, uint8_t *key);\r\n+int rte_pmd_atl_macsec_select_rxsa(uint16_t port, uint8_t idx, uint8_t an,\r\n+\t\t\t\t uint32_t pn, uint8_t *key);\r\n+\r\n+#endif /* _PMD_ATLANTIC_H_ */\r\ndiff --git a/drivers/net/atlantic/rte_pmd_atlantic_version.map b/drivers/net/atlantic/rte_pmd_atlantic_version.map\r\nindex 521e51f411fb..b16faa999f43 100644\r\n--- a/drivers/net/atlantic/rte_pmd_atlantic_version.map\r\n+++ b/drivers/net/atlantic/rte_pmd_atlantic_version.map\r\n@@ -2,3 +2,15 @@ DPDK_18.11 {\r\n \r\n \tlocal: *;\r\n };\r\n+\r\n+EXPERIMENTAL {\r\n+\tglobal:\r\n+\r\n+\trte_pmd_atl_macsec_enable;\r\n+\trte_pmd_atl_macsec_disable;\r\n+\trte_pmd_atl_macsec_config_txsc;\r\n+\trte_pmd_atl_macsec_config_rxsc;\r\n+\trte_pmd_atl_macsec_select_txsa;\r\n+\trte_pmd_atl_macsec_select_rxsa;\r\n+};\r\n+\r\n", "prefixes": [ "v2", "7/7" ] }