Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52873,
    "url": "https://patches.dpdk.org/api/patches/52873/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190417144245.23353-1-herakliusz.lipiec@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190417144245.23353-1-herakliusz.lipiec@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190417144245.23353-1-herakliusz.lipiec@intel.com",
    "date": "2019-04-17T14:42:45",
    "name": "[6/8] ipc: fix tap pmd memleak",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "cd07a417f362a9790bf3cb1f7d840188c3c76bd1",
    "submitter": {
        "id": 742,
        "url": "https://patches.dpdk.org/api/people/742/?format=api",
        "name": "Herakliusz Lipiec",
        "email": "herakliusz.lipiec@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190417144245.23353-1-herakliusz.lipiec@intel.com/mbox/",
    "series": [
        {
            "id": 4352,
            "url": "https://patches.dpdk.org/api/series/4352/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4352",
            "date": "2019-04-17T14:38:22",
            "name": "[1/8] ipc: fix rte_mp_request_sync memleak",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/4352/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/52873/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/52873/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 930181B6E2;\n\tWed, 17 Apr 2019 16:41:57 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 65AC5397D;\n\tWed, 17 Apr 2019 16:41:55 +0200 (CEST)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Apr 2019 07:41:53 -0700",
            "from silpixa00399499.ir.intel.com (HELO\n\tsilpixa00399499.ger.corp.intel.com) ([10.237.222.133])\n\tby orsmga008.jf.intel.com with ESMTP; 17 Apr 2019 07:41:52 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,362,1549958400\"; d=\"scan'208\";a=\"135135756\"",
        "From": "Herakliusz Lipiec <herakliusz.lipiec@intel.com>",
        "To": "keith.wiles@intel.com",
        "Cc": "dev@dpdk.org, Herakliusz Lipiec <herakliusz.lipiec@intel.com>,\n\trasland@mellanox.com, stable@dpdk.org",
        "Date": "Wed, 17 Apr 2019 15:42:45 +0100",
        "Message-Id": "<20190417144245.23353-1-herakliusz.lipiec@intel.com>",
        "X-Mailer": "git-send-email 2.17.2",
        "Subject": "[dpdk-dev] [PATCH 6/8] ipc: fix tap pmd memleak",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When sending multiple requests, rte_mp_request_sync\ncan succeed sending a few of those requests, but then\nfail on a later one and in the end return with rc=-1.\nThe upper layers - e.g. device hotplug - currently\nhandles this case as if no messages were sent and no\nmemory for response buffers was allocated, which is\nnot true. Fixed by always freeing reply message buffers.\n\nFixes: c9aa56edec8e (\"net/tap: access primary process queues from secondary\")\nCc: rasland@mellanox.com\nCc: stable@dpdk.org\nSigned-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>\n---\n drivers/net/tap/rte_eth_tap.c | 2 ++\n 1 file changed, 2 insertions(+)",
    "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex e9fda8cf6..d70412d62 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -2104,6 +2104,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)\n \tif (ret < 0) {\n \t\tTAP_LOG(ERR, \"Failed to request queues from primary: %d\",\n \t\t\trte_errno);\n+\t\tfree(replies.msgs);\n \t\treturn -1;\n \t}\n \treply = &replies.msgs[0];\n@@ -2119,6 +2120,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)\n \tfor (queue = 0; queue < reply_param->txq_count; queue++)\n \t\tprocess_private->txq_fds[queue] = reply->fds[fd_iterator++];\n \n+\tfree(replies.msgs);\n \treturn 0;\n }\n \n",
    "prefixes": [
        "6/8"
    ]
}