Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52847,
    "url": "https://patches.dpdk.org/api/patches/52847/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1555485388-50214-1-git-send-email-andy.pei@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1555485388-50214-1-git-send-email-andy.pei@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1555485388-50214-1-git-send-email-andy.pei@intel.com",
    "date": "2019-04-17T07:16:28",
    "name": "[v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "eef32531198e6a592adbcc8cba962df489bde1c5",
    "submitter": {
        "id": 1185,
        "url": "https://patches.dpdk.org/api/people/1185/?format=api",
        "name": "Pei, Andy",
        "email": "andy.pei@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1555485388-50214-1-git-send-email-andy.pei@intel.com/mbox/",
    "series": [
        {
            "id": 4341,
            "url": "https://patches.dpdk.org/api/series/4341/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4341",
            "date": "2019-04-17T07:16:28",
            "name": "[v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/4341/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/52847/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/52847/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CC8661B11F;\n\tWed, 17 Apr 2019 09:23:44 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id A463C1B10C;\n\tWed, 17 Apr 2019 09:23:42 +0200 (CEST)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Apr 2019 00:23:41 -0700",
            "from dipei-st-npg.sh.intel.com ([10.67.110.220])\n\tby fmsmga006.fm.intel.com with ESMTP; 17 Apr 2019 00:23:40 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,361,1549958400\"; d=\"scan'208\";a=\"338226049\"",
        "From": "Andy Pei <andy.pei@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "andy.pei@intel.com, rosen.xu@intel.com, marko.kovacevic@intel.com,\n\tliq3ea@163.com, stable@dpdk.org",
        "Date": "Wed, 17 Apr 2019 15:16:28 +0800",
        "Message-Id": "<1555485388-50214-1-git-send-email-andy.pei@intel.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1555483757-48188-1-git-send-email-andy.pei@intel.com>",
        "References": "<1555483757-48188-1-git-send-email-andy.pei@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do\n\tpr",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "In rte_fpga_do_pr() function, if 'stat' returns error,\nrte_fpga_do_pr() returns -EINVAL without closing the\n'file_fd' that has been opened.\nAfter this patch, 'file_fd' is closed before rte_fpga_do_pr()\nreturns -EINVAL when 'stat' returns error\n\nCoverity issue: 279441\nFixes: ef1e8ede3da5 (\"raw/ifpga: add Intel FPGA bus rawdev driver\")\nCc: rosen.xu@intel.com\nCc: marko.kovacevic@intel.com\nCc: liq3ea@163.com\nCc: andy.pei@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n---\n drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c\nindex da772d0..eff001b 100644\n--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c\n@@ -244,7 +244,8 @@\n \tif (ret) {\n \t\tIFPGA_RAWDEV_PMD_ERR(\"stat on bitstream file failed: %s\\n\",\n \t\t\t\tfile_name);\n-\t\treturn -EINVAL;\n+\t\tret = -EINVAL;\n+\t\tgoto close_fd;\n \t}\n \tbuffer_size = file_stat.st_size;\n \tIFPGA_RAWDEV_PMD_INFO(\"bitstream file size: %zu\\n\", buffer_size);\n",
    "prefixes": [
        "v2"
    ]
}