Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52747/?format=api
{ "id": 52747, "url": "https://patches.dpdk.org/api/patches/52747/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190413190121.15416-1-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190413190121.15416-1-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190413190121.15416-1-jerinj@marvell.com", "date": "2019-04-13T19:01:18", "name": "[v9,1/4] mk: introduce helper to check valid compiler argument", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1982f87e8f2d14a58871b21f9753fa803545059c", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190413190121.15416-1-jerinj@marvell.com/mbox/", "series": [ { "id": 4300, "url": "https://patches.dpdk.org/api/series/4300/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4300", "date": "2019-04-13T19:01:18", "name": "[v9,1/4] mk: introduce helper to check valid compiler argument", "version": 9, "mbox": "https://patches.dpdk.org/series/4300/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52747/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/52747/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1AE0B1B0FF;\n\tSat, 13 Apr 2019 21:01:41 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 2103D1B0F9\n\tfor <dev@dpdk.org>; Sat, 13 Apr 2019 21:01:39 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx3DJ03on013823; Sat, 13 Apr 2019 12:01:38 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2ruf9jrtjh-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tSat, 13 Apr 2019 12:01:37 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tSat, 13 Apr 2019 12:01:36 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Sat, 13 Apr 2019 12:01:36 -0700", "from jerin-lab.marvell.com (unknown [10.28.34.14])\n\tby maili.marvell.com (Postfix) with ESMTP id 14FA13F703F;\n\tSat, 13 Apr 2019 12:01:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=ctMFhnOBSXNW/TFcRnFlTxOOy9t2vZ8bJTtpDbelmkQ=;\n\tb=KMxzAA7kKipHHlARS3801RCgtty7KEK9E9Hnryy0l3HUV1A+GovyQGigMS+wsM61Jurl\n\tXWr4XGgJcgG9/UsyB3GPABjJlICRIUsSX2MWzjJALnWORtDmjCHG0NSFdpzFtzATwJnu\n\ti7S5DczYGTZ0pLJrf6o+fjqdysQ+Kg97DpBh187FKpyoobScav2Xu9A+2qhHRJFYn89D\n\tE3KShMHQ1Qt1oSS9mKMXow7ayka1wS61pUTCSJV/nyduDwpD/X9jrECN7HP/BVcdcDn3\n\tFBdr6DeaLTpQWSOlvsZMjZLbOzfGwBHBhs+0h9fXYg1dVQ9mU0XyP9WbLsAqDb2QgoJZ\n\t8w== ", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>", "CC": "<yskoh@mellanox.com>, Jerin Jacob <jerinj@marvell.com>, Pavan Nikhilesh\n\t<pbhagavatula@marvell.com>", "Date": "Sun, 14 Apr 2019 00:31:18 +0530", "Message-ID": "<20190413190121.15416-1-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190410161400.9361-1-jerinj@marvell.com>", "References": "<20190410161400.9361-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-04-13_06:, , signatures=0", "Subject": "[dpdk-dev] [PATCH v9 1/4] mk: introduce helper to check valid\n\tcompiler argument", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nIntroduce rte_cc_has_argument() Makefile helper to\ncheck a given argument is support by the compiler.\n\nExample Usage:\n\ninclude $(RTE_SDK)/mk/rte.helper.mk\nMACHINE_CFLAGS += $(call rte_cc_has_argument, -mcpu=octeontx2)\n\nThis would allow adding -mcpu=octeontx2 in MACHINE_CFLAGS\nif it is only supported by the compiler. The use case for such\nscheme is to enable the mcpu optimization if the compiler\nsupports else it needs to compile the source code without\nany errors.\n\nThis patch also moves inclusion of toolchain's rte.vars.mk\nto before the machine's rte.vars.mk inclusion to make\ncorrect CC available for the cross compile case.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\nChange history of this series:\n\nv9 Changes:\n - Remove compiler version check as it is now done using\n cc.has_argument().\n\nv8 Changes:\n - Remove redudant lists (rebase aritfacts). (Yongseok Koh)\n \nv7 Changes:\n - Updated cross compile config files align with \n \"build: improve pcap dependency handling\" changeset to fix build issue with meson\n - Some compiler needs the following depended patch to compile with meson\n http://patches.dpdk.org/patch/52367/\n\nv6 Changes:\n - Rework to change the config files to sync with \"mk: use linux and freebsd in config names\"\n - Fix the following error with latest gcc by fixing the mcpu type\n cc1: error: switch -mcpu=armv8.2-a conflicts with -march=armv8-a switch \n\nv5 Changes:\n - Fix incorrect meson flag parsing(Phil Yang)\n - Squash meson cross build patch(5/5) into configuration update patches for\n thunderx2(3/5) and octeontx2(4/5)(Thomas)\n - Changed octeontx2's march as armv8-a and added the extension required\n instead of armv8-2a(Phil Yang)\n - Improved rte_cc_has_argument() implementaion by removing the temp\n file(Thomas)\n\nv4 Changes:\n - Fix incorrect signoff marrvell -> marvell.\n\nv3 Changes:\n - Squash meson build support into config support for thunderx2/octeontx2.\n\nv2 Changes:\n - Add meson build support.\n\n mk/rte.helper.mk | 10 ++++++++++\n mk/target/generic/rte.vars.mk | 22 +++++++++++-----------\n 2 files changed, 21 insertions(+), 11 deletions(-)\n create mode 100644 mk/rte.helper.mk", "diff": "diff --git a/mk/rte.helper.mk b/mk/rte.helper.mk\nnew file mode 100644\nindex 000000000..6e7fd03d7\n--- /dev/null\n+++ b/mk/rte.helper.mk\n@@ -0,0 +1,10 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2018 Marvell International Ltd\n+\n+# rte_cc_has_argument\n+# Usage: MACHINE_CFLAGS += $(call rte_cc_has_argument, -mno-avx512f)\n+# Return the argument if the argument is supported by the compiler.\n+#\n+define rte_cc_has_argument\n+\t$(shell $(CC) -E $(1) -xc /dev/null 1>/dev/null 2>/dev/null && echo $(1))\n+endef\ndiff --git a/mk/target/generic/rte.vars.mk b/mk/target/generic/rte.vars.mk\nindex dd149acc9..25a578ad7 100644\n--- a/mk/target/generic/rte.vars.mk\n+++ b/mk/target/generic/rte.vars.mk\n@@ -7,6 +7,17 @@\n # executive environment.\n #\n \n+#\n+# toolchain:\n+#\n+# - define CC, LD, AR, AS, ...\n+# - define TOOLCHAIN_CFLAGS variable (overridden by cmdline value)\n+# - define TOOLCHAIN_LDFLAGS variable (overridden by cmdline value)\n+# - define TOOLCHAIN_ASFLAGS variable (overridden by cmdline value)\n+# - may override any previously defined variable\n+#\n+include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.vars.mk\n+\n #\n # machine:\n #\n@@ -45,17 +56,6 @@ endif\n #\n include $(RTE_SDK)/mk/arch/$(RTE_ARCH)/rte.vars.mk\n \n-#\n-# toolchain:\n-#\n-# - define CC, LD, AR, AS, ...\n-# - define TOOLCHAIN_CFLAGS variable (overridden by cmdline value)\n-# - define TOOLCHAIN_LDFLAGS variable (overridden by cmdline value)\n-# - define TOOLCHAIN_ASFLAGS variable (overridden by cmdline value)\n-# - may override any previously defined variable\n-#\n-include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.vars.mk\n-\n #\n # exec-env:\n #\n", "prefixes": [ "v9", "1/4" ] }