Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52712/?format=api
{ "id": 52712, "url": "https://patches.dpdk.org/api/patches/52712/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190412130949.14299-1-i.maximets@samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190412130949.14299-1-i.maximets@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190412130949.14299-1-i.maximets@samsung.com", "date": "2019-04-12T13:09:49", "name": "vhost: fix silent queue enabling with legacy guests", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0756b87ca831c1a235b5596085647a235c4d367c", "submitter": { "id": 323, "url": "https://patches.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190412130949.14299-1-i.maximets@samsung.com/mbox/", "series": [ { "id": 4282, "url": "https://patches.dpdk.org/api/series/4282/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4282", "date": "2019-04-12T13:09:49", "name": "vhost: fix silent queue enabling with legacy guests", "version": 1, "mbox": "https://patches.dpdk.org/series/4282/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52712/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/52712/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AD2CC1B130;\n\tFri, 12 Apr 2019 15:09:59 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n\t[210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 71AE91B128\n\tfor <dev@dpdk.org>; Fri, 12 Apr 2019 15:09:58 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n\tby mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20190412130956euoutp01e699669c85f24ca1e890fa0a2407fdb1~UvBtVXWme0874708747euoutp01a\n\tfor <dev@dpdk.org>; Fri, 12 Apr 2019 13:09:56 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20190412130956eucas1p2cde252e3436cf0ebb78f9ca02307782f~UvBs0b6Lj1252312523eucas1p2t;\n\tFri, 12 Apr 2019 13:09:56 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n\teusmges2new.samsung.com (EUCPMTA) with SMTP id 13.93.04377.42E80BC5;\n\tFri, 12 Apr 2019 14:09:56 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n\t20190412130955eucas1p114cc8050bf475c1df7b50572da718fb8~UvBr8sxAm0724907249eucas1p1F;\n\tFri, 12 Apr 2019 13:09:55 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n\teusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n\t20190412130955eusmtrp29ceac4841d6836d9b6f5b9eb4b53ecf1~UvBrunSPG2779727797eusmtrp2f;\n\tFri, 12 Apr 2019 13:09:55 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n\teusmgms1.samsung.com (EUCPMTA) with SMTP id 80.FA.04146.32E80BC5;\n\tFri, 12 Apr 2019 14:09:55 +0100 (BST)", "from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by\n\teusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n\t20190412130954eusmtip296eccc695400f01e2bbd2f323770d044~UvBrM1ZD42414424144eusmtip2G;\n\tFri, 12 Apr 2019 13:09:54 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n\t20190412130956euoutp01e699669c85f24ca1e890fa0a2407fdb1~UvBtVXWme0874708747euoutp01a", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n\ts=mail20170921; t=1555074596;\n\tbh=ZVZimRffPA9EazrP4Igj9d3lP2Wk7kDXi6DEuzcb1mE=;\n\th=From:To:Cc:Subject:Date:References:From;\n\tb=ZjFITHKj5n1FqEcXNL8WP3B3H7EPMJp8cLdK6K8sfucm8urbsNukcH2iG4YeahxDr\n\tXT/Iwf8RQfMkclLJ++pfCDslhztq4ulFJIxJ54EXm1C7WKrYTRFdaGOtr/PjBtVqD1\n\tTMoIGfFr9F1Z4PROgJmpkRF35YZULDxCnfSFydh4=", "X-AuditID": "cbfec7f4-113ff70000001119-db-5cb08e24b3e0", "From": "Ilya Maximets <i.maximets@samsung.com>", "To": "dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "Tiwei Bie <tiwei.bie@intel.com>, Jens Freimann <jfreimann@redhat.com>,\n\tDavid Marchand <david.marchand@redhat.com>, Ilya Maximets\n\t<i.maximets@samsung.com>, stable@dpdk.org", "Date": "Fri, 12 Apr 2019 16:09:49 +0300", "Message-Id": "<20190412130949.14299-1-i.maximets@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "X-Brightmail-Tracker": [ "H4sIAAAAAAAAA0VSW0hTcRj3v3O2HUfL05T80EwYJhS1mfQwumiCDyNQBKWrUqc8TdNN2Znm\n\tJWil2dqDkxAsCZVEFGd5YXlZUnOkC6uZUmGRZqmVzoyalHND23Ymvf2ufL+Hj8BEDjyCyFVp\n\taLWKyhfzBHjviGtsX0x1V2bc936urK9Nz5Mt/+7jyN7cdPFl9o4WXDZyaxCXres8fNkj7Qbn\n\tKF++1tTClTcPLnDkP5+85cmrTe0oDT8tOJxN5+cW02ppwjlBjvu5jVs4IygZNqRqkYfQo2AC\n\tyAPgdnzm6ZGAEJFtCPonbuAsWUFwz2ThsMSJ4J1Wz9+sOAeG+KzRiuDp6sdAahVB851a5Evx\n\tyL0wanzmx2FkAtQOujBfCCN7EDSYjbjPCCWTYa6j2Y9xchfU1bIFIXkIPvx6jLPnosHYZfGX\n\tgXzJg7WJb4g1ksFtGMBYHAqLNlNg3w7YGGjksPgqfKpcQGxZh6DOuh4wEsHksHsLhHfSbug0\n\tS1k5CTw2C+6TgdwKkz+2+WTMC2/31mGsLARdlYhNx4B7qDWwIALeLzsDC+Sw1j7uXykis2Bp\n\t1oNq0M76/7eaEGpH4XQRo1TQTLyKvixhKCVTpFJILhQoe5D3BV6s21b6kdlz3opIAom3CE8m\n\tdWaKuFQxU6q0IiAwcZgwA/dKwmyqtIxWF5xVF+XTjBVFErg4XFgeNHNGRCooDZ1H04W0etPl\n\tEMERWtRbLj0+JcGMjbMakdq8dJBIydvuWPyb/DqlMqs8LWhm7pJLGiKxM7Z45fCfzqWouLvz\n\tDmVD24NXVZHj16LmDRejqZDp6YovccKV+4X2h4oSnSZ9sqasJLbna/1Q6tjs9YYjoy3peIIh\n\tFiXWnxrLMFdciZw6ZpdYnOLJxBPd3WKcyaH278HUDPUPaFwu8/4CAAA=", "H4sIAAAAAAAAA+NgFjrILMWRmVeSWpSXmKPExsVy+t/xe7rKfRtiDNqnclhsX9HFZvHu03Ym\n\tiyvtP9ktzq1ZymJxrHMPi8W/jj/sFlsb/jM5sHv8WrCU1WPxnpdMHu/3XWXz6NuyijGAJUrP\n\tpii/tCRVISO/uMRWKdrQwkjP0NJCz8jEUs/Q2DzWyshUSd/OJiU1J7MstUjfLkEv4/eJ46wF\n\tD7gqjvb7NTD+4ehi5OSQEDCR+LzzIHsXIxeHkMBSRokr37+wQSSkJH78usAKYQtL/LnWxQZR\n\t9I1R4suGKYwgCTYBHYlTq4+A2SICDhK397xiASliFtjGKNGw+CNYt7CAi8STNYtZQGwWAVWJ\n\t6VMgGngFrCVufdzNArFBXmL1hgPMExh5FjAyrGIUSS0tzk3PLTbUK07MLS7NS9dLzs/dxAgM\n\tvm3Hfm7ewXhpY/AhRgEORiUe3gCr9TFCrIllxZW5hxglOJiVRHhDWIBCvCmJlVWpRfnxRaU5\n\tqcWHGE2Blk9klhJNzgdGRl5JvKGpobmFpaG5sbmxmYWSOO95g8ooIYH0xJLU7NTUgtQimD4m\n\tDk6pBkam9/+sdtcf0PZ6w3VCJy7oxuZzHqetZc9EeJefnv33jY2I8IGN5e8q/3I4vwncIc1i\n\tYLE6TNhKuOZ0RZrlsgseAn8+2Nk36TJezdUSbNl3S8K+9GLeMak/K3/MbTFfZtBWbpDxQcw7\n\teWVr6/vZecw77355K1bfvPfDRT0X0cpPWbuZznKkuymxFGckGmoxFxUnAgBYLt/1VAIAAA==" ], "X-CMS-MailID": "20190412130955eucas1p114cc8050bf475c1df7b50572da718fb8", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20190412130955eucas1p114cc8050bf475c1df7b50572da718fb8", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20190412130955eucas1p114cc8050bf475c1df7b50572da718fb8", "References": "<CGME20190412130955eucas1p114cc8050bf475c1df7b50572da718fb8@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH] vhost: fix silent queue enabling with legacy\n\tguests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "vhost should notify the application in case of all vring state changes.\n\nIn general, application should not care about negotiation of\nVHOST_USER_F_PROTOCOL_FEATURES. Protocol details like this should\nbe hidden by the vhost library.\n\nWith this patch applications like OVS will be able to assume that\nall vrings disabled by default and only process 'vring_state_changed'\nevents.\n\nFixes: 321203a54ba7 (\"vhost: enable rings at the right time\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n lib/librte_vhost/vhost_user.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 23beed97d..c9e29ece8 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1231,8 +1231,12 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \t * the ring starts already enabled. Otherwise, it is enabled via\n \t * the SET_VRING_ENABLE message.\n \t */\n-\tif (!(dev->features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES)))\n+\tif (!(dev->features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) {\n \t\tvq->enabled = 1;\n+\t\tif (dev->notify_ops->vring_state_changed)\n+\t\t\tdev->notify_ops->vring_state_changed(\n+\t\t\t\tdev->vid, file.index, 1);\n+\t}\n \n \tif (vq->kickfd >= 0)\n \t\tclose(vq->kickfd);\n", "prefixes": [] }