Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52643/?format=api
{ "id": 52643, "url": "https://patches.dpdk.org/api/patches/52643/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190411102306.11943-1-i.maximets@samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190411102306.11943-1-i.maximets@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190411102306.11943-1-i.maximets@samsung.com", "date": "2019-04-11T10:23:06", "name": "vhost: fix device leak on connection add failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "791d16ec62ed5fff05f85f961f8eec46469d7690", "submitter": { "id": 323, "url": "https://patches.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190411102306.11943-1-i.maximets@samsung.com/mbox/", "series": [ { "id": 4262, "url": "https://patches.dpdk.org/api/series/4262/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4262", "date": "2019-04-11T10:23:06", "name": "vhost: fix device leak on connection add failure", "version": 1, "mbox": "https://patches.dpdk.org/series/4262/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52643/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/52643/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DA27C5323;\n\tThu, 11 Apr 2019 12:23:16 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n\t[210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E2BD14F94\n\tfor <dev@dpdk.org>; Thu, 11 Apr 2019 12:23:14 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n\tby mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20190411102313euoutp0164f743329b4982475a4ab2893a8c836c~UZG28y9Pa1555515555euoutp01N\n\tfor <dev@dpdk.org>; Thu, 11 Apr 2019 10:23:13 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20190411102313eucas1p252cb1995d4b2622b0f9c519b9cf42136~UZG2gxJcL2418924189eucas1p25;\n\tThu, 11 Apr 2019 10:23:13 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n\teusmges2new.samsung.com (EUCPMTA) with SMTP id 4D.9B.04377.1951FAC5;\n\tThu, 11 Apr 2019 11:23:13 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n\t20190411102312eucas1p2c52abee0af4079ca87c8bb8af7b16274~UZG1stoQY2125221252eucas1p2S;\n\tThu, 11 Apr 2019 10:23:12 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n\teusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n\t20190411102312eusmtrp24e0aa570fa41132209bcc72370395085~UZG1WG9pz1143911439eusmtrp2N;\n\tThu, 11 Apr 2019 10:23:12 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n\teusmgms1.samsung.com (EUCPMTA) with SMTP id 43.FA.04146.0951FAC5;\n\tThu, 11 Apr 2019 11:23:12 +0100 (BST)", "from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by\n\teusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n\t20190411102311eusmtip281d2c0277702b742fff8fafc6983b309~UZG00Ay7h1438914389eusmtip2m;\n\tThu, 11 Apr 2019 10:23:11 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n\t20190411102313euoutp0164f743329b4982475a4ab2893a8c836c~UZG28y9Pa1555515555euoutp01N", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n\ts=mail20170921; t=1554978193;\n\tbh=SGgW5a+nPwKBqGsDLJQfYLUwh/cObeqQpX/hOs02B+Q=;\n\th=From:To:Cc:Subject:Date:References:From;\n\tb=rm7m7WMPDB5AvggZ7IckylmiinZiTZJqGwl3QxpybB2/Oe6GigRz+PW1b08flXRDg\n\tjhrMAq1Jwt8NSn10th3nOLzNQ5ysSAl1rnZWGitmzxMLiknOUVwoDcMOHUgkvlyyC7\n\tFTdH9isKkGGXFBpmMmAfLGpBaGOoEHXFKWY4HV30=", "X-AuditID": "cbfec7f4-12dff70000001119-d4-5caf1591fe97", "From": "Ilya Maximets <i.maximets@samsung.com>", "To": "dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "Tiwei Bie <tiwei.bie@intel.com>, Jens Freimann <jfreimann@redhat.com>,\n\tDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>, David Marchand\n\t<david.marchand@redhat.com>, Ilya Maximets <i.maximets@samsung.com>, \n\tstable@dpdk.org", "Date": "Thu, 11 Apr 2019 13:23:06 +0300", "Message-Id": "<20190411102306.11943-1-i.maximets@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "X-Brightmail-Tracker": [ "H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsWy7djPc7oTRdfHGHxtY7NYtr+VxWL7ii42\n\ti3eftjNZXGn/yW5xbs1SFotjnXtYLP51/GG32Nrwn8mBw+PXgqWsHov3vGTyeL/vKptH35ZV\n\tjAEsUVw2Kak5mWWpRfp2CVwZ2xesZiqYyF3x8tN5lgbGeZxdjJwcEgImEn+Pz2XpYuTiEBJY\n\twSix9uZsZgjnC6PE70cXmCCcz4wS6ze3scO0NB19CmYLCSxnlJh6UBui6AejxIOHzawgCTYB\n\tHYlTq48wgtgiAnYSU/b8BBvLLPCMUWLyqy4WkISwgKPEobUP2EBsFgFViVPn+8BsXgFricUz\n\tF7FBbJOXWL3hAFizhMB1Non2K09YIRIuEntPPYAqEpZ4dXwL1HkyEv93zmeCsOsl7re8ZIRo\n\t7mCUmH7oH1TCXmLL63NADRxAJ2lKrN+lDxF2lGg6soAFJCwhwCdx460gSJgZyJy0bTozRJhX\n\toqNNCKJaReL3weXMELaUxM13n6Eu8JCYuH4RNIBiJaY/b2KZwCg3C2HXAkbGVYziqaXFuemp\n\txUZ5qeV6xYm5xaV56XrJ+bmbGIHp4PS/4192MO76k3SIUYCDUYmH14FhXYwQa2JZcWXuIUYJ\n\tDmYlEd4QlvUxQrwpiZVVqUX58UWlOanFhxilOViUxHmrGR5ECwmkJ5akZqemFqQWwWSZODil\n\tGhg1GW7bqkdEHrg0zy/jWY5Bu67uzab+raWXC8Ldtj72Cm3U4ddgmnl+b+StVzOvV2z0Pb7O\n\tzur91hV7tRVm50m8lmbhY8w7KmsRcTwz//E+Hcd3/CecDk4tfZNrskxEMMiCXa5Pwqf0YIv9\n\ttfXP7p0o2JjVPON5+sn6QrsD7/dsXyk6I/jpmw9KLMUZiYZazEXFiQCoqPuAAwMAAA==", "H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsVy+t/xe7oTRNfHGJzaw2qxbH8ri8X2FV1s\n\tFu8+bWeyuNL+k93i3JqlLBbHOvewWPzr+MNusbXhP5MDh8evBUtZPRbvecnk8X7fVTaPvi2r\n\tGANYovRsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstSi/TtEvQy\n\tti9YzVQwkbvi5afzLA2M8zi7GDk5JARMJJqOPmXvYuTiEBJYyijRvmgxG0RCSuLHrwusELaw\n\txJ9rXWwQRd8YJc5c7GcBSbAJ6EicWn2EEcQWEXCQuL3nFQtIEbPAK0aJOa272EESwgKOEofW\n\tPgCbyiKgKnHqfB+YzStgLbF45iKobfISqzccYJ7AyLOAkWEVo0hqaXFuem6xoV5xYm5xaV66\n\tXnJ+7iZGYCBuO/Zz8w7GSxuDDzEKcDAq8fBO+L02Rog1say4MvcQowQHs5IIbwjL+hgh3pTE\n\tyqrUovz4otKc1OJDjKZAyycyS4km5wOjJK8k3tDU0NzC0tDc2NzYzEJJnPe8QWWUkEB6Yklq\n\tdmpqQWoRTB8TB6dUAyPb6co5GeVfGN367GeU92Vz7995c42E4QLfCLMH7tIi2Qd5u4L/N8+P\n\t+fsg39Zu9YUPbNWr+9bvu772v8ysOrWJu56WmBXkX8t73bdjcdzhpoKrVsVdaq9OfAj6Vb38\n\t/qSXKcHPfaUjkjNOvJAqznTnLIi5pGzo9EDUWkPVTd60qeDhAv1QFyWW4oxEQy3mouJEAAHg\n\tcmFaAgAA" ], "X-CMS-MailID": "20190411102312eucas1p2c52abee0af4079ca87c8bb8af7b16274", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20190411102312eucas1p2c52abee0af4079ca87c8bb8af7b16274", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20190411102312eucas1p2c52abee0af4079ca87c8bb8af7b16274", "References": "<CGME20190411102312eucas1p2c52abee0af4079ca87c8bb8af7b16274@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH] vhost: fix device leak on connection add failure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Need to destroy allocated device if application fails to\nadd new connection or we have fdset failure.\n\nFixes: acbff5c67ea7 (\"vhost: fix crash when exceeding file descriptors\")\nFixes: efba12a78ddf (\"vhost: add user callbacks for socket open/close\")\nCc: stable@dpdk.org\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n lib/librte_vhost/socket.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c\nindex 43f091d10..c34668004 100644\n--- a/lib/librte_vhost/socket.c\n+++ b/lib/librte_vhost/socket.c\n@@ -240,7 +240,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket)\n \t\t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\t\"failed to add vhost user connection with fd %d\\n\",\n \t\t\t\tfd);\n-\t\t\tgoto err;\n+\t\t\tgoto err_cleanup;\n \t\t}\n \t}\n \n@@ -257,7 +257,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket)\n \t\tif (vsocket->notify_ops->destroy_connection)\n \t\t\tvsocket->notify_ops->destroy_connection(conn->vid);\n \n-\t\tgoto err;\n+\t\tgoto err_cleanup;\n \t}\n \n \tpthread_mutex_lock(&vsocket->conn_mutex);\n@@ -267,6 +267,8 @@ vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket)\n \tfdset_pipe_notify(&vhost_user.fdset);\n \treturn;\n \n+err_cleanup:\n+\tvhost_destroy_device(vid);\n err:\n \tfree(conn);\n \tclose(fd);\n", "prefixes": [] }