Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52420/?format=api
{ "id": 52420, "url": "https://patches.dpdk.org/api/patches/52420/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190408123029.6701-1-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190408123029.6701-1-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190408123029.6701-1-mattias.ronnblom@ericsson.com", "date": "2019-04-08T12:30:27", "name": "[RFC,1/3] Replace lrand48-based rte_rand with LFSR generator", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "47d25d1a4a706a85c5849178554dcbae0e907ab7", "submitter": { "id": 1077, "url": "https://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190408123029.6701-1-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 4175, "url": "https://patches.dpdk.org/api/series/4175/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4175", "date": "2019-04-08T12:30:27", "name": "[RFC,1/3] Replace lrand48-based rte_rand with LFSR generator", "version": 1, "mbox": "https://patches.dpdk.org/series/4175/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52420/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/52420/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 92CAA2C54;\n\tMon, 8 Apr 2019 14:30:47 +0200 (CEST)", "from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58])\n\tby dpdk.org (Postfix) with ESMTP id F26DD2C24\n\tfor <dev@dpdk.org>; Mon, 8 Apr 2019 14:30:46 +0200 (CEST)", "from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119])\n\tby sessmg22.ericsson.net (Symantec Mail Security) with SMTP id\n\t70.D7.21601.6FE3BAC5; Mon, 8 Apr 2019 14:30:46 +0200 (CEST)", "from ESESSMB502.ericsson.se (153.88.183.163) by\n\tESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1713.5; Mon, 8 Apr 2019 14:30:45 +0200", "from selio1a020.lmera.ericsson.se (153.88.183.153) by\n\tsmtp.internal.ericsson.com (153.88.183.190) with Microsoft SMTP\n\tServer id\n\t15.1.1713.5 via Frontend Transport; Mon, 8 Apr 2019 14:30:45 +0200", "from breslau.lmera.ericsson.se (breslau.lmera.ericsson.se\n\t[150.132.109.241])\n\tby selio1a020.lmera.ericsson.se (8.15.1+Sun/8.15.1) with ESMTP id\n\tx38CUjiE011282; Mon, 8 Apr 2019 14:30:45 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801;\n\tc=relaxed/relaxed; \n\tq=dns/txt; i=@ericsson.com; t=1554726646; x=1557318646;\n\th=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=ujLrsN6Wq+geN6v+VL00LAfWCUF73KMZFs4yGVEvHqM=;\n\tb=SepuksCkalmJ56m3anqOVeBm7jpRqlg/2IuLQMpjbFCVQIKs6ZeHOQKDyRss7yCW\n\thbfxTKF/N2TMHc1aCDqzDLi4EsME8Du9689gUTAntuPN5oJBFOtcgYolLUCvKW1q\n\tSADqXZVWQ8cD1soJk3WB2JvvSag1D38HHvSgOWBFcfk=;", "X-AuditID": "c1b4fb3a-ccb299e000005461-b4-5cab3ef6993d", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Date": "Mon, 8 Apr 2019 14:30:27 +0200", "Message-ID": "<20190408123029.6701-1-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190405135030.09c5291a@shemminger-XPS-13-9360>", "References": "<20190405135030.09c5291a@shemminger-XPS-13-9360>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Brightmail-Tracker": "H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsUyM2J7ue43u9UxBse2aFq8+7SdyYHR49eC\n\tpawBjFFcNimpOZllqUX6dglcGbNP3mQqWOZQ8W6nRAPjZ9MuRk4OCQETiVX9PWxdjFwcQgJH\n\tGSXmbt7DCOF8ZZR48WIRC4RzgVHiYMduqLJLjBKLZl1hBelnE/CUmPyumwXEFhEQklj68TI7\n\tiM0s4C7x/tFypi5GDg5hAVeJf0vNQMIsAioSV7cfYwaxeQUcJWY37GGDOENeYvWGA2BxTgFb\n\tif7GnWBjhARsJDbMf8kKUS8ocXLmExaI8ZoSrdt/Q62Sl2jeOpsZol5L4v6SL8wTGIVmIWmZ\n\thaRlFpKWBYzMqxhFi1OLi3PTjYz0Uosyk4uL8/P08lJLNjECg/bglt9WOxgPPnc8xCjAwajE\n\tw6tnvDpGiDWxrLgy9xCjBAezkgjvzqmrYoR4UxIrq1KL8uOLSnNSiw8xSnOwKInz/hESjBES\n\tSE8sSc1OTS1ILYLJMnFwSjUwhrt7ZT5+/tHr6rLZ8R88vCYudJE+MS/p8xt/1VXPK/5sLnl7\n\tZHYqU/rhT3GsZ3fxlc+7/uvgTm2/F0p9W98n5r3UzLY8+2Li5cSf07Tl0juvVxyZnOmcNye/\n\tpOPFuxWTb3y3TJD0UFWK7v1qJPnx1o3m9wpPduVlVfXwOz8+cuXZRIfSWw+vlyixFGckGmox\n\tFxUnAgBQEfshVgIAAA==", "Subject": "[dpdk-dev] [RFC 1/3] Replace lrand48-based rte_rand with LFSR\n\tgenerator", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit replaces rte_rand()'s use of lrand48() with a DPDK-native\ncombined Linear Feedback Shift Register (LFSR) (also known as\nTausworthe) pseudo-number generator, with four sequences.\n\nThis generator is faster and produces better quality random numbers\nthan libc's lrand48() implementation. This implementation, as opposed\nto lrand48(), is multi-thread safe in regards to concurrent rte_rand()\ncalls from different lcore threads.\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n lib/librte_eal/common/include/rte_random.h | 25 ++---\n lib/librte_eal/common/meson.build | 1 +\n lib/librte_eal/common/rte_random.c | 104 +++++++++++++++++++++\n lib/librte_eal/freebsd/eal/Makefile | 1 +\n lib/librte_eal/freebsd/eal/eal.c | 2 -\n lib/librte_eal/linux/eal/Makefile | 1 +\n lib/librte_eal/linux/eal/eal.c | 2 -\n lib/librte_eal/rte_eal_version.map | 2 +\n 8 files changed, 119 insertions(+), 19 deletions(-)\n create mode 100644 lib/librte_eal/common/rte_random.c", "diff": "diff --git a/lib/librte_eal/common/include/rte_random.h b/lib/librte_eal/common/include/rte_random.h\nindex b2ca1c209..bca85a672 100644\n--- a/lib/librte_eal/common/include/rte_random.h\n+++ b/lib/librte_eal/common/include/rte_random.h\n@@ -16,7 +16,6 @@ extern \"C\" {\n #endif\n \n #include <stdint.h>\n-#include <stdlib.h>\n \n /**\n * Seed the pseudo-random generator.\n@@ -25,14 +24,15 @@ extern \"C\" {\n * value. It may need to be re-seeded by the user with a real random\n * value.\n *\n+ * This function is not multi-thread safe in regards to other\n+ * rte_srand() calls, nor is it in relation to concurrent rte_rand()\n+ * calls.\n+ *\n * @param seedval\n * The value of the seed.\n */\n-static inline void\n-rte_srand(uint64_t seedval)\n-{\n-\tsrand48((long)seedval);\n-}\n+void\n+rte_srand(uint64_t seedval);\n \n /**\n * Get a pseudo-random value.\n@@ -41,18 +41,13 @@ rte_srand(uint64_t seedval)\n * congruential algorithm and 48-bit integer arithmetic, called twice\n * to generate a 64-bit value.\n *\n+ * If called from lcore threads, this function is thread-safe.\n+ *\n * @return\n * A pseudo-random value between 0 and (1<<64)-1.\n */\n-static inline uint64_t\n-rte_rand(void)\n-{\n-\tuint64_t val;\n-\tval = (uint64_t)lrand48();\n-\tval <<= 32;\n-\tval += (uint64_t)lrand48();\n-\treturn val;\n-}\n+uint64_t\n+rte_rand(void);\n \n #ifdef __cplusplus\n }\ndiff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build\nindex 0670e4102..bafd23207 100644\n--- a/lib/librte_eal/common/meson.build\n+++ b/lib/librte_eal/common/meson.build\n@@ -35,6 +35,7 @@ common_sources = files(\n \t'rte_keepalive.c',\n \t'rte_malloc.c',\n \t'rte_option.c',\n+\t'rte_random.c',\n \t'rte_reciprocal.c',\n \t'rte_service.c'\n )\ndiff --git a/lib/librte_eal/common/rte_random.c b/lib/librte_eal/common/rte_random.c\nnew file mode 100644\nindex 000000000..b8fb7006e\n--- /dev/null\n+++ b/lib/librte_eal/common/rte_random.c\n@@ -0,0 +1,104 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2019 Ericsson AB\n+ */\n+\n+#include <stdlib.h>\n+\n+#include <rte_cycles.h>\n+#include <rte_eal.h>\n+#include <rte_lcore.h>\n+#include <rte_random.h>\n+\n+struct rte_rand_state {\n+\tuint32_t z1;\n+\tuint32_t z2;\n+\tuint32_t z3;\n+\tuint32_t z4;\n+} __rte_cache_aligned;\n+\n+static struct rte_rand_state rand_states[RTE_MAX_LCORE];\n+\n+static inline uint32_t\n+__rte_rand_lcg32(uint32_t *seed)\n+{\n+\t*seed = 1103515245U * *seed + 12345;\n+\treturn *seed;\n+}\n+\n+static uint32_t\n+__rte_rand_lfsr113_gen_seed(uint32_t *seed, uint32_t min_value)\n+{\n+\tuint32_t res = __rte_rand_lcg32(seed);\n+\n+\treturn res < min_value ? res + min_value : res;\n+}\n+\n+static void\n+__rte_srand_lfsr113(uint32_t seed, struct rte_rand_state *state)\n+{\n+\tuint32_t lcg32_seed = seed;\n+\tstate->z1 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 2U);\n+\tstate->z2 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 8U);\n+\tstate->z3 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 16U);\n+\tstate->z4 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 128U);\n+}\n+\n+void __rte_experimental\n+rte_srand(uint64_t seedval)\n+{\n+\tunsigned int lcore_id;\n+\n+\t/* add lcore_id to seed to avoid having the same sequence */\n+\tfor (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++)\n+\t\t__rte_srand_lfsr113(seedval + lcore_id, &rand_states[lcore_id]);\n+}\n+\n+static __rte_always_inline uint32_t\n+__rte_rand_lfsr113(uint32_t s, uint32_t a, uint32_t b, uint32_t c, uint32_t d)\n+{\n+\treturn ((s & c) << d) ^ (((s << a) ^ s) >> b);\n+}\n+\n+static __rte_always_inline uint32_t\n+__rte_rand32(struct rte_rand_state *state)\n+{\n+\tstate->z1 = __rte_rand_lfsr113(state->z1, 6U, 13U, 4294967294U, 18U);\n+\tstate->z2 = __rte_rand_lfsr113(state->z2, 2U, 27U, 4294967288U, 2U);\n+\tstate->z3 = __rte_rand_lfsr113(state->z3, 13U, 21U, 4294967280U, 7U);\n+\tstate->z4 = __rte_rand_lfsr113(state->z4, 3U, 12U, 4294967168U, 13U);\n+\n+\treturn state->z1 ^ state->z2 ^ state->z3 ^ state->z4;\n+}\n+\n+static __rte_always_inline\n+struct rte_rand_state *__rte_rand_get_state(void)\n+{\n+\tunsigned int lcore_id;\n+\n+\tlcore_id = rte_lcore_id();\n+\n+\tif (unlikely(lcore_id == LCORE_ID_ANY))\n+\t\tlcore_id = rte_get_master_lcore();\n+\n+\treturn &rand_states[lcore_id];\n+}\n+\n+uint64_t __rte_experimental\n+rte_rand(void)\n+{\n+\tstruct rte_rand_state *state;\n+\tuint64_t low;\n+\tuint64_t high;\n+\n+\tstate = __rte_rand_get_state();\n+\n+\tlow = __rte_rand32(state);\n+\thigh = __rte_rand32(state);\n+\n+\treturn low | (high << 32);\n+}\n+\n+RTE_INIT(rte_rand_init)\n+{\n+\trte_srand(rte_get_timer_cycles());\n+}\ndiff --git a/lib/librte_eal/freebsd/eal/Makefile b/lib/librte_eal/freebsd/eal/Makefile\nindex 19854ee2c..ca616c480 100644\n--- a/lib/librte_eal/freebsd/eal/Makefile\n+++ b/lib/librte_eal/freebsd/eal/Makefile\n@@ -69,6 +69,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += malloc_mp.c\n SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += rte_keepalive.c\n SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += rte_option.c\n SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += rte_service.c\n+SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += rte_random.c\n SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += rte_reciprocal.c\n \n # from arch dir\ndiff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c\nindex c6ac9028f..5d43310b3 100644\n--- a/lib/librte_eal/freebsd/eal/eal.c\n+++ b/lib/librte_eal/freebsd/eal/eal.c\n@@ -727,8 +727,6 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n-\trte_srand(rte_rdtsc());\n-\n \t/* in secondary processes, memory init may allocate additional fbarrays\n \t * not present in primary processes, so to avoid any potential issues,\n \t * initialize memzones first.\ndiff --git a/lib/librte_eal/linux/eal/Makefile b/lib/librte_eal/linux/eal/Makefile\nindex 6e5261152..729795a10 100644\n--- a/lib/librte_eal/linux/eal/Makefile\n+++ b/lib/librte_eal/linux/eal/Makefile\n@@ -77,6 +77,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += malloc_mp.c\n SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += rte_keepalive.c\n SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += rte_option.c\n SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += rte_service.c\n+SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += rte_random.c\n SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += rte_reciprocal.c\n \n # from arch dir\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex f7ae62d7b..c2bdf0a67 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -1083,8 +1083,6 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n-\trte_srand(rte_rdtsc());\n-\n \tif (rte_eal_log_init(logid, internal_config.syslog_facility) < 0) {\n \t\trte_eal_init_alert(\"Cannot init logging.\");\n \t\trte_errno = ENOMEM;\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex d6e375135..0d60668fa 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -366,10 +366,12 @@ EXPERIMENTAL {\n \trte_mp_request_async;\n \trte_mp_sendmsg;\n \trte_option_register;\n+\trte_rand;\n \trte_realloc_socket;\n \trte_service_lcore_attr_get;\n \trte_service_lcore_attr_reset_all;\n \trte_service_may_be_active;\n \trte_socket_count;\n \trte_socket_id_by_idx;\n+\trte_srand;\n };\n", "prefixes": [ "RFC", "1/3" ] }