Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52380,
    "url": "https://patches.dpdk.org/api/patches/52380/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1554692551-28275-4-git-send-email-phil.yang@arm.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1554692551-28275-4-git-send-email-phil.yang@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1554692551-28275-4-git-send-email-phil.yang@arm.com",
    "date": "2019-04-08T03:02:31",
    "name": "[v4,3/3] test/ring_perf: replace sync builtins with atomic builtins",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "09f725d0200d2be54d9ad814fbc1d69516a9b581",
    "submitter": {
        "id": 833,
        "url": "https://patches.dpdk.org/api/people/833/?format=api",
        "name": "Phil Yang",
        "email": "phil.yang@arm.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1554692551-28275-4-git-send-email-phil.yang@arm.com/mbox/",
    "series": [
        {
            "id": 4156,
            "url": "https://patches.dpdk.org/api/series/4156/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4156",
            "date": "2019-04-08T03:02:29",
            "name": "[v4,1/3] packet_ordering: add statistics for each worker thread",
            "version": 4,
            "mbox": "https://patches.dpdk.org/series/4156/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/52380/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/52380/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 00D034F93;\n\tMon,  8 Apr 2019 05:01:20 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.101.70])\n\tby dpdk.org (Postfix) with ESMTP id D41D74CA7\n\tfor <dev@dpdk.org>; Mon,  8 Apr 2019 05:01:13 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C77A1993;\n\tSun,  7 Apr 2019 20:01:13 -0700 (PDT)",
            "from phil-VirtualBox.shanghai.arm.com (unknown [10.169.108.140])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\tC31043F718; Sun,  7 Apr 2019 20:01:11 -0700 (PDT)"
        ],
        "From": "Phil Yang <phil.yang@arm.com>",
        "To": "dev@dpdk.org,\n\tthomas@monjalon.net",
        "Cc": "david.hunt@intel.com, reshma.pattan@intel.com, gavin.hu@arm.com,\n\thonnappa.nagarahalli@arm.com, phil.yang@arm.com, nd@arm.com",
        "Date": "Mon,  8 Apr 2019 11:02:31 +0800",
        "Message-Id": "<1554692551-28275-4-git-send-email-phil.yang@arm.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": [
            "<1554692551-28275-1-git-send-email-phil.yang@arm.com>",
            "<1546508946-12552-1-git-send-email-phil.yang@arm.com>"
        ],
        "References": [
            "<1554692551-28275-1-git-send-email-phil.yang@arm.com>",
            "<1546508946-12552-1-git-send-email-phil.yang@arm.com>"
        ],
        "Subject": "[dpdk-dev] [PATCH v4 3/3] test/ring_perf: replace sync builtins\n\twith atomic builtins",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "'__sync' built-in functions are deprecated, should use the '__atomic'\nbuilt-in instead. the sync built-in functions are full barriers, while\natomic built-in functions offer less restrictive one-way barriers,\nwhich help performance.\n\nHere is the example test result on TX2:\nsudo ./arm64-armv8a-linuxapp-gcc/app/test -c 0x7fffffe \\\n-n 4 --socket-mem=1024,0 --file-prefix=~ -- -i\nRTE>>ring_perf_autotest\n\n*** ring_perf_autotest without this patch ***\nSP/SC bulk enq/dequeue (size: 8): 6.22\nMP/MC bulk enq/dequeue (size: 8): 11.50\nSP/SC bulk enq/dequeue (size: 32): 1.85\nMP/MC bulk enq/dequeue (size: 32): 2.66\n\n*** ring_perf_autotest with this patch ***\nSP/SC bulk enq/dequeue (size: 8): 6.13\nMP/MC bulk enq/dequeue (size: 8): 9.83\nSP/SC bulk enq/dequeue (size: 32): 1.96\nMP/MC bulk enq/dequeue (size: 32): 2.30\n\nSo for the ring performance test, this patch improved 11% of ring\noperations performance.\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\n---\n app/test/test_ring_perf.c | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c\nindex ebb3939..e851c1a 100644\n--- a/app/test/test_ring_perf.c\n+++ b/app/test/test_ring_perf.c\n@@ -160,7 +160,11 @@ enqueue_bulk(void *p)\n \tunsigned i;\n \tvoid *burst[MAX_BURST] = {0};\n \n-\tif ( __sync_add_and_fetch(&lcore_count, 1) != 2 )\n+#ifdef RTE_USE_C11_MEM_MODEL\n+\tif (__atomic_add_fetch(&lcore_count, 1, __ATOMIC_RELAXED) != 2)\n+#else\n+\tif (__sync_add_and_fetch(&lcore_count, 1) != 2)\n+#endif\n \t\twhile(lcore_count != 2)\n \t\t\trte_pause();\n \n@@ -196,7 +200,11 @@ dequeue_bulk(void *p)\n \tunsigned i;\n \tvoid *burst[MAX_BURST] = {0};\n \n-\tif ( __sync_add_and_fetch(&lcore_count, 1) != 2 )\n+#ifdef RTE_USE_C11_MEM_MODEL\n+\tif (__atomic_add_fetch(&lcore_count, 1, __ATOMIC_RELAXED) != 2)\n+#else\n+\tif (__sync_add_and_fetch(&lcore_count, 1) != 2)\n+#endif\n \t\twhile(lcore_count != 2)\n \t\t\trte_pause();\n \n",
    "prefixes": [
        "v4",
        "3/3"
    ]
}