Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52364/?format=api
{ "id": 52364, "url": "https://patches.dpdk.org/api/patches/52364/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190405163115.5068-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190405163115.5068-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190405163115.5068-1-stephen@networkplumber.org", "date": "2019-04-05T16:31:15", "name": "[v2] virtio: fix buffer leak on vlan insert", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3007ee82407e92c8a0e3c420166f27681930fdf8", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190405163115.5068-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 4148, "url": "https://patches.dpdk.org/api/series/4148/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4148", "date": "2019-04-05T16:31:15", "name": "[v2] virtio: fix buffer leak on vlan insert", "version": 2, "mbox": "https://patches.dpdk.org/series/4148/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52364/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/52364/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3F1E81B563;\n\tFri, 5 Apr 2019 18:31:21 +0200 (CEST)", "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n\t[209.85.210.196]) by dpdk.org (Postfix) with ESMTP id A6E331B562\n\tfor <dev@dpdk.org>; Fri, 5 Apr 2019 18:31:19 +0200 (CEST)", "by mail-pf1-f196.google.com with SMTP id y13so3546598pfm.11\n\tfor <dev@dpdk.org>; Fri, 05 Apr 2019 09:31:19 -0700 (PDT)", "from localhost.localdomain ([167.220.102.127])\n\tby smtp.gmail.com with ESMTPSA id\n\th10sm34242764pfj.79.2019.04.05.09.31.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 05 Apr 2019 09:31:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=wA2R7QQad9oaW4s92wFbZGL4+bYMW53UU5WsTRbIvT4=;\n\tb=Fv0tywHljMEU/9rYmFlgNsTceUK09e8HUl7LjhsqGCBV4DsWW7rYYzjD1fnCviPSVZ\n\tImt+HwpF8QIAzK2VebePoWJwqsOB85pRLTxDyYVqlFHA7v46hHe50Eo/GGgBueuYqpG5\n\ti+0QEfPrSb0WwFdGVbUnn3q6V+VfdBhKDEe0RLiGWZkWNg4dhCnVDF+7rS0atF0+dqeK\n\tVYmJbH5UvljkAgau0xL+XhvQWaXttdOIa17YtSfSMV7GoOgboC5GZxCOTUttChvm0/id\n\tjceAWzniYCmQ2TjVVWMEPjI5Pjth4TNT7Eh1tQGVvmGefSTAyW1aXaGVLSbfZWumXE1F\n\tBWjg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=wA2R7QQad9oaW4s92wFbZGL4+bYMW53UU5WsTRbIvT4=;\n\tb=HSEU42/vLLPY1Bc7EWm3xgOGwiYSOvGFo5n0kq0hLA2LK0I9YPxYIjxFENQyqi8Eps\n\tHsuNAT7TYCcKeqTFl8RnsUsFsB41+YbuDf1pIdC12GNqUAtwxuUPafQCVHEQJAkZ5aAq\n\tVnePqCqfS5ZqLI3SpHp+DNZBpIbSJ8NGj5mNXmBXr8wyzRG4GlyFZf1k89eg3rC42GiK\n\t0xTUXJX05B/reTAAbOq8S8vg6jm3Do23GmBQivWAnCIUmyHCbElBL8tPxasJCGp4al4Y\n\tB8Lh868YVZgHLWCq59XLtTeQHoKMUBOS2Mxrl70vtQZFVvcnC7qrIb/T2iAxVbokinxj\n\t3dfg==", "X-Gm-Message-State": "APjAAAVDizszHwYrv1TuXRc7q2aCnaAKG5PhDehWb4JGzGogTqpgCEC2\n\txNcoRcyAART2Wism69Ql0rWxhv5dy4M=", "X-Google-Smtp-Source": "APXvYqykGLuR+PTCu1qEsbdzwLE2uGGQ1AIDSn2s6sph57vZB+O4g0yEnGe776UOqvqM6nKoHWI3Mg==", "X-Received": "by 2002:a65:53cb:: with SMTP id\n\tz11mr12777705pgr.139.1554481878255; \n\tFri, 05 Apr 2019 09:31:18 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 5 Apr 2019 09:31:15 -0700", "Message-Id": "<20190405163115.5068-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190405000343.24424-1-stephen@networkplumber.org>", "References": "<20190405000343.24424-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH v2] virtio: fix buffer leak on vlan insert", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function rte_vlan_insert may allocate a new buffer for the\nvlan header and return a different mbuf than originally passed.\nIn this case, the stored mbuf in txm[] array could point to wrong\nbuffer.\n\nFixes: dd856dfcb9e7 (\"virtio: use any layout on Tx\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\nv2 - catch a couple more places.\n The virtio code needs some refactoring to not have 3 copies of same\n loop...\n\n drivers/net/virtio/virtio_rxtx.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex e6f3706d6fe1..8c56f238f965 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -2003,6 +2003,8 @@ virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t\trte_pktmbuf_free(txm);\n \t\t\t\tcontinue;\n \t\t\t}\n+\t\t\t/* vlan_insert may add a header mbuf */\n+\t\t\ttx_pkts[nb_tx] = txm;\n \t\t}\n \n \t\t/* optimize ring usage */\n@@ -2090,6 +2092,8 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\t\trte_pktmbuf_free(txm);\n \t\t\t\tcontinue;\n \t\t\t}\n+\t\t\t/* vlan_insert may add a header mbuf */\n+\t\t\ttx_pkts[nb_tx] = txm;\n \t\t}\n \n \t\t/* optimize ring usage */\n@@ -2193,6 +2197,8 @@ virtio_xmit_pkts_inorder(void *tx_queue,\n \t\t\t\trte_pktmbuf_free(txm);\n \t\t\t\tcontinue;\n \t\t\t}\n+\t\t\t/* vlan_insert may add a header mbuf */\n+\t\t\ttx_pkts[nb_tx] = txm;\n \t\t}\n \n \t\t/* optimize ring usage */\n", "prefixes": [ "v2" ] }