Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52313,
    "url": "https://patches.dpdk.org/api/patches/52313/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190405000343.24424-1-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190405000343.24424-1-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190405000343.24424-1-stephen@networkplumber.org",
    "date": "2019-04-05T00:03:43",
    "name": "virtio: fix buffer leak on vlan insert",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "a9205fa9a40b5dcf399c0f4eb00bfc2217d32480",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190405000343.24424-1-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 4125,
            "url": "https://patches.dpdk.org/api/series/4125/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4125",
            "date": "2019-04-05T00:03:43",
            "name": "virtio: fix buffer leak on vlan insert",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/4125/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/52313/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/52313/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 59B651B3B5;\n\tFri,  5 Apr 2019 02:03:49 +0200 (CEST)",
            "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 333291B3AC\n\tfor <dev@dpdk.org>; Fri,  5 Apr 2019 02:03:47 +0200 (CEST)",
            "by mail-pf1-f194.google.com with SMTP id w25so753156pfi.9\n\tfor <dev@dpdk.org>; Thu, 04 Apr 2019 17:03:47 -0700 (PDT)",
            "from localhost.localdomain ([167.220.104.255])\n\tby smtp.gmail.com with ESMTPSA id\n\tv6sm24866814pgv.92.2019.04.04.17.03.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 04 Apr 2019 17:03:44 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=wy4U3zIT9wlw8a91bQIdZX+MkjkVht/yBk/hLnV2N7s=;\n\tb=EVxGJMiXEMxJ+sE5afO6UecXKnrEEz64vZQ2Ynwv/n+SogG0ZWRQc54CnukjxSw1AQ\n\tBhf0kPt6vbdUdCh8YeZfXYbgBCZmxkNf7g6IOpBo2JqW/5cYtoSKJ5KJjQAeg3Fid1K8\n\tpTlc0FU+rAhVkkcvkNJKzJE2dvvyTp4r7qCjpwHt6tyKhMPgnB3foUilG+gP2JmNnmZK\n\tqOmya1QgRxxK3XD35bpQU1GeR2s9AKIDGolJBXyamvnH9FG2Wi2vlfWtXt7l+dxI5q+N\n\taw+hW47UsHBWvo+tqr01b0sg7KRDFn5t37toxoqH83gR91EJ88W1s/MnIb5bywlyjEVn\n\tJ0+Q==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=wy4U3zIT9wlw8a91bQIdZX+MkjkVht/yBk/hLnV2N7s=;\n\tb=G7aG5mQlTDoBOpfBuxsqyOPoewECmrBd+/t3VTJStfrhbnN/LcAttNMHi9DFnzLyC3\n\tu0qumolXcTDWLTMz7ovS2FYmZPWnzJqvPklTAPavAQ9cSWREbhidw48A3qUIZ/e8TDXq\n\tfSqZl8m0WpRrhlzsxiHtUsAm3Tf9RaVeutAK8RERjBfBrLqGJkMz92EL6khcX+Oa9rjO\n\t78/uss8Mm4hqHXplKV78mXPnqWFg29J9B+0UM0CIM06kqUOgfCF0rFGDowdkIJl/l/y3\n\t0WMe7Mlc70WokQ6DgFEkVaa1IpbXwpA/CVMqelxg8ODPSCQgJfUelcLr914G39N1R+9P\n\tns5g==",
        "X-Gm-Message-State": "APjAAAVAiygYxIfJfWkGaTHseqzxv8tlQKt0LZ+SzOGlo0enULB6V75H\n\tGXgyiRXtyKRB6nrklD5H9HplGA==",
        "X-Google-Smtp-Source": "APXvYqxju5IugQa+4j/pL5hyKEM0yB62O+3r55dp2YeicfSgZaniJQC/hBElLpmxz/+omxZ8kQFrMg==",
        "X-Received": "by 2002:a63:7843:: with SMTP id\n\tt64mr8332167pgc.178.1554422626193; \n\tThu, 04 Apr 2019 17:03:46 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "maxime.coquelin@redhat.com",
        "Cc": "dev@dpdk.org, stable@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>",
        "Date": "Thu,  4 Apr 2019 17:03:43 -0700",
        "Message-Id": "<20190405000343.24424-1-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] virtio: fix buffer leak on vlan insert",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The function rte_vlan_insert may allocate a new buffer for the\nvlan header and return a different mbuf than originally passed.\nIn this case, the stored mbuf in txm[] array could point to wrong\nbuffer.\n\nFixes: dd856dfcb9e7 (\"virtio: use any layout on Tx\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/virtio/virtio_rxtx.c | 2 ++\n 1 file changed, 2 insertions(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex e6f3706d6fe1..2ae4232c181d 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -2003,6 +2003,8 @@ virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t\trte_pktmbuf_free(txm);\n \t\t\t\tcontinue;\n \t\t\t}\n+\t\t\t/* vlan_insert may add a header mbuf */\n+\t\t\ttx_pkts[nb_tx] = txm;\n \t\t}\n \n \t\t/* optimize ring usage */\n",
    "prefixes": []
}