Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52162/?format=api
{ "id": 52162, "url": "https://patches.dpdk.org/api/patches/52162/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1554281333-119866-1-git-send-email-barbette@kth.se/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1554281333-119866-1-git-send-email-barbette@kth.se>", "list_archive_url": "https://inbox.dpdk.org/dev/1554281333-119866-1-git-send-email-barbette@kth.se", "date": "2019-04-03T08:48:53", "name": "reta_query: Doc requirements on reta_conf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5bc9bc91a527ea248e93edb5f6064cb2b12d4cde", "submitter": { "id": 1155, "url": "https://patches.dpdk.org/api/people/1155/?format=api", "name": "Tom Barbette", "email": "barbette@kth.se" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1554281333-119866-1-git-send-email-barbette@kth.se/mbox/", "series": [ { "id": 4078, "url": "https://patches.dpdk.org/api/series/4078/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4078", "date": "2019-04-03T08:48:53", "name": "reta_query: Doc requirements on reta_conf", "version": 1, "mbox": "https://patches.dpdk.org/series/4078/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52162/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/52162/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 500B35B2A;\n\tWed, 3 Apr 2019 10:49:17 +0200 (CEST)", "from smtp-3.sys.kth.se (smtp-3.sys.kth.se [130.237.48.192])\n\tby dpdk.org (Postfix) with ESMTP id 0B6B34C9D\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 10:49:16 +0200 (CEST)", "from smtp-3.sys.kth.se (localhost.localdomain [127.0.0.1])\n\tby smtp-3.sys.kth.se (Postfix) with ESMTP id C29C25783;\n\tWed, 3 Apr 2019 10:49:15 +0200 (CEST)", "from smtp-3.sys.kth.se ([127.0.0.1])\n\tby smtp-3.sys.kth.se (smtp-3.sys.kth.se [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith LMTP id RqWWe5Fz-SCR; Wed, 3 Apr 2019 10:49:15 +0200 (CEST)", "from nslrack08.ssvl.kth.se (nslrack08.ssvl.kth.se [192.16.125.168])\n\tby smtp-3.sys.kth.se (Postfix) with ESMTPSA id CF5F15C94;\n\tWed, 3 Apr 2019 10:49:14 +0200 (CEST)" ], "X-Virus-Scanned": "by amavisd-new at kth.se", "X-KTH-Auth": "barbette [192.16.125.168]", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default;\n\tt=1554281355; bh=apLNYZdaNb53T4rCVw4YxkR+kOvW1RM5WnvghBMadsc=;\n\th=From:To:Cc:Subject:Date;\n\tb=WPsaJF+8PDazp1l7QEpwbLpd8y9Ljgh11EvY33MZ98G6wjQSmeDQBBo/x//8CHW3n\n\tqJK2MK28ciTFD+A+a4gvN5FsNHhTF1fOdS8RGpwz517MT4/oyPaYhEE2AWDCkZIxgJ\n\tv8SyNKjfGYGYnDJucgYO/hKIaICw5WLQRH+VulpY=", "X-KTH-mail-from": "barbette@kth.se", "From": "Tom Barbette <barbette@kth.se>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com, \n\tTom Barbette <barbette@kth.se>", "Date": "Wed, 3 Apr 2019 10:48:53 +0200", "Message-Id": "<1554281333-119866-1-git-send-email-barbette@kth.se>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] reta_query: Doc requirements on reta_conf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As the librte function checks that bits of up to reta_size in reta_conf\nare set, the arg passed must have the mask set to 1. I spent quite some\ntime before finding the issue here, so I thought updating the doc may\nhelp other people.\n\nThe problem raise when the size of the table is not on a (byte?)\nboundary, eg when using a power-of-2 amount of queues with mlx5, the\ntable size becomes the number of queue. Then a usual (bzero)\ninitialization raise EINVAL, because of this bits problem.\n\nI'd say the requirement should go, one expects this functions to overwrite\nwhatever is passed as table arguments. Who would want to query the table\nexcept a few entries?\nMaybe (idk) mlx5 is actually the only device to support non-byte sized RSS\ntable, and mlx5 actually ignore the mask in reta_query...\n---\n lib/librte_ethdev/rte_ethdev.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex e254da8..ace425f 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -2941,7 +2941,7 @@ int rte_eth_dev_rss_reta_update(uint16_t port_id,\n * @param port_id\n * The port identifier of the Ethernet device.\n * @param reta_conf\n- * RETA to query.\n+ * RETA to query. The mask bits must be set according to reta_size.\n * @param reta_size\n * Redirection table size. The table size can be queried by\n * rte_eth_dev_info_get().\n", "prefixes": [] }