Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52089/?format=api
{ "id": 52089, "url": "https://patches.dpdk.org/api/patches/52089/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190402095255.848-2-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190402095255.848-2-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190402095255.848-2-pbhagavatula@marvell.com", "date": "2019-04-02T09:53:29", "name": "[v6,2/4] app/testpmd: use bulk ops for allocating segments", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0f8f152f9b06dcd207aa945155fef37920dcf8b8", "submitter": { "id": 1183, "url": "https://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190402095255.848-2-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 4051, "url": "https://patches.dpdk.org/api/series/4051/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4051", "date": "2019-04-02T09:53:25", "name": "[v6,1/4] app/testpmd: move eth header generation outside the loop", "version": 6, "mbox": "https://patches.dpdk.org/series/4051/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/52089/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/52089/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CAB1B4CBD;\n\tTue, 2 Apr 2019 11:53:47 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 57F104CA9\n\tfor <dev@dpdk.org>; Tue, 2 Apr 2019 11:53:46 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx329j7TW014284; Tue, 2 Apr 2019 02:53:45 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2rkrb49wyb-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tTue, 02 Apr 2019 02:53:45 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tTue, 2 Apr 2019 02:53:33 -0700", "from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.57)\n\tby SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1367.3 via Frontend Transport; Tue, 2 Apr 2019 02:53:33 -0700", "from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by\n\tCY4PR1801MB1926.namprd18.prod.outlook.com (10.171.255.29) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1750.15; Tue, 2 Apr 2019 09:53:29 +0000", "from CY4PR1801MB1863.namprd18.prod.outlook.com\n\t([fe80::e980:fa09:c83a:851d]) by\n\tCY4PR1801MB1863.namprd18.prod.outlook.com\n\t([fe80::e980:fa09:c83a:851d%3]) with mapi id 15.20.1750.021;\n\tTue, 2 Apr 2019 09:53:29 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : references : in-reply-to : content-type\n\t: content-transfer-encoding : mime-version; s=pfpt0818;\n\tbh=W+v9sI79nakrsfAu7P7vz12Jx78gz6RzalQiO7Ci4dI=;\n\tb=xecKy8X8ih8y+3ilO60IrmL/YokHHtMrMd+eNxo/6HbSm454+uIYvjAxQ28sjbfZmFDr\n\tqmkOVlM2XrC8h7C/TTBd048yyH2CBwXjZqItN6DvlkSl8DIjZvOqpS0QPGncBGBJldn6\n\t8rXBAAfCIHHEAPqzbzuzR5Go/shg1WXIQX/IEqNiTOHqjwUDhr4aiZ4BUJTAg3wNiphW\n\t1Mpbai83LwzL9ia89GJkAYMUQMKXjSc86G0OlXVfSb5AETARH4gRnOtBV/uCPcEHTX2k\n\t9H57Cgc5qXmfwuVNqTSfBqHBNktxsqZbZbPN6KL6iJ3hJ35iTSjcR7k77DSCQbwDBVpw\n\tYQ== ", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=marvell.onmicrosoft.com; s=selector1-marvell-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=W+v9sI79nakrsfAu7P7vz12Jx78gz6RzalQiO7Ci4dI=;\n\tb=XuM6+dKkF57+NldtS4iJncQVGM3A+omJnI8zvGW8f+YNGxBu78LlgFRxVstj/VV8PK66oXUwQZr20gfr5ciMFbQxPJeojgAKlZRaX2eCyxeXzZKid9NMlbFhbhS5NOkh7YIO4iUbhugtDt0lqVABXcnF/hRbAKkJRE+u8Bk9QQg=" ], "From": "Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>", "To": "Jerin Jacob Kollanukkaran <jerinj@marvell.com>, \"thomas@monjalon.net\"\n\t<thomas@monjalon.net>, \"arybchenko@solarflare.com\"\n\t<arybchenko@solarflare.com>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>, \"bernard.iremonger@intel.com\"\n\t<bernard.iremonger@intel.com>,\n\t\"alialnu@mellanox.com\" <alialnu@mellanox.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Pavan Nikhilesh Bhagavatula\n\t<pbhagavatula@marvell.com>", "Thread-Topic": "[dpdk-dev] [PATCH v6 2/4] app/testpmd: use bulk ops for\n\tallocating segments", "Thread-Index": "AQHU6Tns0Gz3n/2CFU6CoEKy+UvxpQ==", "Date": "Tue, 2 Apr 2019 09:53:29 +0000", "Message-ID": "<20190402095255.848-2-pbhagavatula@marvell.com>", "References": "<20190228194128.14236-1-pbhagavatula@marvell.com>\n\t<20190402095255.848-1-pbhagavatula@marvell.com>", "In-Reply-To": "<20190402095255.848-1-pbhagavatula@marvell.com>", "Accept-Language": "en-IN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BM1PR0101CA0029.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:1a::15) To CY4PR1801MB1863.namprd18.prod.outlook.com\n\t(2603:10b6:910:7a::14)", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.21.0", "x-originating-ip": "[115.113.156.3]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "f5e444c1-2b9e-49d8-aeaf-08d6b7510ee9", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);\n\tSRVR:CY4PR1801MB1926; ", "x-ms-traffictypediagnostic": "CY4PR1801MB1926:", "x-microsoft-antispam-prvs": "<CY4PR1801MB1926B821F0D0AF5585A486ABDE560@CY4PR1801MB1926.namprd18.prod.outlook.com>", "x-forefront-prvs": "0995196AA2", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(366004)(396003)(136003)(346002)(39860400002)(376002)(189003)(199004)(6486002)(8676002)(55236004)(102836004)(106356001)(26005)(486006)(186003)(86362001)(476003)(107886003)(2906002)(105586002)(36756003)(11346002)(66066001)(2201001)(8936002)(71200400001)(305945005)(7736002)(2616005)(478600001)(4326008)(71190400001)(446003)(97736004)(6436002)(256004)(1076003)(2501003)(50226002)(54906003)(6506007)(316002)(81156014)(14454004)(81166006)(53936002)(25786009)(6116002)(52116002)(76176011)(110136005)(3846002)(5660300002)(6512007)(386003)(68736007)(99286004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1926;\n\tH:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: marvell.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "UhTSkmN7g2gOdLtU+SFb6f/7KNAQLb0EgJnnrgbGmaf/XvG7WJD9S2aAzNCQz+mXPn5/bLUry/F2abf/IMspRxJ8Swg/qJrKupM1/FZeHvbs4V19BDKRVR/vx54RNfr3k27zejPie1gHpoanazoUYPPdFlm4YWCSlnAzl2gO4LU33p2q0a4GuCWXI2suU3liPSgN0f016WToyTkdcWcGOkAsAcbYdmT8b6hMiwxzmg7j+Y2WPf1SO5VZV5LSiR0epoUKJpPKr+zVCnexnYo5+7MWEtVVK9UdUn4httu7opPkuPOC19MGSAN10yezYoGOlxMjfaULs465isy5h1NRVw8aOBntTy1zbCzHeb9E04DMvOcPwcoNX8tX2BVijlnPeEHBDMNAmzBSgF2W0EzmnZRVVPBcuCs63RS6EQozHpY=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-Network-Message-Id": "f5e444c1-2b9e-49d8-aeaf-08d6b7510ee9", "X-MS-Exchange-CrossTenant-originalarrivaltime": "02 Apr 2019 09:53:29.4246\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "70e1fb47-1155-421d-87fc-2e58f638b6e0", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR1801MB1926", "X-OriginatorOrg": "marvell.com", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-04-02_04:, , signatures=0", "Subject": "[dpdk-dev] [PATCH v6 2/4] app/testpmd: use bulk ops for allocating\n\tsegments", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nUse bulk ops for allocating segments instead of having a inner loop\nfor every segment.\nThis reduces the number of calls to the mempool layer.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n app/test-pmd/txonly.c | 16 +++++++++++-----\n 1 file changed, 11 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c\nindex 0d411dbf4..65171c1d1 100644\n--- a/app/test-pmd/txonly.c\n+++ b/app/test-pmd/txonly.c\n@@ -155,6 +155,7 @@ static void\n pkt_burst_transmit(struct fwd_stream *fs)\n {\n \tstruct rte_mbuf *pkts_burst[MAX_PKT_BURST];\n+\tstruct rte_mbuf *pkt_segs[RTE_MAX_SEGS_PER_PKT];\n \tstruct rte_port *txp;\n \tstruct rte_mbuf *pkt;\n \tstruct rte_mbuf *pkt_seg;\n@@ -216,18 +217,23 @@ pkt_burst_transmit(struct fwd_stream *fs)\n \t\trte_pktmbuf_reset_headroom(pkt);\n \t\tpkt->data_len = tx_pkt_seg_lengths[0];\n \t\tpkt_seg = pkt;\n+\n \t\tif (tx_pkt_split == TX_PKT_SPLIT_RND)\n \t\t\tnb_segs = random() % tx_pkt_nb_segs + 1;\n \t\telse\n \t\t\tnb_segs = tx_pkt_nb_segs;\n-\t\tpkt_len = pkt->data_len;\n-\t\tfor (i = 1; i < nb_segs; i++) {\n-\t\t\tpkt_seg->next = rte_mbuf_raw_alloc(mbp);\n-\t\t\tif (pkt_seg->next == NULL) {\n-\t\t\t\tpkt->nb_segs = i;\n+\n+\t\tif (nb_segs > 1) {\n+\t\t\tif (rte_mempool_get_bulk(mbp, (void **)pkt_segs,\n+\t\t\t\t\t\t\tnb_segs)) {\n \t\t\t\trte_pktmbuf_free(pkt);\n \t\t\t\tgoto nomore_mbuf;\n \t\t\t}\n+\t\t}\n+\n+\t\tpkt_len = pkt->data_len;\n+\t\tfor (i = 1; i < nb_segs; i++) {\n+\t\t\tpkt_seg->next = pkt_segs[i - 1];\n \t\t\tpkt_seg = pkt_seg->next;\n \t\t\tpkt_seg->data_len = tx_pkt_seg_lengths[i];\n \t\t\tpkt_len += pkt_seg->data_len;\n", "prefixes": [ "v6", "2/4" ] }