Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51491/?format=api
{ "id": 51491, "url": "https://patches.dpdk.org/api/patches/51491/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1553200094-5487-1-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1553200094-5487-1-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1553200094-5487-1-git-send-email-david.marchand@redhat.com", "date": "2019-03-21T20:28:13", "name": "[1/2] net/bonding: fix more incorrect slave id types", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d145ba2f586091ecedbb31060a4f9a80ffef60bc", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1553200094-5487-1-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 3858, "url": "https://patches.dpdk.org/api/series/3858/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3858", "date": "2019-03-21T20:28:13", "name": "[1/2] net/bonding: fix more incorrect slave id types", "version": 1, "mbox": "https://patches.dpdk.org/series/3858/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/51491/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/51491/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 648731B535;\n\tThu, 21 Mar 2019 21:28:24 +0100 (CET)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 74B3A1B526;\n\tThu, 21 Mar 2019 21:28:22 +0100 (CET)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CA2F1308FC5F;\n\tThu, 21 Mar 2019 20:28:21 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com\n\t[10.40.204.129])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 295865C659;\n\tThu, 21 Mar 2019 20:28:19 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, chas3@att.com, zhaohui8@huawei.com,\n\tstable@dpdk.org", "Date": "Thu, 21 Mar 2019 21:28:13 +0100", "Message-Id": "<1553200094-5487-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.43]); Thu, 21 Mar 2019 20:28:21 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 1/2] net/bonding: fix more incorrect slave id\n\ttypes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Zhaohui <zhaohui8@huawei.com>\n\nmode_bond_id and mode_band_id are slave ids, stored on 16bits.\n\nFixes: f8244c6399d9 (\"ethdev: increase port id range\")\nCc: stable@dpdk.org\n\nSigned-off-by: Zhaohui <zhaohui8@huawei.com>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/bonding/rte_eth_bond_8023ad.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\nindex 1e6a3fc..3943ec1 100644\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\n@@ -638,7 +638,7 @@\n \tSM_FLAG_CLR(port, NTT);\n }\n \n-static uint8_t\n+static uint16_t\n max_index(uint64_t *a, int n)\n {\n \tif (n <= 0)\n@@ -672,7 +672,8 @@\n \tuint64_t agg_bandwidth[8] = {0};\n \tuint64_t agg_count[8] = {0};\n \tuint16_t default_slave = 0;\n-\tuint8_t mode_count_id, mode_band_id;\n+\tuint16_t mode_count_id;\n+\tuint16_t mode_band_id;\n \tstruct rte_eth_link link_info;\n \n \tslaves = internals->active_slaves;\n@@ -708,13 +709,11 @@\n \n \tswitch (internals->mode4.agg_selection) {\n \tcase AGG_COUNT:\n-\t\tmode_count_id = max_index(\n-\t\t\t\t(uint64_t *)agg_count, slaves_count);\n+\t\tmode_count_id = max_index(agg_count, slaves_count);\n \t\tnew_agg_id = mode_count_id;\n \t\tbreak;\n \tcase AGG_BANDWIDTH:\n-\t\tmode_band_id = max_index(\n-\t\t\t\t(uint64_t *)agg_bandwidth, slaves_count);\n+\t\tmode_band_id = max_index(agg_bandwidth, slaves_count);\n \t\tnew_agg_id = mode_band_id;\n \t\tbreak;\n \tcase AGG_STABLE:\n", "prefixes": [ "1/2" ] }