Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51474/?format=api
{ "id": 51474, "url": "https://patches.dpdk.org/api/patches/51474/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/E107353650813740A09E8EDB2EFDB9C235BE8E07@dggeml529-mbx.china.huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<E107353650813740A09E8EDB2EFDB9C235BE8E07@dggeml529-mbx.china.huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/E107353650813740A09E8EDB2EFDB9C235BE8E07@dggeml529-mbx.china.huawei.com", "date": "2019-03-20T13:54:34", "name": "答复: [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "19747e10630b243126669d222e3b6b0365d71631", "submitter": { "id": 1238, "url": "https://patches.dpdk.org/api/people/1238/?format=api", "name": "Zhaohui (zhaohui, Polestar)", "email": "zhaohui8@huawei.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/E107353650813740A09E8EDB2EFDB9C235BE8E07@dggeml529-mbx.china.huawei.com/mbox/", "series": [ { "id": 3848, "url": "https://patches.dpdk.org/api/series/3848/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3848", "date": "2019-03-20T13:54:34", "name": "答复: [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4", "version": 1, "mbox": "https://patches.dpdk.org/series/3848/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/51474/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/51474/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B86481B476;\n\tThu, 21 Mar 2019 10:29:36 +0100 (CET)", "from huawei.com (szxga01-in.huawei.com [45.249.212.187])\n\tby dpdk.org (Postfix) with ESMTP id DC4D0695D;\n\tWed, 20 Mar 2019 14:54:43 +0100 (CET)", "from DGGEML404-HUB.china.huawei.com (unknown [172.30.72.53])\n\tby Forcepoint Email with ESMTP id C4D8AB6C90D97D38EF74;\n\tWed, 20 Mar 2019 21:54:40 +0800 (CST)", "from DGGEML529-MBX.china.huawei.com ([169.254.6.70]) by\n\tDGGEML404-HUB.china.huawei.com ([fe80::b177:a243:7a69:5ab8%31]) with\n\tmapi id 14.03.0415.000; Wed, 20 Mar 2019 21:54:34 +0800" ], "From": "\"Zhaohui (zhaohui, Polestar)\" <zhaohui8@huawei.com>", "To": "David Marchand <david.marchand@redhat.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Chas Williams <3chas3@gmail.com>, \"Ferruh\n\tYigit\" <ferruh.yigit@intel.com>, chenchanghu <chenchanghu@huawei.com>,\n\t\"stable@dpdk.org\" <stable@dpdk.org>, wangyunjian <wangyunjian@huawei.com>", "Thread-Topic": "=?utf-8?q?=5Bdpdk-dev=5D_=5BPATCH=5D_net/bonding=3A_fix_Seg?=\n\t=?utf-8?q?fault_when_eal_thread_executing_nic=E2=80=98s_lsc_event_?=\n\t=?utf-8?q?for_mode_4?=", "Thread-Index": "AdTfF7pcdYdJTtR7SJmdzxb2JwZX9f//jxoA//94GpA=", "Date": "Wed, 20 Mar 2019 13:54:34 +0000", "Message-ID": "<E107353650813740A09E8EDB2EFDB9C235BE8E07@dggeml529-mbx.china.huawei.com>", "References": "<E107353650813740A09E8EDB2EFDB9C235BE6DCC@dggeml529-mbx.china.huawei.com>\n\t<CAJFAV8wrARXR0XgdJhE1nSA0ahom5YYx1wn7n1g33bfY5LxKMQ@mail.gmail.com>", "In-Reply-To": "<CAJFAV8wrARXR0XgdJhE1nSA0ahom5YYx1wn7n1g33bfY5LxKMQ@mail.gmail.com>", "Accept-Language": "en-US", "Content-Language": "zh-CN", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.62.33.217]", "MIME-Version": "1.0", "X-CFilter-Loop": "Reflected", "X-Mailman-Approved-At": "Thu, 21 Mar 2019 10:29:35 +0100", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] =?utf-8?b?562U5aSNOiAgW1BBVENIXSBuZXQvYm9uZGluZzogZml4?=\n\t=?utf-8?q?_Segfault_when_eal_thread_executing_nic=E2=80=98s_lsc_ev?=\n\t=?utf-8?q?ent_for_mode_4?=", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Well done, Can you fix it?\n thanks\n by zhaohui\n\n发件人: David Marchand [mailto:david.marchand@redhat.com]\n发送时间: 2019年3月20日 21:39\n收件人: Zhaohui (zhaohui, Polestar) <zhaohui8@huawei.com>\n抄送: dev@dpdk.org; Chas Williams <3chas3@gmail.com>; Ferruh Yigit <ferruh.yigit@intel.com>; chenchanghu <chenchanghu@huawei.com>; stable@dpdk.org; wangyunjian <wangyunjian@huawei.com>\n主题: Re: [dpdk-dev] [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4\n\n\n\nOn Wed, Mar 20, 2019 at 2:26 PM Zhaohui (zhaohui, Polestar) <zhaohui8@huawei.com<mailto:zhaohui8@huawei.com>> wrote:\nHi：\n When the number of slave slave devices exceeds 8, it will cause the array subscript to cross the boundary.\n According to the suggestions, Modified array subscript to RTE_MAX_ETHPORTS, and Changed uint8_t to uint16_t. Something like this:\n\nFrom 51a081ea88cca1599d458d8d1c7d9605a6eb3352 Mon Sep 17 00:00:00 2001\nFrom: zhaohui8 <zhaohui8@huawei.com<mailto:zhaohui8@huawei.com>>\nDate: Wed, 20 Mar 2019 20:17:27 +0800\nSubject: [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4\n\nChange-Id: I6d800a3adf5ca51f295b607de879bcb0ccc20004\n---\ndrivers/net/bonding/rte_eth_bond_8023ad.c | 12 ++++++------\n1 file changed, 6 insertions(+), 6 deletions(-)\n\n * @param port_pos Port to assign.\n */\nstatic void\n-selection_logic(struct bond_dev_private *internals, uint8_t slave_id)\n+selection_logic(struct bond_dev_private *internals, uint16_t slave_id)\n{\n struct port *agg, *port;\n uint16_t slaves_count, new_agg_id, i, j = 0;\n uint16_t *slaves;\n- uint64_t agg_bandwidth[8] = {0};\n- uint64_t agg_count[8] = {0};\n+ uint64_t agg_bandwidth[RTE_MAX_ETHPORTS] = {0};\n+ uint64_t agg_count[RTE_MAX_ETHPORTS] = {0};\n uint16_t default_slave = 0;\n- uint8_t mode_count_id, mode_band_id;\n+ uint16_t mode_count_id, mode_band_id;\n struct rte_eth_link link_info;\n slaves = internals->active_slaves;\n@@ -806,7 +806,7 @@\n struct ether_addr slave_addr;\n struct rte_mbuf *lacp_pkt = NULL;\n- uint8_t i, slave_id;\n+ uint16_t i, slave_id;\n\n /* Update link status on each port */\n--\n1.9.5.msysgit.0\n\nOh, I had missed this [8] array, good catch.\nFor the slave id on 16bits, I sent this earlier:\nhttp://patchwork.dpdk.org/patch/51387/\n\nAnd I have other fixes for 802.3ad that I will send once properly tested.\n\n\n--\nDavid Marchand", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\r\nindex dd847c6..4d99239 100644\r\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\r\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\r\n@@ -638,7 +638,7 @@\r\n SM_FLAG_CLR(port, NTT);\r\n}\r\n-static uint8_t\r\n+static uint16_t\r\nmax_index(uint64_t *a, int n)\r\n{\r\n if (n <= 0)\r\n@@ -664,15 +664,15 @@\r\n", "prefixes": [] }